wangxuming/makelore
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
faf751be5e32f46941f4e50e0c8b78d38a53c3b8
makelore/.project-docs/30-worklog/tasks/20260906-coding-default-page-a7c42e.md
inman faf751be5e fix: refine coding project landing actions
2026-09-06 15:45:22 +08:00

6.3 KiB
Raw Blame History

Task: Redesign Coding default page

Identity

  • Task ID: 20260906-coding-default-page-a7c42e
  • Mode: Feature
  • Branch: codex/20260906-coding-default-page-a7c42e-coding-default-page
  • Worktree: /Users/inmanx/Documents/makelore-task-coding-default-page-a7c42e
  • Base commit: f8eee430f4
  • Owner: codex
  • Status: Ready for Integration

Scope

  • Replace the no-project Code entry redirect with a dedicated conversation-first landing state on /chat.
  • Restyle both the no-project landing and the empty Conversation timeline around the existing Makelore M brand mark, a large centered prompt, and the spacious vertical hierarchy shown in the supplied Codex reference.
  • Keep project creation reachable from the landing surface and update focused Renderer/Electron coverage plus README current-state wording.
  • Apply the user's follow-up correction: the lower landing surface is a standalone 新增项目 CTA followed by horizontally arranged existing-project cards, not a composer-shaped project starter.

Intent And Constraints

  • Reuse src/assets/logo.svg; do not copy or approximate the Codex mark and do not generate a new brand asset.
  • Preserve the single Makelore light visual system, bundled typography, Chinese UI, project-local .makelore authority, and all Main-owned runtime/API seams.
  • The no-project call to action must open the existing Sidebar project-creation flow rather than introducing a second creation implementation; existing-project cards must likewise reuse the Sidebar's validated project-entry behavior.
  • Existing projects, Agent selection, Conversation creation, Composer behavior, model/runtime controls, and accepted/uncertain mutation semantics remain unchanged.
  • Completed peer tasks for Plugin rehoming and removal of the project setup gate overlap in Code-entry files but have no committed branch tips to consume. This task therefore stays isolated on the recorded base and keeps its changes small enough for later semantic integration.

Outcome

  • Code now resolves an empty local project list to /chat instead of redirecting to Project Configuration.
  • The no-project view uses the existing Makelore M vector asset and a large centered guide sentence while retaining the Makelore sidebar and light visual system. Its lower surface now uses the user's clarified standalone orange 新增项目 CTA followed by an overflow-safe horizontal row of existing projects.
  • Project creation reuses the Sidebar's existing dialog through a renderer-local event bridge; project-card selection uses the same bridge to invoke the Sidebar's validated entry flow instead of duplicating project activation.
  • Each project card is backed by the real local project catalog and exposes the project name and last-opened date; an empty catalog shows only the CTA and does not fabricate sample projects.
  • Empty Conversations reuse the same branded hero above the real editable Composer and automatically yield to the normal timeline after the first entry.
  • README current-state wording, focused unit coverage, and the Code-entry Electron navigation regression were updated. A side-by-side visual QA pass is recorded in project-root design-qa.md with final result: passed.

Verification

  • corepack pnpm install --frozen-lockfile — passed with pinned pnpm 10.33.4.
  • corepack pnpm run typecheck — passed.
  • corepack pnpm exec vitest run tests/unit/coding-chat-panel.test.tsx tests/unit/coding-conversation-timeline.test.tsx tests/unit/module-navigation.test.tsx tests/unit/app-module-provider-gate.test.tsx --maxWorkers=4 — 4 files, 58 tests passed.
  • Follow-up focused run: corepack pnpm exec vitest run tests/unit/coding-chat-panel.test.tsx tests/unit/coding-project-entry.test.ts tests/unit/module-navigation.test.tsx tests/unit/app-module-provider-gate.test.tsx --maxWorkers=4 — 4 files, 48 tests passed.
  • corepack pnpm test — 223 files passed; 1,863 tests passed and 3 skipped.
  • corepack pnpm run lint:check — passed with 0 errors and the repository's 5 pre-existing warnings in src/pages/Home/index.tsx and src/pages/Makelore/index.tsx.
  • corepack pnpm run build:vite — Renderer, Electron Main, Preload, and utility worker production builds passed; only existing Browserslist, mixed-import, and chunk-size warnings were emitted.
  • corepack pnpm exec playwright test tests/e2e/main-navigation.spec.ts --grep "offers a create CTA|returns to the module chooser" — 2 tests passed against the built Electron app, covering empty and remembered-project entry states, horizontal card order, direct card entry, /chat, and project-dialog launch.
  • git diff --check — passed.
  • Visual comparison: /Users/inmanx/.codex/visualizations/2026/09/06/01a0756a-b6f5-7892-a11c-1c1608ebe592/codex-reference-vs-makelore-v2.png plus the focused lower crop /Users/inmanx/.codex/visualizations/2026/09/06/01a0756a-b6f5-7892-a11c-1c1608ebe592/codex-reference-vs-makelore-v2-bottom.png — the user-identified composer/CTA mismatch is resolved and no actionable P0/P1/P2 differences remain.

Follow-ups

  • During integration, semantically reconcile App.tsx, Sidebar.tsx, and the Code-entry tests with the concurrently completed but uncommitted Plugin-rehoming and project-gate-removal tasks; their branch tips contain no commits to merge or cherry-pick from this feature worktree.

Promotion Candidates

  • Target: .project-docs/30-worklog/current-state.md and .project-docs/40-domain/business-rules.md. Proposal: record that entering Code with no active local project remains on /chat, presents the branded hero, a standalone 新增项目 CTA, and real local projects as a horizontal card row. Creation and project-card entry route through the single existing Sidebar flows; empty Conversations share the same brand hero until their first entry. Evidence: focused unit coverage, the passing Electron navigation regression, production build, and the passed side-by-side visual QA. Future impact: future routing or setup work must not restore the configuration redirect or a second project-creation implementation. Human confirmation: not required for intent because the user explicitly requested this entry behavior; integration still must reconcile the overlapping peer tasks semantically.