3.7 KiB
3.7 KiB
Task: Remove selected-user sharing from cloud agent access UI
Identity
- Task ID: 20260919-remove-agent-user-share-64b7c21e
- Mode: Feature
- Branch: codex/20260919-remove-agent-user-share-64b7c21e-remove-agent-user-share
- Worktree: D:\Datas\OthersProjects.codex-worktrees\makelore\20260919-remove-agent-user-share-64b7c21e
- Base commit:
7fb4c60492 - Owner: codex
- Status: Ready for Integration
Scope
- Remove the selected-user sharing section from the cloud-agent access page, including user lookup, grants controls, and the share link. Rename the visible entry to 使用与接入 and align related guidance.
- Update README and focused unit/Electron interaction coverage. Leave CloudCosts implementation owned by the usage-filter-alignment peer unchanged.
Intent And Constraints
- The user explicitly requested removal of the highlighted 分享给指定用户 module. This is a client UI removal; existing server grants, backend contracts, authentication, API applications, WeChat routing, and billing remain unchanged.
- Isolated feature work from main
7fb4c60492. No merge, deployment, package, or cleanup included. - Concurrent Task Gate and Planning Gate passed. Peer CloudCosts work has no conflicting semantics; historical incomplete peer records remain read-only with unknown coordination state.
Outcome
- Removed the selected-user sharing block and its user-search state, grant actions, copy handler and icons from CloudAccessPanel.
- Renamed 使用与分享 to 使用与接入. Related access/capability guidance and README now describe WeChat and application API entry points.
- Existing backend grants are not revoked; the client no longer offers grant controls or a share link. Applications, publication, channels, costs, and lifecycle controls remain.
- Reviewed the complete diff and the Electron screenshot: associated channels flow directly into application API management, without a sharing section.
Verification
- Exact pinned pnpm 10.33.4 dependency install with frozen lockfile: passed; lockfile unchanged.
- pnpm run typecheck: passed.
- Focused ESLint on three changed UI modules and three changed test files: passed.
- Vitest cloud-agents-workflows, cloud-agents-page, cloud-agents-guidance: 3 files, 50 tests passed. Regression includes populated legacy grants/share URL, no sharing controls or mutation calls, and successful application creation.
- pnpm run build:vite: passed (existing bundle-size warning).
- Electron cloud-agents.spec.ts: 1 passed, including renamed navigation, sharing controls absent, and channel/application entries present; publication and conversation flows continue to pass.
- Visually inspected test-results/cloud-agents-personal-clou-f6c7b-eave-protection-in-Electron/cloud-agent-access-without-user-sharing.png.
- git diff --check and check_doc_drift.py --task-id 20260919-remove-agent-user-share-64b7c21e: passed.
Follow-ups
- Merge and deployment are outside this task; the change becomes visible after shipping the updated client.
Promotion Candidates
- Targets: .project-docs/10-decisions/ADR-2026-09-11-personal-cloud-agents.md and .project-docs/current-state.md. Update the desktop access workflow: it offers WeChat and application API management, and no longer offers selected-user sharing controls or a share link.
- Evidence: explicit user request and the resulting UI/test changes. Future impact: avoid reintroducing the removed sharing module in desktop flows.
- Semantic conflict: supersedes the accepted decision's selected-user-sharing UI entry only; server grants and historical billing data remain unchanged. Human confirmation: already provided by the user's explicit removal request; no additional decision needed for this scope.