wangxuming/makelore
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
62304dc85b3c1069cd656dfacb61ee820e216fa2
makelore/.project-docs/30-worklog/tasks/20260820-integrate-remember-password-5d7e3a1c.md

4.5 KiB
Raw Blame History

Task: Integrate remember password into main

Identity

  • Task ID: 20260820-integrate-remember-password-5d7e3a1c
  • Mode: Integration
  • Branch: main
  • Worktree: D:\Datas\OthersProjects\makelore
  • Base commit: 460268586b
  • Owner: codex
  • Status: Blocked

Scope

  • Integrate verified remember-password source commit 990639f into local main.
  • Integrate follow-up login-layout source commit 4d512b1, placing “记住密码” below the login button without changing credential behavior.
  • Reconcile the source task's accepted authentication promotion candidates into canonical current-state, architecture, ADR, and domain documents.
  • Preserve the pre-existing untracked packaging task record without modifying or committing it.

Intent And Constraints

  • Keep remembered credentials separate from the existing seven-day Works Square session.
  • Keep password persistence Main-owned and OS-encrypted in packaged builds; do not persist passwords in Renderer or Works Square.
  • Preserve logout/SMS retention and successful unchecked-password-login clearing semantics.
  • Treat the follow-up as presentation order only; do not change the canonical remembered-password security boundary.
  • Merge only to local main; do not push.

Outcome

  • Source feature commit 990639f was created from the completed isolated feature worktree.
  • Merged the source branch into local main as merge commit 2b9f84e without conflicts; README auto-merged with the already integrated Session-model documentation.
  • Promoted the accepted remembered-password boundary into current-state.md, system-overview.md, ADR-004, and business-rules.md.
  • Created follow-up source commit 4d512b1 and merged it into local main as 22f4bbc without conflicts. Password login now renders the submit button before the existing remember-password control, with the agreement remaining below both.
  • Kept the follow-up layout-only: authentication, Main-owned persistence, Works requests, validation, and spacing tokens are unchanged.
  • Recorded the follow-up source and merge commits under canonical current-state.md without changing the existing architecture, ADR, or domain rules.
  • Preserved .project-docs/30-worklog/tasks/20260819-package-learning-off-115-9c4d.md untouched and untracked.

Verification

  • Source verification: 79 focused tests, typecheck, scoped ESLint, and Vite Renderer/Main/Preload/utility build passed.
  • Integrated local main: 4 focused test files / 79 tests passed.
  • Integrated local main: pnpm run typecheck passed.
  • Integrated local main: scoped ESLint passed with zero errors.
  • Integrated local main: Renderer/Main/Preload/utility pnpm run build:vite passed with existing dynamic-import and large-chunk advisory warnings only.
  • Follow-up integrated local main: tests/unit/login-page.test.tsx passed, 1 file / 13 tests.
  • Follow-up integrated local main: scoped ESLint and pnpm run typecheck passed.
  • Follow-up integrated local main: Renderer/Main/Preload/utility pnpm run build:vite passed with the same existing advisory warnings.
  • Follow-up integrated local main: repository Playwright CLI ran the focused native-login Electron smoke, 1 test passed, including the rendered vertical-order assertion.
  • git diff --check passed with line-ending conversion notices only.
  • Required project-docs structure check passed.
  • Task-aware documentation drift is blocked by three read-only foreign task records: the pre-existing, explicitly preserved untracked .project-docs/30-worklog/tasks/20260819-package-learning-off-115-9c4d.md, the original source task record .project-docs/30-worklog/tasks/20260820-makelore-remember-password-b63e1c.md, and the follow-up source task record .project-docs/30-worklog/tasks/20260821-remember-below-login-4a7c91d2.md introduced unchanged by their merge commits. The integration did not modify those records. The checker also lists the expected merged source files as non-document changes.

Follow-ups

  • Run packaged Windows and signed macOS smoke for OS-protected save, restart prefill, successful unchecked-login clear, and no development Keychain prompt.
  • Resolve the repository's integration drift-check handling for unchanged source task records and decide the separately owned untracked packaging record before this integration ownership can be completed and released cleanly.
  • The login-layout follow-up has no canonical promotion candidate; no shared architecture or domain document needs another semantic update.

Promotion Candidates

  • Applied all accepted source candidates; none remain pending.