feat: improve project agent onboarding

This commit is contained in:
2026-09-06 13:54:20 +08:00
parent a4fc3a5251
commit df02680f9d
15 changed files with 826 additions and 74 deletions

View File

@@ -36,59 +36,72 @@
## Outcome
- Confirmed that the screenshot's “项目智能体” is a persisted project-owned parent Agent,
not a runtime child Agent. ADR-006 and ADR-008 deliberately keep child Agents ephemeral
and without inherited project Plugin resources.
- Confirmed a state-invariant gap: Project Configuration validates only the Agents that
exist, so an empty Agent array passes; `submit()` then saves `initialized: true`.
`ProjectChatRoute` and `MainLayout` gate only on that boolean, despite the gate copy
claiming that at least one manually configured Agent is required.
- Confirmed the resulting dead-end presentation: Coding chat has no selected Agent, clears
the Conversation selection, renders only a small “当前项目还没有可用智能体” sidebar
message, leaves the main canvas empty, and disables the Composer without a recovery CTA.
- Confirmed the navigation gap: Project Configuration uses history-relative
`navigate(-1)`. The destination depends on how the page was entered and can even be a
visually identical Project Configuration history entry; saving does not navigate to
the Conversation page.
- Confirmed an additional supported-path gap: first-run Setup does not configure a model.
With zero model options, the create-Agent icon shows a toast and opens a read-only model
drawer that contains no direct action to `/models`, so stronger Agent guidance alone
would still lead some users into a dead end.
- Recommended the “required but escapable” flow: an incomplete project may exist and the
user may leave, but completion/Conversation readiness requires at least one enabled,
unarchived, fully configured project Agent. In the empty state, replace the icon-only
instruction with a prominent text CTA; after the first Agent is valid, make the primary
action “保存并进入对话” with deterministic `/chat` navigation. Keep a full chat recovery
state for legacy/archived-all data and route it directly back to Agent creation.
- Recommended treating zero models as an explicit prerequisite state with a “先配置模型”
CTA and a return intent, and replacing history-relative back behavior with context-aware,
labelled destinations such as “返回对话” or “稍后设置”.
- No product behavior or source code was changed.
- Confirmed that the screenshot's “项目智能体” is the persisted project-owned parent
Agent, not an ephemeral runtime child Agent, and retained that terminology throughout.
- Added one shared Conversation-readiness rule: `initialized` must be true and the project
must contain at least one enabled, unarchived Agent with a non-empty name, avatar, role,
responsibility, and resolved model. Project list entry, direct `/chat` resolution,
the programming-module gate, and Coding chat now use the same rule instead of trusting
`initialized` alone.
- Reworked the zero-ready-Agent configuration state into a prominent required-step card.
With no model it offers “先配置模型” and a direct model-settings action; otherwise it
creates the first Agent or resumes an enabled incomplete Agent. Disabled-only state
intentionally offers a new Agent because the edit dialog has no enable control.
- The first Agent is persisted immediately and then navigates to `/chat`. Later Agent
additions and edits retain the existing page-draft plus explicit-save behavior.
- Replaced history-relative back navigation with labelled, deterministic “返回对话” or
“稍后设置” destinations. Unsaved Agent changes are confirmed before any page exit,
including the model-settings prerequisite path.
- Archiving the last ready Agent now explains that saving will return the project to a
pending state; saving that state clears `initialized` and leaves the unusable chat route.
- Added a full Coding chat recovery state with a direct project-configuration action and no
Composer or Conversation/runtime creation when no usable Agent exists.
- Updated README with the accepted readiness and onboarding behavior.
## Verification
- Inspected the supplied 1493×891 Project Configuration screenshot at original detail.
- Read the project memory startup set, relevant product/domain rules, ADR-006, ADR-008,
and related concurrent task scopes after passing the ownership and planning gates.
- Inspected `src/pages/ProjectConfiguration/index.tsx`, `src/App.tsx`,
`src/components/layout/MainLayout.tsx`, `src/components/layout/Sidebar.tsx`,
`src/pages/Chat/CodingChatPanel.tsx`, `CodingConversationSidebar.tsx`,
`AgentCreationDialog.tsx`, the project configuration schema/service, Setup, README,
focused tests, and relevant Git blame/history.
- Queried the UI/UX reference for onboarding, empty-state, primary-action, keyboard, and
predictable-back guidance. Its generated dark palette was rejected because Makelore's
repository contract requires the existing single light visual system.
- No automated test was run because this task intentionally made no behavior change; a
future implementation requires focused unit coverage and the shared Electron E2E flow.
- Focused Vitest: 5 files, 63 tests passed, covering readiness, App routing, MainLayout
gating, Project Configuration onboarding/navigation, and Coding chat recovery.
- Full `pnpm test`: 230 files / 1928 tests passed with 2 skipped, followed by the isolated
pressure test passing 1/1.
- `pnpm run typecheck`: passed after the final interaction changes.
- `pnpm run lint:check`: passed with 0 errors; it retained 5 pre-existing warnings in
`src/pages/Home/index.tsx` and `src/pages/Makelore/index.tsx`.
- `pnpm run build:vite`: passed after the final interaction changes; only the repository's
existing Browserslist, dynamic-import, and chunk-size warnings were emitted.
- Electron E2E `project-configuration-skills.spec.ts`: passed 1/1, including zero-model
guidance, legacy `initialized: true` plus zero-Agent recovery, and labelled return to chat.
- Playwright trace inspection showed an initial E2E failure was caused by that spec's later
restrictive Host API stub, not product navigation; the navigation assertion now runs
before the stub and passes.
- Independent read-only review found the disabled-only recovery loop; after the targeted
correction and test, the reviewer returned PASS.
- `git diff --check`: passed.
- Task Documentation Gate remains blocked because merging current `main` introduced the
unchanged foreign task record
`.project-docs/30-worklog/tasks/20260906-agent-browser-failure-a7c91e4d.md` relative to
this task's older recorded base. The record was not modified by this task.
## Follow-ups
- If the recommended direction is accepted, implement one shared readiness predicate and
cover zero Agents, all Agents archived, no configured model, first Agent completion,
deterministic return/continue navigation, unsaved changes, and chat recovery.
- Update README only with the accepted final interaction behavior, not this discussion or
a historical worklog.
- Obtain explicit human confirmation for the project-doc recovery required to adopt the
unchanged foreign task record brought in by the already-created, unpushed `main` merge;
then rerun `check_doc_drift.py`, set this record to Ready for Integration, commit the
result, and run `task_context.py complete`.
## Promotion Candidates
- None recorded.
- Target: `.project-docs/30-worklog/current-state.md`.
Proposal: record that Coding Conversation readiness requires both persisted
initialization and at least one enabled, unarchived, fully configured project Agent;
all project-entry and chat-recovery surfaces share this invariant, and the first Agent
setup is the explicit completion path.
Evidence: shared readiness tests, Project Configuration onboarding tests, App/MainLayout
route tests, Coding chat recovery tests, Electron E2E, successful full unit suite,
typecheck, lint, production build, and independent review.
Future impact: future project-entry, archival, or Agent-edit work must reuse the shared
predicate rather than treating `initialized` as sufficient on its own.
Semantic conflicts: none known; the rule preserves the existing no-default-Agent and
project-owned Agent decisions.
Human confirmation required: no, unless integration discovers a conflicting accepted
product decision.

View File

@@ -126,7 +126,8 @@ Pi 正式包必须继续运行 `pnpm run verify:artifact:pi`、`pnpm run smoke:p
- 新项目默认没有智能体;用户在项目内创建智能体时必须填写名称、预设头像或本地头像、职责说明和精确的 Provider 账号与默认模型。该选择以 `{ accountId, modelId, thinkingLevel }` 保存,不依赖运行时私有 Provider id。本地头像会自动裁剪为 256×256并优先压缩为 WebP 后随项目配置保存;系统指令与技能属于高级设置。
- Makelore 为每个项目智能体附加平台管理的中文语言规则:自然语言默认使用简体中文,包括可见的思考过程、进度说明、工具调用说明和最终回复;代码、命令、路径、日志、错误原文与必要引用保留原始语言。用户或项目智能体系统指令明确要求其他语言时按该要求执行;模型仍不遵循时视为 Provider 模型行为。
- 项目配置页的新增与已有智能体编辑统一使用居中弹窗;编辑保存先更新当前页面草稿,点击底部“保存项目配置”后统一持久化。“可用模型”抽屉只展示已配置模型、提供方和文本/多模态能力,不提供项目级选择。智能体的默认模型只作为新对话的初始值;核心聊天页可为当前对话独立切换模型和思考强度,切换不会改写智能体默认值或其他对话
- 项目可以暂时保留为待配置状态,但只有至少一个已启用、未归档且名称、头像、默认模型、角色与职责完整的项目智能体时,项目才可进入对话;旧配置即使错误保留了 `initialized: true`,也会回到项目配置完成这一步。配置页用顶部必需步骤和主操作强引导创建智能体,无模型时直接引导到模型设置;左上角提供带文字的确定性返回操作。聊天页遇到无可用智能体时显示可恢复空态,不展示不可用的输入框
- 项目配置页的新增与已有智能体编辑统一使用居中弹窗;首个智能体创建成功后会立即持久化并进入项目对话,后续新增与编辑先更新当前页面草稿,再点击底部“保存项目配置”统一持久化。“可用模型”抽屉只展示已配置模型、提供方和文本/多模态能力,不提供项目级选择。智能体的默认模型只作为新对话的初始值;核心聊天页可为当前对话独立切换模型和思考强度,切换不会改写智能体默认值或其他对话。
- 项目智能体只保存自身的精确默认模型;未完成模型选择的智能体保持待配置状态,不从项目级 `defaultModel` 或运行时私有配置回退。
- “可用技能”入口使用模块图标;点击技能后先展示目录结构,再展示主文件 `SKILL.md` 原文,并支持返回技能列表。
- 一个智能体可以拥有多条互相独立的 Pi Session智能体和对话元数据分别由 `.makelore/project.json``.makelore/conversations.json` 保存,稳定的智能体与对话 id 保持本地历史连续。

View File

@@ -56,3 +56,22 @@ export interface CodingProjectConfigSnapshot {
config: CodingProjectConfig;
knowledgeFiles: string[];
}
export function isCodingProjectAgentReady(agent: CodingProjectAgent): boolean {
return agent.enabled
&& agent.archivedAt === null
&& agent.name.trim().length > 0
&& agent.avatarId.trim().length > 0
&& agent.roleName.trim().length > 0
&& agent.responsibility.mission.trim().length > 0
&& agent.modelResolution === 'resolved'
&& agent.model !== null;
}
export function hasReadyCodingProjectAgent(config: CodingProjectConfig): boolean {
return config.agents.some(isCodingProjectAgentReady);
}
export function isCodingProjectConversationReady(config: CodingProjectConfig): boolean {
return config.initialized && hasReadyCodingProjectAgent(config);
}

View File

@@ -26,6 +26,7 @@ import { subscribeHostEvent } from '@/lib/host-events';
import { reportDesktopActivity, type DesktopActivityModule } from '@/lib/host-api';
import { installRendererPerformanceDiagnostics } from '@/lib/performance-diagnostics';
import { resolveSupportedLanguage } from '../shared/language';
import { isCodingProjectConversationReady } from '../shared/coding-project-contracts';
import { LegacyPluginRedirect } from './pages/Plugins/legacy-plugin-redirect';
const Models = lazy(() => import('./pages/Models').then(({ Models: component }) => ({ default: component })));
@@ -229,7 +230,12 @@ function ProjectChatRoute() {
const configResult = await loadProjectConfig(project.id);
if (!cancelled) {
setResolvedProjectKey(project.id);
setResolvedRoute(configResult.status === 'valid' && Boolean(configResult.config?.initialized) ? 'chat' : 'config');
setResolvedRoute(
configResult.status === 'valid'
&& Boolean(configResult.config && isCodingProjectConversationReady(configResult.config))
? 'chat'
: 'config',
);
}
} catch {
if (!cancelled) {

View File

@@ -14,6 +14,7 @@ import { useProjectConfigStore } from '@/stores/project-config';
import { useSettingsStore } from '@/stores/settings';
import { cn } from '@/lib/utils';
import type { SidebarPeekSource } from './sidebar-peek';
import { isCodingProjectConversationReady } from '../../../shared/coding-project-contracts';
const SIDEBAR_PEEK_CLOSE_DELAY_MS = 180;
@@ -88,7 +89,11 @@ export function MainLayout() {
if (activeProject && isProgrammingModule) void load(activeProject.id).catch(() => undefined);
}, [activeProject, isProgrammingModule, load]);
const initializationBlocked = Boolean(activeProject && (!config || !config.initialized) && !isInitializationSafeRoute);
const initializationBlocked = Boolean(
activeProject
&& (!config || !isCodingProjectConversationReady(config))
&& !isInitializationSafeRoute,
);
return (
<div data-testid="main-layout" className="relative flex h-[100dvh] flex-col overflow-hidden bg-transparent font-sans">
{/* Title bar: drag region on macOS, icon + controls on Windows */}
@@ -121,8 +126,8 @@ export function MainLayout() {
<div data-testid="project-initialization-gate" className="glass-surface absolute inset-0 z-[100] flex items-center justify-center bg-background/90 p-6">
<div className="surface-card max-w-md rounded-2xl border border-border/80 bg-background p-8 text-center shadow-float">
<LockKeyhole className="mx-auto h-10 w-10" />
<h1 className="mt-4 text-2xl font-semibold"></h1>
<p className="mt-3 text-sm font-medium text-muted-foreground"> Agent </p>
<h1 className="mt-4 text-2xl font-semibold"></h1>
<p className="mt-3 text-pretty text-sm font-medium leading-6 text-muted-foreground"></p>
<Button onClick={() => navigate('/project-config')} className="mt-6 border border-brand/20 bg-brand font-semibold text-primary-foreground"><Settings2 className="mr-2 h-4 w-4" /></Button>
</div>
</div>

View File

@@ -53,7 +53,10 @@ import { isCanonicalCodingProjectId } from '@/lib/coding-projects';
import type { CodingProjectSummary } from '@/types/coding-project';
import { useProjectConfigStore } from '@/stores/project-config';
import type { ProjectType } from '../../../shared/project-config';
import type { ProjectIdentityChoice } from '../../../shared/coding-project-contracts';
import {
isCodingProjectConversationReady,
type ProjectIdentityChoice,
} from '../../../shared/coding-project-contracts';
import { toast } from 'sonner';
type OpenDialogResult = {
@@ -438,7 +441,7 @@ export function Sidebar({ workspaceLayout = false, sidebarPeekOpen = false, onSi
return;
}
await setActiveProject(project.id);
navigate(result.config.initialized
navigate(isCodingProjectConversationReady(result.config)
? '/chat'
: projectConfigPath);
};

View File

@@ -41,7 +41,12 @@ import { CodingConversationSidebar } from './CodingConversationSidebar';
import { CodingConversationHeader } from './CodingConversationHeader';
import { CodingConversationTimeline } from './CodingConversationTimeline';
import { CodingInteractionPanel } from './CodingInteractionPanel';
import { CodingProjectSetupEmptyState } from './CodingProjectSetupEmptyState';
import { createLocalConversationSnapshot } from './coding-chat-snapshot';
import {
isCodingProjectAgentReady,
isCodingProjectConversationReady,
} from '../../../shared/coding-project-contracts';
export interface CodingChatPanelProps {
navigationDraft?: string;
@@ -158,8 +163,9 @@ export function CodingChatPanel({
const submissionFlightsRef = useRef(new Set<string>());
const agents = useMemo(() => (
config?.agents.filter((agent) => agent.enabled && !agent.archivedAt) ?? []
config?.agents.filter(isCodingProjectAgentReady) ?? []
), [config]);
const conversationReady = Boolean(config && isCodingProjectConversationReady(config));
const selectedAgent = agents.find((agent) => agent.id === selectedAgentId) ?? null;
const selectedConversation = conversations.find((conversation) => (
conversation.id === selectedConversationId
@@ -615,6 +621,10 @@ export function CodingChatPanel({
);
}
if (activeProject && config && !conversationReady && workspaceLoadState !== 'loading') {
return <CodingProjectSetupEmptyState onOpenProjectSettings={onOpenProjectSettings} />;
}
return (
<section className="flex min-h-0 flex-1 overflow-hidden bg-background text-foreground" data-testid="coding-chat-panel">
<CodingConversationSidebar

View File

@@ -0,0 +1,33 @@
import { Bot, Settings2 } from 'lucide-react';
import { Button } from '@/components/ui/button';
export function CodingProjectSetupEmptyState({
onOpenProjectSettings,
}: {
onOpenProjectSettings?(): void;
}) {
return (
<section
className="flex min-h-0 flex-1 items-center justify-center bg-background p-6"
data-testid="coding-chat-agent-setup-empty-state"
>
<div className="surface-card max-w-md rounded-2xl bg-background p-8 text-center shadow-float">
<div className="mx-auto flex h-12 w-12 items-center justify-center rounded-2xl bg-brand-soft text-brand shadow-[0_0_0_1px_rgba(0,0,0,0.06)]">
<Bot className="h-5 w-5" aria-hidden="true" />
</div>
<h1 className="mt-4 text-balance text-xl font-semibold"></h1>
<p className="mt-2 text-pretty text-sm leading-6 text-muted-foreground">
</p>
<Button
type="button"
className="mt-5 min-h-10 rounded-xl px-4 transition-transform duration-150 ease-out active:scale-[0.96]"
onClick={onOpenProjectSettings}
>
<Settings2 className="mr-2 h-4 w-4" aria-hidden="true" />
</Button>
</div>
</section>
);
}

View File

@@ -1,6 +1,6 @@
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';
import { useLocation, useNavigate } from 'react-router-dom';
import { ArrowLeft, Blocks, Check, Cpu, FileText, Files, FolderOpen, Plus, Trash2, Upload, X } from 'lucide-react';
import { ArrowLeft, Blocks, Bot, Check, Cpu, FileText, Files, FolderOpen, Plus, Trash2, Upload, X } from 'lucide-react';
import { toast } from 'sonner';
import { Badge } from '@/components/ui/badge';
import { Button } from '@/components/ui/button';
@@ -20,10 +20,16 @@ import { useCodingWorkspaceStore } from '@/stores/coding-workspace';
import { useProjectConfigStore } from '@/stores/project-config';
import { useProviderStore } from '@/stores/providers';
import type { CodingProjectAgent, CodingProjectConfig } from '@/types/coding-project';
import type { ProjectIdentityChoice } from '../../../shared/coding-project-contracts';
import {
hasReadyCodingProjectAgent,
isCodingProjectAgentReady,
isCodingProjectConversationReady,
type ProjectIdentityChoice,
} from '../../../shared/coding-project-contracts';
const EMPTY_FILES: string[] = [];
type DrawerMode = 'models' | 'knowledge' | 'skills' | null;
type ExitDestination = '/chat' | '/module-select' | '/models';
type ProjectIdentityKind = ProjectIdentityChoice['kind'];
type SkillStructureEntry = { path: string; type: 'file' | 'directory' };
type SkillInfo = {
@@ -93,7 +99,8 @@ function SkillDetail({ skill }: { skill: SkillInfo }) {
}
function AgentCard({ agent, onOpen }: { agent: CodingProjectAgent; onOpen: () => void }) {
return <button type="button" data-testid={`project-agent-${agent.id}`} onClick={onOpen} className="config-motion-agent surface-card motion-press h-[260px] w-[210px] flex-none rounded-2xl border border-border/70 bg-background p-4 text-left shadow-none hover:shadow-soft"><img src={getAgentAvatarSrc(agent.avatarId, agent.avatarDataUrl)} alt="" className="agent-motion-avatar mx-auto h-20 w-20 rounded-xl border border-border object-cover [image-rendering:pixelated]" /><div className="mt-4 flex items-center justify-between gap-2"><p className="truncate font-semibold">{agent.name || '未命名'}</p><Badge className="shrink-0 border border-brand/15 bg-brand-soft text-brand"></Badge></div><p className="mt-1 truncate text-xs font-semibold text-muted-foreground">{agent.roleName}</p><p className="mt-3 line-clamp-3 min-h-12 text-xs text-muted-foreground">{agent.responsibility.mission}</p><p className="mt-2 text-[11px] text-muted-foreground">{agent.skillIds.length} </p></button>;
const ready = isCodingProjectAgentReady(agent);
return <button type="button" data-testid={`project-agent-${agent.id}`} onClick={onOpen} className="config-motion-agent surface-card motion-press h-[260px] w-[210px] flex-none rounded-2xl border border-border/70 bg-background p-4 text-left shadow-none hover:shadow-soft"><img src={getAgentAvatarSrc(agent.avatarId, agent.avatarDataUrl)} alt="" className="agent-motion-avatar mx-auto h-20 w-20 rounded-xl border border-border object-cover [image-rendering:pixelated]" /><div className="mt-4 flex items-center justify-between gap-2"><p className="truncate font-semibold">{agent.name || '未命名'}</p><Badge className={cn('shrink-0 border', ready ? 'border-brand/15 bg-brand-soft text-brand' : 'border-border/80 bg-surface-subtle text-muted-foreground')}>{ready ? '可用' : '待完成'}</Badge></div><p className="mt-1 truncate text-xs font-semibold text-muted-foreground">{agent.roleName}</p><p className="mt-3 line-clamp-3 min-h-12 text-xs text-muted-foreground">{agent.responsibility.mission}</p><p className="mt-2 text-[11px] text-muted-foreground">{agent.skillIds.length} </p></button>;
}
function ModelCard({ model }: { model: CodingModelOption }) {
@@ -111,10 +118,20 @@ function ModelCard({ model }: { model: CodingModelOption }) {
</div>;
}
function ModelList({ models }: { models: CodingModelOption[] }) {
function ModelList({
models,
onOpenModelSettings,
}: {
models: CodingModelOption[];
onOpenModelSettings: () => void;
}) {
if (models.length === 0) {
return <div data-testid="project-model-empty-state" className="rounded-xl border border-dashed border-foreground/15 bg-white p-4 text-sm font-medium text-muted-foreground">
当前没有可用模型,请先在模型设置中完成配置。智能体的默认模型在智能体配置中设置。
<p className="text-pretty leading-6">当前没有可用模型。先完成模型配置,再从左侧项目入口回到这里创建智能体。</p>
<Button type="button" className="mt-4 min-h-10 rounded-xl px-4 transition-transform duration-150 ease-out active:scale-[0.96]" onClick={onOpenModelSettings}>
<Cpu className="mr-2 h-4 w-4" aria-hidden="true" />
前往模型设置
</Button>
</div>;
}
return <div data-testid="project-model-list" className="space-y-3">
@@ -153,6 +170,7 @@ export function ProjectConfiguration() {
const [identityError, setIdentityError] = useState<string | null>(null);
const [independentCopyDialogOpen, setIndependentCopyDialogOpen] = useState(false);
const [deleteDialogOpen, setDeleteDialogOpen] = useState(false);
const [pendingExitDestination, setPendingExitDestination] = useState<ExitDestination | null>(null);
const [partnerDialogOpen, setPartnerDialogOpen] = useState(false);
const [archiveAgentId, setArchiveAgentId] = useState<string | null>(null);
const knowledgeInputRef = useRef<HTMLInputElement | null>(null);
@@ -197,11 +215,47 @@ export function ProjectConfiguration() {
const activeAgent = draft?.agents.find((agent) => agent.id === activeAgentId) ?? null;
const activeSkill = skills.find((skill) => skill.id === activeSkillId) ?? null;
const playSaveConfirmation = () => undefined;
const handleBack = () => navigate(-1);
if (!activeProject) return <main data-testid="project-configuration-empty-state" className="flex min-h-full items-start bg-background p-8 text-foreground"><p className="pt-4 text-xl font-semibold tracking-[-0.02em]">一念成光,万物可创。</p></main>;
if (!draft) return <div className="p-8 text-center text-sm font-medium">正在读取项目配置…</div>;
const draftHasReadyAgent = hasReadyCodingProjectAgent(draft);
const storedConversationReady = Boolean(stored && isCodingProjectConversationReady(stored));
const hasUnsavedChanges = Boolean(stored && JSON.stringify(stored) !== JSON.stringify(draft));
const backDestination: ExitDestination = storedConversationReady ? '/chat' : '/module-select';
const backLabel = storedConversationReady ? '返回对话' : '稍后设置';
const pendingAgent = draft.agents.find((agent) => (
agent.enabled && !agent.archivedAt && !isCodingProjectAgentReady(agent)
));
const setupActionLabel = modelOptions.length === 0
? '先配置模型'
: pendingAgent
? '完成智能体配置'
: '创建项目智能体';
const archiveAgent = draft.agents.find((agent) => agent.id === archiveAgentId);
const archiveRemovesLastReadyAgent = Boolean(
archiveAgent
&& isCodingProjectAgentReady(archiveAgent)
&& !draft.agents.some((agent) => agent.id !== archiveAgentId && isCodingProjectAgentReady(agent)),
);
const requestNavigation = (destination: ExitDestination) => {
if (hasUnsavedChanges) {
setPendingExitDestination(destination);
return;
}
navigate(destination);
};
const handleBack = () => requestNavigation(backDestination);
const openModelSettings = () => requestNavigation('/models');
const openAgentCreation = () => {
if (modelOptions.length === 0) {
openModelSettings();
return;
}
setActiveAgentId(pendingAgent?.id ?? null);
setPartnerDialogOpen(true);
};
const updateAgent = (next: CodingProjectAgent) => setDraft((current) => current ? { ...current, agents: current.agents.map((item) => item.id === next.id ? { ...next, updatedAt: new Date().toISOString() } : item) } : current);
const handlePartnerDialogOpenChange = (open: boolean) => {
setPartnerDialogOpen(open);
@@ -221,7 +275,22 @@ export function ProjectConfiguration() {
skillIds: input.skillIds,
responsibility: { mission: input.responsibility, owns: [], boundaries: [], collaborators: [], principles: [] },
};
setDraft((current) => current ? { ...current, agents: [...current.agents, agent] } : current);
const nextDraft = { ...draft, agents: [...draft.agents, agent] };
if (!draftHasReadyAgent) {
setSaving(true);
try {
const saved = await save(activeProject.id, { ...nextDraft, initialized: true });
setDraft(structuredClone(saved));
await reloadWorkspace();
playSaveConfirmation();
toast.success('项目智能体已创建');
navigate('/chat');
} finally {
setSaving(false);
}
return;
}
setDraft(nextDraft);
};
const handleUpdatePartner = async (input: AgentCreationInput) => {
if (!activeAgentId) return;
@@ -258,12 +327,26 @@ export function ProjectConfiguration() {
toast.error('请补全智能体名称、头像、默认模型和职责说明;名称需在当前项目内唯一。');
return;
}
const conversationReady = hasReadyCodingProjectAgent(draft);
if (!conversationReady && !storedConversationReady) {
openAgentCreation();
return;
}
setSaving(true);
try {
await save(activeProject.id, { ...draft, initialized: true });
const saved = await save(activeProject.id, { ...draft, initialized: conversationReady });
setDraft(structuredClone(saved));
await reloadWorkspace();
playSaveConfirmation();
toast.success(draft.initialized ? '项目配置已更新' : '项目初始化完成');
if (!conversationReady) {
toast.success('项目已保存,创建智能体后即可开始对话');
navigate('/module-select');
} else if (!storedConversationReady) {
toast.success('项目初始化完成');
navigate('/chat');
} else {
toast.success('项目配置已更新');
}
} catch (error) {
toast.error(error instanceof Error ? error.message : String(error));
} finally {
@@ -336,11 +419,36 @@ export function ProjectConfiguration() {
return <main className="-m-5 flex min-h-[calc(100%+2.5rem)] min-h-0 flex-col overflow-auto bg-background p-4 text-foreground sm:-m-6 sm:min-h-[calc(100%+3rem)]" data-testid="project-configuration-page">
<div className="mx-auto flex min-h-0 w-full max-w-7xl flex-1 flex-col gap-3">
<div className="config-motion-title flex items-center gap-2">
<Button type="button" variant="ghost" size="icon" data-testid="project-configuration-back-button" aria-label="返回" title="返回" onClick={handleBack} className="h-8 w-8 shrink-0 text-muted-foreground hover:bg-surface-subtle hover:text-foreground">
<Button type="button" variant="ghost" data-testid="project-configuration-back-button" aria-label={backLabel} title={backLabel} onClick={handleBack} className="min-h-10 shrink-0 rounded-xl px-3 text-muted-foreground transition-transform duration-150 ease-out hover:bg-surface-subtle hover:text-foreground active:scale-[0.96]">
<ArrowLeft className="h-4 w-4" />
<span className="ml-2 font-semibold">{backLabel}</span>
</Button>
<h1 className="text-xl font-semibold">项目配置</h1>
</div>
{!draftHasReadyAgent ? (
<section data-testid="project-agent-setup-callout" className="surface-card flex flex-col gap-4 rounded-2xl bg-brand-soft/60 p-5 shadow-[0_0_0_1px_rgba(0,0,0,0.06)] sm:flex-row sm:items-center sm:justify-between">
<div className="flex min-w-0 items-start gap-3">
<span className="flex h-10 w-10 shrink-0 items-center justify-center rounded-xl bg-background text-brand shadow-[0_0_0_1px_rgba(0,0,0,0.06)]" aria-hidden="true">
<Bot className="h-5 w-5" />
</span>
<div className="min-w-0">
<div className="flex flex-wrap items-center gap-2">
<h2 className="text-balance text-lg font-semibold">{draft.agents.length === 0 ? '项目已创建,还差 1 步' : '项目需要一个可用智能体'}</h2>
<Badge className="border border-brand/20 bg-background text-brand">必需</Badge>
</div>
<p className="mt-1 text-pretty text-sm font-medium leading-6 text-muted-foreground">
{modelOptions.length === 0
? '先配置一个可用模型,再创建项目智能体即可开始对话。'
: '创建一个项目智能体并完成名称、默认模型和职责设置,即可开始对话。'}
</p>
</div>
</div>
<Button type="button" data-testid="project-agent-setup-primary" className="min-h-10 shrink-0 rounded-xl px-4 transition-transform duration-150 ease-out active:scale-[0.96]" onClick={openAgentCreation}>
{modelOptions.length === 0 ? <Cpu className="mr-2 h-4 w-4" aria-hidden="true" /> : <Plus className="mr-2 h-4 w-4" aria-hidden="true" />}
{setupActionLabel}
</Button>
</section>
) : null}
<section data-testid="project-identity-card" className="surface-card rounded-2xl border border-border/70 bg-background p-5 shadow-soft">
{draft.projectId ? (
<div className="flex flex-col gap-3 sm:flex-row sm:items-start sm:justify-between">
@@ -456,7 +564,31 @@ export function ProjectConfiguration() {
)}
</section>
<section className="grid gap-3 md:grid-cols-3"><ResourceCard id="models" icon={<Cpu />} title="可用模型" subtitle={`${modelOptions.length} `} onClick={() => setDrawerMode('models')} /><ResourceCard id="skills" icon={<Blocks />} title="可用技能" subtitle={`${skills.length} `} onClick={() => { setActiveSkillId(null); setDrawerMode('skills'); }} /><ResourceCard id="knowledge" icon={<Files />} title="知识文件" subtitle={`${knowledge.length} `} onClick={() => setDrawerMode('knowledge')} /></section>
<section className="config-motion-partners surface-card rounded-2xl border border-border/70 bg-background p-5 shadow-soft"><div className="mb-4 flex items-center justify-between gap-3"><div><h2 className="text-xl font-semibold">项目智能体</h2><p className="mt-1 text-sm font-medium text-muted-foreground">智能体配置仅属于当前项目;每个智能体可以拥有多条独立对话。</p></div><Button type="button" size="icon" className="h-8 w-8 rounded-full border border-brand/20 bg-brand-soft text-brand" aria-label="创建智能体" title="创建智能体" onClick={() => { if (modelOptions.length === 0) { toast.error('请先在模型设置中配置至少一个可用模型。'); setDrawerMode('models'); return; } setActiveAgentId(null); setPartnerDialogOpen(true); }}><Plus className="h-4 w-4" /></Button></div><div data-testid="agent-cards-scroll-region" className="-m-2 flex gap-4 overflow-auto p-2">{draft.agents.filter((agent) => !agent.archivedAt).map((agent) => <AgentCard key={agent.id} agent={agent} onOpen={() => { setActiveAgentId(agent.id); setPartnerDialogOpen(true); }} />)}{draft.agents.every((agent) => agent.archivedAt) ? <div className="w-full rounded-xl border border-dashed border-foreground/15 p-6 text-center text-sm font-medium text-muted-foreground">当前项目还没有智能体,点击右上角的 + 创建。</div> : null}</div>{draft.agents.some((agent) => agent.archivedAt) ? <div className="mt-4 border-t border-border/70 pt-4"><p className="text-xs font-semibold uppercase tracking-[0.14em] text-muted-foreground">已归档</p><div className="mt-2 flex flex-wrap gap-2">{draft.agents.filter((agent) => agent.archivedAt).map((agent) => <Button key={agent.id} type="button" variant="outline" className="border-border/70 bg-surface-subtle" onClick={() => updateAgent({ ...agent, archivedAt: null })}>{agent.name || '未命名智能体'} · 恢复</Button>)}</div></div> : null}</section>
<section className="config-motion-partners surface-card rounded-2xl border border-border/70 bg-background p-5 shadow-soft">
<div className="mb-4 flex items-center justify-between gap-3">
<div>
<div className="flex flex-wrap items-center gap-2">
<h2 className="text-xl font-semibold">项目智能体</h2>
{!draftHasReadyAgent ? <Badge className="border border-brand/20 bg-brand-soft text-brand">必需</Badge> : null}
</div>
<p className="mt-1 text-pretty text-sm font-medium text-muted-foreground">智能体配置仅属于当前项目;每个智能体可以拥有多条独立对话。</p>
</div>
{draftHasReadyAgent ? (
<Button type="button" size="icon" className="h-10 w-10 rounded-xl border border-brand/20 bg-brand-soft text-brand transition-transform duration-150 ease-out active:scale-[0.96]" aria-label="创建智能体" title="创建智能体" onClick={openAgentCreation}>
<Plus className="h-4 w-4" />
</Button>
) : null}
</div>
<div data-testid="agent-cards-scroll-region" className="-m-2 flex gap-4 overflow-auto p-2">
{draft.agents.filter((agent) => !agent.archivedAt).map((agent) => <AgentCard key={agent.id} agent={agent} onOpen={() => { setActiveAgentId(agent.id); setPartnerDialogOpen(true); }} />)}
{draft.agents.every((agent) => agent.archivedAt) ? (
<div className="w-full rounded-xl border border-dashed border-foreground/15 p-6 text-center text-sm font-medium text-muted-foreground">
创建或恢复一个项目智能体后,才能进入项目对话。
</div>
) : null}
</div>
{draft.agents.some((agent) => agent.archivedAt) ? <div className="mt-4 border-t border-border/70 pt-4"><p className="text-xs font-semibold uppercase tracking-[0.14em] text-muted-foreground">已归档</p><div className="mt-2 flex flex-wrap gap-2">{draft.agents.filter((agent) => agent.archivedAt).map((agent) => <Button key={agent.id} type="button" variant="outline" className="min-h-10 border-border/70 bg-surface-subtle" onClick={() => updateAgent({ ...agent, archivedAt: null })}>{agent.name || '未命名智能体'} · 恢复</Button>)}</div></div> : null}
</section>
<div data-testid="project-configuration-actions" className="glass-surface config-motion-actions sticky bottom-3 z-10 mt-auto flex shrink-0 flex-col gap-2 rounded-2xl border border-border/70 bg-background/85 p-2 shadow-float sm:flex-row sm:items-start sm:justify-between">
<Button type="button" variant="outline" size="sm" onClick={() => setDeleteDialogOpen(true)} className="h-9 w-full border-brand/25 bg-background px-3 font-semibold text-foreground shadow-none hover:border-brand/40 hover:bg-brand-soft sm:w-auto"><Trash2 className="mr-2 h-4 w-4" />删除项目</Button>
<div data-testid="project-configuration-primary-actions" className="flex w-full flex-col gap-2 sm:ml-auto sm:w-auto sm:flex-row sm:items-start sm:justify-end">
@@ -469,7 +601,23 @@ export function ProjectConfiguration() {
buttonSize="sm"
/>
) : null}
<Button onClick={() => void submit()} disabled={saving} className="project-save-button h-10 w-full border border-brand/20 bg-brand px-4 font-semibold text-primary-foreground sm:w-auto"><Check className="mr-2 h-4 w-4" />{saving ? '保存中…' : draft.initialized ? '保存项目配置' : '确认并完成初始化'}</Button>
{!draftHasReadyAgent && !storedConversationReady ? (
<Button type="button" onClick={openAgentCreation} disabled={saving} className="project-save-button h-10 w-full border border-brand/20 bg-brand px-4 font-semibold text-primary-foreground transition-transform duration-150 ease-out active:scale-[0.96] sm:w-auto">
{modelOptions.length === 0 ? <Cpu className="mr-2 h-4 w-4" /> : <Plus className="mr-2 h-4 w-4" />}
{setupActionLabel}
</Button>
) : (
<Button onClick={() => void submit()} disabled={saving} className="project-save-button h-10 w-full border border-brand/20 bg-brand px-4 font-semibold text-primary-foreground transition-transform duration-150 ease-out active:scale-[0.96] sm:w-auto">
<Check className="mr-2 h-4 w-4" />
{saving
? '保存中…'
: !draftHasReadyAgent
? '保存并稍后设置'
: storedConversationReady
? '保存项目配置'
: '保存并进入对话'}
</Button>
)}
</div>
</div>
</div>
@@ -484,24 +632,39 @@ export function ProjectConfiguration() {
onUpdate={handleUpdatePartner}
onArchive={activeAgent && !activeAgent.builtIn ? () => setArchiveAgentId(activeAgent.id) : undefined}
title={activeAgent ? `${activeAgent.name || '未命名智能体'} · ` : '创建项目智能体'}
submitLabel={activeAgent ? '保存智能体' : '创建智能体'}
submitLabel={activeAgent ? '保存智能体' : draftHasReadyAgent ? '创建智能体' : '创建并进入对话'}
/>
<Sheet open={drawerMode !== null} onOpenChange={(open) => { if (!open) { setDrawerMode(null); setActiveSkillId(null); } }}><SheetContent className="glass-surface flex w-[min(430px,94vw)] flex-col overflow-hidden border-l border-border/70 bg-background/90 p-0 text-foreground sm:max-w-none">
{drawerMode === 'models' ? <DrawerFrame title="可用模型" desc="查看已配置的模型;智能体默认模型在智能体配置中设置。" onClose={() => setDrawerMode(null)}><ModelList models={modelOptions} /></DrawerFrame> : null}
{drawerMode === 'models' ? <DrawerFrame title="可用模型" desc="查看已配置的模型;智能体默认模型在智能体配置中设置。" onClose={() => setDrawerMode(null)}><ModelList models={modelOptions} onOpenModelSettings={openModelSettings} /></DrawerFrame> : null}
{drawerMode === 'knowledge' ? <DrawerFrame title="知识文件" desc="文件保存在当前项目的 knowledge/ 目录中。" onClose={() => setDrawerMode(null)}><input ref={knowledgeInputRef} type="file" className="sr-only" onChange={(event) => { void handleKnowledge(event.target.files?.[0]); event.currentTarget.value = ''; }} /><Button className="w-full border border-foreground/15 bg-brand-soft text-foreground" onClick={() => knowledgeInputRef.current?.click()}><Upload className="mr-2 h-4 w-4" />上传知识文件</Button><div className="mt-5 space-y-3">{knowledge.length ? knowledge.map((file) => <div key={file} className="rounded-lg border border-foreground/15 bg-white p-3 font-semibold">{file}</div>) : <div className="rounded-lg border border-dashed border-foreground/15 bg-white p-4 text-sm font-medium">当前还没有知识文件。</div>}</div></DrawerFrame> : null}
{drawerMode === 'skills' && activeSkill ? <DrawerFrame title={`${activeSkill.name} · `} desc="查看技能目录结构和主文件 SKILL.md。" onClose={() => setActiveSkillId(null)} closeLabel="返回技能列表" closeIcon="back"><SkillDetail skill={activeSkill} /></DrawerFrame> : null}
{drawerMode === 'skills' && !activeSkill ? <DrawerFrame title="可用技能" desc="查看技能目录与主文件;在智能体配置中启用所需技能。" onClose={() => setDrawerMode(null)}><div className="space-y-3">{skills.length > 0 ? skills.map((skill) => <button key={skill.id} type="button" data-testid={`skill-card-${skill.id}`} aria-label={`${skill.name}`} onClick={() => setActiveSkillId(skill.id)} className="w-full rounded-lg border border-foreground/15 bg-white p-3 text-left transition hover:border-brand/40 hover:bg-brand-soft/30"><div className="flex items-start gap-3"><Blocks className="mt-0.5 h-4 w-4 shrink-0 text-brand" /><span className="min-w-0 flex-1"><span className="block font-semibold">{skill.name}</span><span className="mt-1 block text-sm text-muted-foreground">{skill.description}</span><span className="mt-2 block text-[11px] font-medium text-brand">查看目录与 SKILL.md</span></span><ArrowLeft className="mt-0.5 h-4 w-4 shrink-0 rotate-180 text-muted-foreground" aria-hidden="true" /></div></button>) : <div className="rounded-lg border border-dashed border-foreground/15 bg-white p-4 text-sm font-medium text-muted-foreground">当前没有可查看的技能。</div>}</div></DrawerFrame> : null}
</SheetContent></Sheet>
<ConfirmDialog
open={Boolean(archiveAgentId)}
title={`${draft.agents.find((agent) => agent.id === archiveAgentId)?.name || '未命名智能体'}`}
message="归档后将停止提供新的使用入口,但会保留智能体配置和全部对话记录;你可以之后在智能体列表底部恢复。"
title={`${archiveAgent?.name || '未命名智能体'}`}
message={archiveRemovesLastReadyAgent
? '这是当前最后一个可用智能体。归档并保存后,项目将进入待配置状态,无法开始新对话;智能体配置和全部对话记录仍会保留。'
: '归档后将停止提供新的使用入口,但会保留智能体配置和全部对话记录;你可以之后在智能体列表底部恢复。'}
confirmLabel="确认归档"
cancelLabel="取消"
onCancel={() => setArchiveAgentId(null)}
onConfirm={handleArchiveAgent}
onError={(error) => toast.error(error instanceof Error ? error.message : String(error))}
/>
<ConfirmDialog
open={pendingExitDestination !== null}
title="放弃未保存的项目配置?"
message="离开后,本页尚未保存的智能体新增、编辑或归档操作会丢失。"
confirmLabel={pendingExitDestination === '/models' ? '前往模型设置' : backLabel}
cancelLabel="继续编辑"
onCancel={() => setPendingExitDestination(null)}
onConfirm={() => {
const destination = pendingExitDestination;
setPendingExitDestination(null);
if (destination) navigate(destination);
}}
/>
<ConfirmDialog
open={deleteDialogOpen}
title={`${activeProject.name}`}

View File

@@ -35,7 +35,11 @@ test.describe('Project configuration skills', () => {
await expect(page.getByTestId('project-configuration-actions')).toBeVisible();
const actionBarBottomGap = await page.getByTestId('project-configuration-actions').evaluate((element) => window.innerHeight - element.getBoundingClientRect().bottom);
expect(actionBarBottomGap).toBeLessThan(40);
await expect(page.getByRole('button', { name: '创建智能体' })).toBeVisible();
const setupCallout = page.getByTestId('project-agent-setup-callout');
await expect(setupCallout).toContainText('项目已创建,还差 1 步');
await expect(setupCallout).toContainText('必需');
await expect(page.getByTestId('project-agent-setup-primary')).toHaveText('先配置模型');
await expect(page.getByTestId('project-configuration-back-button')).toHaveAccessibleName('稍后设置');
for (const [resourceId, title] of [
['resource-card-models', '可用模型'],
@@ -48,6 +52,7 @@ test.describe('Project configuration skills', () => {
if (resourceId === 'resource-card-models') {
await expect(drawer.getByRole('combobox')).toHaveCount(0);
await expect(drawer.locator('[data-testid="project-model-list"], [data-testid="project-model-empty-state"]')).toHaveCount(1);
await expect(drawer.getByRole('button', { name: '前往模型设置' })).toBeVisible();
}
const closeButton = drawer.getByRole('button', { name: '关闭' });
const closeGeometry = await closeButton.evaluate((button) => {
@@ -73,6 +78,15 @@ test.describe('Project configuration skills', () => {
const now = new Date().toISOString();
await mkdir(path.join(parentPath, '.makelore'), { recursive: true });
await writeFile(path.join(parentPath, '.makelore', 'project.json'), JSON.stringify({
...createCodingProjectConfigV2(now, 'interactive_ai_app'),
initialized: true,
agents: [],
}, null, 2));
await page.evaluate(() => { window.location.hash = '#/chat'; });
await expect(page.getByTestId('project-configuration-page')).toBeVisible();
await expect(page.getByTestId('project-agent-setup-callout')).toBeVisible();
await writeFile(path.join(parentPath, '.makelore', 'project.json'), JSON.stringify({
...createCodingProjectConfigV2(now, 'interactive_ai_app'),
initialized: true,
@@ -96,6 +110,11 @@ test.describe('Project configuration skills', () => {
}, null, 2));
await page.reload();
await expect(page.getByTestId('project-configuration-page')).toBeVisible();
await expect(page.getByTestId('project-configuration-back-button')).toHaveAccessibleName('返回对话');
await page.getByTestId('project-configuration-back-button').click();
await expect(page.getByTestId('chat-operation-page')).toBeVisible();
await page.evaluate(() => { window.location.hash = '#/project-config'; });
await expect(page.getByTestId('project-configuration-page')).toBeVisible();
await page.getByTestId('resource-card-skills').click();
await expect(page.getByTestId('superpowers-card')).toHaveCount(0);
@@ -163,6 +182,7 @@ test.describe('Project configuration skills', () => {
await expect(avatarDialog).toHaveCount(0);
await expect(maintenanceDialog.getByAltText('当前上传头像')).toBeVisible();
await expect(page.getByText('完成配置')).toHaveCount(0);
await maintenanceDialog.getByRole('button', { name: '取消' }).click();
} finally {
await closeElectronApp(app);
await rm(parentPath, { recursive: true, force: true });

View File

@@ -6,6 +6,10 @@ import { useAuthStore } from '@/stores/auth';
import { useProviderStore } from '@/stores/providers';
import { useSettingsStore } from '@/stores/settings';
import { useUserSyncStore } from '@/stores/user-sync';
import { codingWorkspaceStore } from '@/stores/coding-workspace';
import { useProjectConfigStore } from '@/stores/project-config';
import { createCodingProjectConfigV2 } from '@electron/coding-projects/project-config';
import type { CodingProjectAgent } from '@/types/coding-project';
vi.mock('@/components/layout/MainLayout', () => ({
MainLayout: () => (
@@ -39,11 +43,41 @@ vi.mock('@/pages/Settings', () => ({
Settings: () => <div>Global settings</div>,
}));
vi.mock('@/pages/ProjectConfiguration', () => ({
ProjectConfiguration: () => <div>Project configuration</div>,
}));
const readyAgent: CodingProjectAgent = {
id: 'agent-1',
avatarId: 'avatar-01',
roleName: '项目智能体',
name: 'Builder',
builtIn: false,
enabled: true,
model: { accountId: 'account-1', modelId: 'model-1', thinkingLevel: 'off' },
modelResolution: 'resolved',
skillIds: [],
responsibility: {
mission: '完成项目工作',
owns: [],
boundaries: [],
collaborators: [],
principles: [],
},
prompt: '',
archivedAt: null,
pinned: false,
createdAt: '2026-09-06T00:00:00.000Z',
updatedAt: '2026-09-06T00:00:00.000Z',
};
describe('App programming provider initialization gate', () => {
const initProviders = vi.fn();
beforeEach(() => {
vi.clearAllMocks();
codingWorkspaceStore.setState(codingWorkspaceStore.getInitialState(), true);
useProjectConfigStore.setState(useProjectConfigStore.getInitialState(), true);
useSettingsStore.setState({
setupComplete: true,
init: vi.fn(),
@@ -95,6 +129,56 @@ describe('App programming provider initialization gate', () => {
await waitFor(() => expect(initProviders).toHaveBeenCalledTimes(1));
});
it('redirects a legacy initialized project without a usable Agent to configuration', async () => {
const project = {
id: 'local-project',
path: '/tmp/local-project',
name: 'local-project',
createdAt: '',
updatedAt: '',
lastOpenedAt: '',
};
const config = { ...createCodingProjectConfigV2(), initialized: true, agents: [] };
codingWorkspaceStore.setState({
activeProjectId: project.id,
activeProject: project,
load: vi.fn().mockResolvedValue(undefined),
});
useProjectConfigStore.setState({
load: vi.fn().mockResolvedValue({ status: 'valid', config, knowledgeFiles: [] }),
});
await renderAt('/chat');
expect(await screen.findByText('Project configuration')).toBeInTheDocument();
expect(screen.queryByText('Programming workspace')).not.toBeInTheDocument();
});
it('opens chat when the project has a fully configured Agent', async () => {
const project = {
id: 'local-project',
path: '/tmp/local-project',
name: 'local-project',
createdAt: '',
updatedAt: '',
lastOpenedAt: '',
};
const config = { ...createCodingProjectConfigV2(), initialized: true, agents: [readyAgent] };
codingWorkspaceStore.setState({
activeProjectId: project.id,
activeProject: project,
load: vi.fn().mockResolvedValue(undefined),
});
useProjectConfigStore.setState({
load: vi.fn().mockResolvedValue({ status: 'valid', config, knowledgeFiles: [] }),
});
await renderAt('/chat');
expect(await screen.findByText('Programming workspace')).toBeInTheDocument();
expect(screen.queryByText('Project configuration')).not.toBeInTheDocument();
});
it('redirects an orphaned token without a user identity away from a direct workspace route', async () => {
useAuthStore.setState({
initialized: true,

View File

@@ -80,8 +80,8 @@ const agent: CodingProjectAgent = {
pinned: true,
createdAt: '2026-08-23T00:00:00.000Z',
updatedAt: '2026-08-23T00:00:00.000Z',
model: null,
modelResolution: 'required',
model: { accountId: 'account-1', modelId: 'model-1', thinkingLevel: 'off' },
modelResolution: 'resolved',
};
const config: CodingProjectConfig = {
schemaVersion: 2,
@@ -199,6 +199,24 @@ describe('CodingChatPanel first Conversation', () => {
vi.resetModules();
});
it('shows an actionable setup state when the active project has no usable Agent', async () => {
projectApi.list.mockResolvedValue({ projects: [project], activeProjectId: project.id });
projectApi.config.mockResolvedValue({ project, config: configForAgents([]) });
projectApi.conversations.mockResolvedValue([]);
const onOpenProjectSettings = vi.fn();
const { CodingChatPanel } = await import('@/pages/Chat/CodingChatPanel');
render(<CodingChatPanel onOpenProjectSettings={onOpenProjectSettings} />);
expect(await screen.findByTestId('coding-chat-agent-setup-empty-state')).toBeVisible();
expect(screen.getByText('创建项目智能体后开始对话')).toBeVisible();
expect(screen.queryByRole('textbox')).not.toBeInTheDocument();
expect(projectApi.create).not.toHaveBeenCalled();
expect(conversationApi.snapshot).not.toHaveBeenCalled();
fireEvent.click(screen.getByRole('button', { name: '创建或恢复项目智能体' }));
expect(onOpenProjectSettings).toHaveBeenCalledOnce();
});
it('makes the first-Conversation textarea editable while runtime metadata is held', async () => {
projectApi.list.mockResolvedValue({ projects: [project], activeProjectId: project.id });
projectApi.config.mockResolvedValue({ project, config });

View File

@@ -0,0 +1,113 @@
import { describe, expect, it } from 'vitest';
import type {
CodingProjectAgent,
CodingProjectConfig,
} from '../../shared/coding-project-contracts';
import {
hasReadyCodingProjectAgent,
isCodingProjectAgentReady,
isCodingProjectConversationReady,
} from '../../shared/coding-project-contracts';
const createdAt = '2026-09-06T00:00:00.000Z';
function createAgent(overrides: Partial<CodingProjectAgent> = {}): CodingProjectAgent {
return {
id: 'agent-1',
avatarId: 'spark',
roleName: '编程助手',
name: '小洛',
builtIn: false,
enabled: true,
skillIds: [],
responsibility: {
mission: '帮助完成项目',
owns: [],
boundaries: [],
collaborators: [],
principles: [],
},
prompt: '',
archivedAt: null,
pinned: false,
model: {
accountId: 'account-1',
modelId: 'model-1',
thinkingLevel: 'off',
},
modelResolution: 'resolved',
createdAt,
updatedAt: createdAt,
...overrides,
};
}
function createConfig(overrides: Partial<CodingProjectConfig> = {}): CodingProjectConfig {
return {
schemaVersion: 2,
projectType: 'custom',
initialized: true,
agents: [createAgent()],
knowledgeDirectory: 'knowledge',
createdAt,
updatedAt: createdAt,
...overrides,
};
}
describe('coding project Conversation readiness', () => {
it('accepts an enabled, unarchived, fully configured Agent', () => {
const agent = createAgent();
const config = createConfig({ agents: [agent] });
expect(isCodingProjectAgentReady(agent)).toBe(true);
expect(hasReadyCodingProjectAgent(config)).toBe(true);
expect(isCodingProjectConversationReady(config)).toBe(true);
});
it('rejects a project with no Agents', () => {
const config = createConfig({ agents: [] });
expect(hasReadyCodingProjectAgent(config)).toBe(false);
expect(isCodingProjectConversationReady(config)).toBe(false);
});
it.each([
['disabled', { enabled: false }],
['archived', { archivedAt: createdAt }],
] satisfies Array<[string, Partial<CodingProjectAgent>]>)('rejects a %s Agent', (_label, overrides) => {
const agent = createAgent(overrides);
expect(isCodingProjectAgentReady(agent)).toBe(false);
});
it('rejects an Agent whose model still requires resolution', () => {
const agent = createAgent({ model: null, modelResolution: 'required' });
expect(isCodingProjectAgentReady(agent)).toBe(false);
});
it('rejects an Agent with a resolved but missing model', () => {
const agent = createAgent({ model: null });
expect(isCodingProjectAgentReady(agent)).toBe(false);
});
it('rejects an Agent with an empty responsibility mission', () => {
const agent = createAgent({
responsibility: {
...createAgent().responsibility,
mission: ' ',
},
});
expect(isCodingProjectAgentReady(agent)).toBe(false);
});
it('requires the project to be initialized', () => {
const config = createConfig({ initialized: false });
expect(hasReadyCodingProjectAgent(config)).toBe(true);
expect(isCodingProjectConversationReady(config)).toBe(false);
});
});

View File

@@ -6,9 +6,34 @@ import { codingWorkspaceStore } from '@/stores/coding-workspace';
import { useProjectConfigStore } from '@/stores/project-config';
import { useSettingsStore } from '@/stores/settings';
import { createCodingProjectConfigV2 } from '@electron/coding-projects/project-config';
import type { CodingProjectAgent } from '@/types/coding-project';
const learningIpcMock = vi.hoisted(() => vi.fn());
const readyAgent: CodingProjectAgent = {
id: 'agent-1',
avatarId: 'avatar-01',
roleName: '项目智能体',
name: 'Builder',
builtIn: false,
enabled: true,
model: { accountId: 'account-1', modelId: 'model-1', thinkingLevel: 'off' },
modelResolution: 'resolved',
skillIds: [],
responsibility: {
mission: '完成项目工作',
owns: [],
boundaries: [],
collaborators: [],
principles: [],
},
prompt: '',
archivedAt: null,
pinned: false,
createdAt: '2026-09-06T00:00:00.000Z',
updatedAt: '2026-09-06T00:00:00.000Z',
};
vi.mock('@/components/layout/Sidebar', () => ({
Sidebar: ({ sidebarCollapsedOverride }: { sidebarCollapsedOverride?: boolean }) => (
<aside data-testid="sidebar-stub" data-sidebar-collapsed={sidebarCollapsedOverride === undefined ? 'unset' : String(sidebarCollapsedOverride)} />
@@ -105,6 +130,34 @@ describe('MainLayout module isolation', () => {
expect(screen.getByTestId('titlebar-stub')).toHaveAttribute('data-overlay', 'false');
});
it('keeps the gate when a legacy config says initialized but has no usable Agent', () => {
const project = codingWorkspaceStore.getState().activeProject!;
useProjectConfigStore.setState({
configsByProjectId: {
[project.id]: { ...createCodingProjectConfigV2(), initialized: true, agents: [] },
},
});
renderLayout('/chat');
expect(screen.getByTestId('project-initialization-gate')).toBeVisible();
expect(screen.getByText('项目还差一步')).toBeVisible();
});
it('allows programming routes when the project has a fully configured Agent', () => {
const project = codingWorkspaceStore.getState().activeProject!;
useProjectConfigStore.setState({
configsByProjectId: {
[project.id]: { ...createCodingProjectConfigV2(), initialized: true, agents: [readyAgent] },
},
});
renderLayout('/chat');
expect(screen.queryByTestId('project-initialization-gate')).not.toBeInTheDocument();
expect(screen.getByTestId('route-content')).toBeVisible();
});
it('keeps the canonical plugin workspace outside the local project initialization gate', () => {
renderLayout('/plugins');

View File

@@ -0,0 +1,211 @@
import { fireEvent, render, screen, waitFor, within } from '@testing-library/react';
import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { ProjectConfiguration } from '@/pages/ProjectConfiguration';
import { codingWorkspaceStore } from '@/stores/coding-workspace';
import { useProjectConfigStore } from '@/stores/project-config';
import { useProviderStore } from '@/stores/providers';
import type { ProviderAccount } from '@/lib/providers';
import type { CodingProjectAgent, CodingProjectConfig, CodingProjectSummary } from '@/types/coding-project';
import { createCodingProjectConfigV2 } from '@electron/coding-projects/project-config';
const getCodingSkillsMock = vi.hoisted(() => vi.fn());
vi.mock('@/lib/coding-product-tools', () => ({
getCodingSkills: (...args: unknown[]) => getCodingSkillsMock(...args),
}));
const NOW = '2026-09-06T00:00:00.000Z';
const project: CodingProjectSummary = {
id: 'project-1',
path: 'D:/projects/project-1',
name: 'Onboarding project',
createdAt: NOW,
updatedAt: NOW,
lastOpenedAt: NOW,
};
const configuredAccount: ProviderAccount = {
id: 'account-1',
vendorId: 'custom',
label: 'Test account',
authMode: 'api_key',
model: 'model-1',
fallbackModels: [],
enabled: true,
isDefault: true,
createdAt: NOW,
updatedAt: NOW,
};
const readyAgent: CodingProjectAgent = {
id: 'agent-1',
avatarId: 'avatar-01',
roleName: '项目智能体',
name: 'Builder',
builtIn: false,
enabled: true,
model: { accountId: configuredAccount.id, modelId: configuredAccount.model!, thinkingLevel: 'off' },
modelResolution: 'resolved',
skillIds: [],
responsibility: {
mission: '完成项目工作',
owns: [],
boundaries: [],
collaborators: [],
principles: [],
},
prompt: '',
archivedAt: null,
pinned: false,
createdAt: NOW,
updatedAt: NOW,
};
function LocationProbe() {
const location = useLocation();
return <output data-testid="location-path">{location.pathname}</output>;
}
function renderConfiguration(config: CodingProjectConfig) {
useProjectConfigStore.setState({
configsByProjectId: { [project.id]: config },
knowledgeByProjectId: { [project.id]: [] },
});
return render(
<MemoryRouter initialEntries={['/project-config']}>
<Routes>
<Route path="/project-config" element={<ProjectConfiguration />} />
<Route path="/models" element={<LocationProbe />} />
<Route path="/chat" element={<LocationProbe />} />
<Route path="/module-select" element={<LocationProbe />} />
</Routes>
</MemoryRouter>,
);
}
function setProviderModels() {
useProviderStore.setState({
accounts: [configuredAccount],
vendors: [],
});
}
describe('project configuration onboarding', () => {
beforeEach(() => {
vi.clearAllMocks();
getCodingSkillsMock.mockResolvedValue({ skills: [] });
const load = vi.fn().mockResolvedValue(undefined);
const reloadWorkspace = vi.fn().mockResolvedValue(undefined);
const refreshProviderSnapshot = vi.fn().mockResolvedValue(undefined);
codingWorkspaceStore.setState({
activeProject: project,
projects: [project],
conversations: [],
load: reloadWorkspace,
});
useProjectConfigStore.setState({ load });
useProviderStore.setState({
accounts: [],
vendors: [],
refreshProviderSnapshot,
});
});
it('strongly guides a project without models to model settings', async () => {
renderConfiguration(createCodingProjectConfigV2(NOW));
expect(await screen.findByTestId('project-agent-setup-callout')).toHaveTextContent('必需');
expect(screen.getByTestId('project-agent-setup-primary')).toHaveTextContent('先配置模型');
expect(screen.getByTestId('project-configuration-back-button')).toHaveAccessibleName('稍后设置');
fireEvent.click(screen.getByTestId('project-agent-setup-primary'));
expect(await screen.findByTestId('location-path')).toHaveTextContent('/models');
});
it('saves the first Agent as initialized and enters chat after creation', async () => {
setProviderModels();
const savedConfig = vi.fn((_projectId: string, nextConfig: CodingProjectConfig) => Promise.resolve(nextConfig));
const reloadWorkspace = vi.fn().mockResolvedValue(undefined);
useProjectConfigStore.setState({ save: savedConfig });
codingWorkspaceStore.setState({ load: reloadWorkspace });
renderConfiguration(createCodingProjectConfigV2(NOW));
fireEvent.click(await screen.findByTestId('project-agent-setup-primary'));
const dialog = await screen.findByRole('dialog', { name: '创建项目智能体' });
fireEvent.change(within(dialog).getByLabelText(/智能体名称/), { target: { value: 'Builder' } });
fireEvent.change(within(dialog).getByLabelText(/职责说明/), { target: { value: '完成项目工作' } });
fireEvent.click(within(dialog).getByRole('button', { name: '创建并进入对话' }));
await waitFor(() => expect(savedConfig).toHaveBeenCalledTimes(1));
expect(savedConfig).toHaveBeenCalledWith(project.id, expect.objectContaining({
initialized: true,
agents: [expect.objectContaining({
name: 'Builder',
modelResolution: 'resolved',
})],
}));
expect(reloadWorkspace).toHaveBeenCalledTimes(1);
expect(await screen.findByTestId('location-path')).toHaveTextContent('/chat');
});
it('labels the back action and returns a complete project to chat', async () => {
setProviderModels();
renderConfiguration({
...createCodingProjectConfigV2(NOW),
initialized: true,
agents: [readyAgent],
});
const backButton = await screen.findByTestId('project-configuration-back-button');
expect(backButton).toHaveAccessibleName('返回对话');
fireEvent.click(backButton);
expect(await screen.findByTestId('location-path')).toHaveTextContent('/chat');
});
it('offers a new Agent when the project contains only disabled Agents', async () => {
setProviderModels();
renderConfiguration({
...createCodingProjectConfigV2(NOW),
initialized: false,
agents: [{ ...readyAgent, enabled: false }],
});
const setupButton = await screen.findByTestId('project-agent-setup-primary');
expect(setupButton).toHaveTextContent('创建项目智能体');
fireEvent.click(setupButton);
expect(await screen.findByRole('dialog', { name: '创建项目智能体' })).toBeVisible();
});
it('confirms before the labelled back action discards Agent edits', async () => {
setProviderModels();
renderConfiguration({
...createCodingProjectConfigV2(NOW),
initialized: true,
agents: [readyAgent],
});
fireEvent.click(await screen.findByTestId(`project-agent-${readyAgent.id}`));
const editor = await screen.findByRole('dialog', { name: `${readyAgent.name} · 编辑智能体` });
fireEvent.change(within(editor).getByLabelText(/智能体名称/), { target: { value: 'Builder 2' } });
fireEvent.click(within(editor).getByRole('button', { name: '保存智能体' }));
await waitFor(() => expect(editor).not.toBeInTheDocument());
fireEvent.click(screen.getByTestId('project-configuration-back-button'));
const confirm = await screen.findByRole('dialog', { name: '放弃未保存的项目配置?' });
fireEvent.click(within(confirm).getByRole('button', { name: '返回对话' }));
expect(await screen.findByTestId('location-path')).toHaveTextContent('/chat');
});
});