Files
makelore/.project-docs/30-worklog/tasks/20260906-remove-canvas-inspiration-56e64d28.md
T

5.1 KiB

Task: Remove Canvas inspiration entry

Identity

  • Task ID: 20260906-remove-canvas-inspiration-56e64d28
  • Mode: Feature
  • Branch: codex/20260906-remove-canvas-inspiration-56e64d28-remove-canvas-inspiration
  • Worktree: /Users/inmanx/Documents/makelore-task-remove-canvas-inspiration-56e64d28
  • Base commit: f8eee430f4
  • Owner: codex
  • Status: Ready for integration

Scope

  • Remove the user-visible “获取灵感” action from both expanded and collapsed Canvas sidebars.
  • Retire the Prompt Museum Renderer route and redirect historical /image-prompts deep links to the Canvas workspace.
  • Remove route-specific title-bar/sidebar treatment and update focused unit, Electron E2E, README, and retained server-contract wording.

Intent And Constraints

  • Keep Canvas conversation, Living Form, Workspace, Quote, Task, Asset, project creation, and project deletion behavior unchanged.
  • Preserve Main-owned Prompt Museum API/auth/media security boundaries in this small UI-removal task; do not infer authority to delete server data or change backend contracts.
  • Keep old links safe and deterministic by returning users to /image-canvas without initializing Programming providers.
  • Maintain the Chinese-only Makelore light interface and existing module-access policy.

Outcome

  • Removed the lightbulb/inspiration action from both expanded and collapsed Canvas sidebars.
  • Retired the Prompt Museum Renderer route and its lazy bundle entry. Historical /image-prompts paths now redirect to /image-canvas while remaining covered by the Canvas module-access gate.
  • Removed the obsolete Prompt Museum title-bar and sidebar-spacing special cases, so Canvas keeps one workspace shell.
  • Preserved the dormant Main-owned Prompt Museum Host API, authentication, media validation, shared DTOs, and their existing focused tests; this task changes only the AI Design product surface and does not delete server data.
  • Updated README, retained server-contract wording, focused unit coverage, and the Electron E2E flow to describe and verify the retired entry.

Verification

  • corepack pnpm install --frozen-lockfile — passed with repository-pinned pnpm 10.33.4.
  • Focused Vitest coverage for App routing, Main layout, TitleBar, and the light visual system — 4 files, 41 tests passed.
  • corepack pnpm run typecheck — passed.
  • corepack pnpm run lint:check — passed with zero errors and five pre-existing warnings in unrelated Home/Makelore files.
  • corepack pnpm run build:vite — passed for Renderer, Main, Preload, and the release utility worker.
  • node ./node_modules/@playwright/test/cli.js test tests/e2e/image-workspace-v2.spec.ts --grep "removes the inspiration entry" — passed 1/1, confirming the sidebar entry is absent and the historical route returns to Canvas.
  • corepack pnpm test — passed: 1,859 ordinary tests passed, three skipped, and the isolated pressure test passed 1/1.
  • git diff --check — passed.

Follow-ups

  • A serialized Integration task should reconcile canonical Prompt Museum product statements and split the mixed Museum/Canvas production-smoke commitment so the still-relevant Canvas deletion and re-Quote checks remain tracked.
  • Physically deleting the retained Main API, shared DTOs, or upstream data would require a separate explicit scope; this task intentionally leaves those secure boundaries intact and unreachable from the current product UI.

Promotion Candidates

  • Target: .project-docs/30-worklog/current-state.md, .project-docs/20-architecture/system-overview.md, .project-docs/20-architecture/module-map.md, .project-docs/20-architecture/data-flow.md, .project-docs/40-domain/business-rules.md, .project-docs/40-domain/glossary.md, and .project-docs/80-commitments/commitments.md.
  • Proposal: record that Prompt Museum is no longer an active Canvas product surface: expanded/collapsed sidebars expose no inspiration action, the page is not mounted or bundled by App routing, and historical /image-prompts links redirect to /image-canvas. Retained Main API/auth/media validation and shared DTO code is dormant compatibility/security infrastructure rather than a visible module. Remove Museum-specific production-smoke work from the mixed commitment while retaining its Canvas deletion and re-Quote portions.
  • Evidence: the user's explicit direction, focused 41-test regression suite, full 1,859-test plus pressure pass, typecheck, lint, production build, and the passing Electron route/sidebar check.
  • Future impact: navigation and product documentation must not restore the inspiration action or Prompt Museum route without a new explicit product decision. Dormant API removal remains separately scoped.
  • Semantic conflict: this supersedes canonical statements that Canvas exposes a Prompt Museum entry and that its pending Prompt participates in active Canvas data flow; it does not change ADR-007 or Main-owned security boundaries.
  • Human confirmation: already supplied by the user in this task; no additional product-direction approval is required during integration.