Files
makelore/.project-docs/30-worklog/tasks/20260820-integrate-download-size-6e3a91c2.md
T

3.1 KiB

Task: Integrate Learning download size removal

Identity

  • Task ID: 20260820-integrate-download-size-6e3a91c2
  • Mode: Integration
  • Branch: codex/20260820-integrate-download-size-6e3a91c2-integrate-download-size
  • Worktree: D:\Datas\OthersProjects\makelore-integrate-download-size-6e3a91c2
  • Base commit: 2168e291b2
  • Owner: codex
  • Status: Ready for Integration

Scope

  • Merge verified source commit 8509084 into the integration branch.
  • Promote the accepted Learning download behavior into ADR-005, architecture, domain rules, success criteria, README, server contract, current state, evidence, and the pending production-smoke commitment.
  • Advance local main without overwriting its pre-existing untracked task record.

Intent And Constraints

  • Follow the user's explicit decision that project downloads must not perform archive-size validation.
  • Preserve Main ownership of authentication, fixed archive routes, same-origin redirects, native destination selection, SHA-256, ZIP signature, temporary files, cleanup, and atomic rename.
  • Keep the Works Square upload/storage size policy distinct from client download behavior: the service may retain an independent operations upload limit, but Makelore does not enforce it while downloading.
  • Do not modify, add, remove, or adopt the unrelated untracked record already in the canonical main worktree.

Outcome

  • Merged source commit 8509084 through integration merge 0c1a360.
  • Promoted the no-size-validation behavior into ADR-005, the decision index, system overview, module map, data flow, domain rules, glossary, success criteria, current state, evidence index, README, server collaboration contract, and Learning production-smoke commitment.
  • Kept the optional 512 MiB rule only as an independent Works Square operations upload/storage policy; Makelore does not enforce it during download.
  • Preserved SHA-256, ZIP signature, same-origin redirects, account binding, temporary-file cleanup, and atomic save.

Verification

  • Pinned pnpm 10.33.4 frozen install: passed.
  • Focused Learning tests: 2 files, 17 passed.
  • Full unit suite: first run had one unrelated Robot async-loading test failure; that test passed immediately in isolation, and the complete rerun passed 176 files / 2061 tests.
  • pnpm run typecheck: passed.
  • pnpm run lint:check: passed with zero errors and six pre-existing warnings.
  • pnpm run build:vite: passed for Renderer, Main, Preload, and utility worker; existing dynamic-import and chunk-size advisories only.
  • Canonical size-rule scan and git diff --check: passed.
  • Independent sub-agent review was not run because the user explicitly required that no sub-agents be created; final integration review stayed in the primary task.

Follow-ups

  • Package and smoke the merged client with a real archive response that omits or misreports Content-Length.
  • Monitor disk-space behavior for very large archives because the client now has no archive-size ceiling by explicit product decision.

Promotion Candidates

  • None; accepted source-task candidates were promoted in this Integration Gate.