makelore/.project-docs/30-worklog/tasks/20260827-x01-crash-cleanup-7d4b1e92.md

Task: Remediate X-01 crashed CDP cleanup

Identity

• Task ID: 20260827-x01-crash-cleanup-7d4b1e92
• Mode: Feature
• Branch: codex/20260827-x01-crash-cleanup-7d4b1e92-x01-crash-cleanup-7d4b1e92
• Worktree: D:\Datas\OthersProjects\makelore-x01-crash-cleanup-7d4b1e92
• Base commit: 23c49aa3d2
• Owner: codex
• Status: Ready for Integration

Scope

• Bound best-effort preview-data cleanup CDP commands in electron/agent-browser/module.ts, preserving normal removal, child release, and auto-attach ordering.
• Add the focused crashed-renderer/never-settling-removal regression in tests/unit/agent-browser-core.test.ts.
• Own only this task record and the two files above; do not modify the coordinator, open a PR, or perform live acceptance.

Intent And Constraints

• X-01 packaged evidence showed a crashed renderer can leave Page.removeScriptToEvaluateOnNewDocument pending forever, blocking the next public data-enabled open during cleanup.
• Race each cleanup command against the existing bounded best-effort cleanup convention (1,000 ms), swallow command failure/timeout, and clear timers.
• Preserve successful cleanup ordering and the existing preview token invalidation semantics; avoid a broad CDP refactor.

Planning Gate

• Result: Passed.
• Evidence: concurrent task gate started this isolated feature task from exact base 23c49aa3d28730be657387cf9c061fb3a3bb53a8; current task record, project-memory entry documents, coordinator scope, lifecycle/X-01 pointers, and relevant Agent Browser seams were read; no conflicting owned path was found.

Plan

1. Add a narrow bounded debugger-cleanup helper and apply it to preview script removal, child waiting-target release, and cleanup auto-attach restoration.
2. Prove a never-settling removal response cannot block crash invalidation and the next data-enabled open.
3. Run focused tests, typecheck, scoped lint, project-docs gates, and commit once from the exact base.

Outcome

• Added a 1,000 ms timer-bounded best-effort debugger command helper and used it for preview script removal, document-child waiting-target release, and cleanup Target.setAutoAttach. Normal successful cleanup retains its prior ordering. A never-settling script-removal regression now proves renderer crash invalidation does not block the next data-enabled open.

Verification

• PASS: corepack pnpm vitest run tests/unit/agent-browser-core.test.ts (78/78).
• PASS: corepack pnpm run typecheck.
• PASS: corepack pnpm exec eslint electron/agent-browser/module.ts tests/unit/agent-browser-core.test.ts.
• PASS: git diff --check.
• PASS: check_doc_drift.py --task-id 20260827-x01-crash-cleanup-7d4b1e92.
• The isolated worktree required corepack pnpm install --frozen-lockfile --offline; it changed no tracked dependency files.

Follow-ups

• No live/E2E run was requested for this bounded X-01 remediation; coordinator should rerun live acceptance after integrating the commit.

Promotion Candidates

• None; this is a feature-task implementation with no canonical project-memory change.