7.1 KiB
7.1 KiB
Task: Merge teacher composer and prompt UI into latest main
Identity
- Task ID: 20260929-teacher-ui-merge-67ac892e
- Mode: Feature
- Branch: codex/20260929-teacher-ui-merge-67ac892e-teacher-ui-merge
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20260929-teacher-ui-merge-67ac892e
- Base commit:
e30d357d98 - Owner: codex
- Status: Ready for Integration
Scope
- Merge committed teacher UI source
fef3b3aand its approved composer, timestamp and welcome dependencies into latest main; preserve current published shortcuts, catalog refresh, project-scoped history, bundled child-reply plugin, empty-work preview and window lifecycle.
Intent And Constraints
- User authorizes fetching latest code and merging into local main. Preserve source commits and foreign worktrees. No subagents, remote push, cloud publication, paid calls or trial restart. Main is owned by a ready historical task; all preparation occurs in this isolated checkout, with only the explicitly requested final clean fast-forward in main.
Outcome
- Prepared a verified merge of source
fef3b3aa9binto maine30d357d98. Resolved nine files by combining project-scoped routing/history and directory revision refresh with teacher models/voice, timestamps, standalone welcome bubbles, community link, prompt placement and smaller reply cards. README preserves project isolation and current cloud configuration ownership. Source history retained. Merge commit2b2d39449cwas fast-forwarded into the clean primary main after verifying its HEAD had not moved. The final documentation commit records completion.
Verification
- Repository-pinned pnpm 10.33.4. Typecheck, full lint (0 errors / 8 pre-existing warnings), production Renderer/Main/Preload/utility build and 388 focused unit tests passed.
- Full suite: 274 files / 2764 tests passed / 3 skipped, plus the separately serialized pressure test passed (2765 total passed). No failing tests.
- Browser regression: 45 initial cases passed; the two timestamp cases exposed a fixture missing the new project-scoped teacherConversationsPath export. Added the matching fixture export and models response, then both cases passed. All 47 affected cases now pass across 319/375/508/768/1280/1470px as applicable.
- Six Electron scenarios passed: draft preservation and work/chat switching, incomplete-reply retry, project-separated chats/drafts through reload, catalog refresh, three-completed-round introduction dismissal, and click/dismiss persistence. Used isolated synthetic profiles/Host API fixtures. An untracked built-entry wrapper suppressed native activation for these tests; restored exact production entry afterward. No live trial, user conversation, cloud configuration or paid model was touched.
- Full main-only window lifecycle, empty-work preview, bundled language plugin and existing catalog/project-isolation behavior remain in the merge; no file outside this accepted feature chain was replaced with the older source tree.
- Project doc drift reports only four imported source task records as FOREIGN_DOC because it compares source history against this task main base. Verified each working/index blob byte-for-byte against
fef3b3a(74151afe73,f97f019d0a,860db9cfc7,f55adfc884); all canonical files are unchanged. The explicit user request to merge this branch authorizes carrying its committed history. This is not adoption or editing of unknown work; no registry/script bypass or override was used, and this diagnostic is not reported as a passing drift check.
Follow-ups
- Local main contains the completed verified merge. No remote push or trial restart requested. Keep feature/composer sources available for continuing temporary-app work and pending separately authorized cloud rollout. User explicitly approved removal of only this completed merge worktree. Its committed result is in main, it is clean and no process references it. Retire this checkout through the official lifecycle command after preserving this cleanup record in main; preserve branch, commits, trial and feature/composer worktrees.
Promotion Candidates
- Existing source UI/model/timestamp promotion candidates remain for the canonical integration owner. This merge adds no product decision and does not modify canonical records.
Project Context Loaded
- Task ID/mode/branch/worktree/base: 20260929-teacher-ui-merge-67ac892e / feature / codex/20260929-teacher-ui-merge-67ac892e-teacher-ui-merge / /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20260929-teacher-ui-merge-67ac892e /
e30d357d98. Official start/status verifies ownership and reservation. App worktree tool reported parent directory is not a Git repository; official skill isolation succeeded. - Read AGENTS, entry/memory/planning gate, own record, positioning, current state, decisions and teacher ADR, system overview, relevant domain/success criteria, evidence/reflection/commitment indexes, and all peer Scope/Intent/Promotion sections. Source composer and prompt outcomes/verification read.
- Goal: child-friendly creation with cloud-defined teachers, Main-owned credentials/tools/billing and per-account/project/teacher ongoing chats. Latest main includes version/revision refresh, configured prompts, empty preview, bundled language plugin and native close fixes absent from the trial branch; merge must combine these rather than replace main.
- Peer ownership retained: composer/prompt/community are completed source dependencies; empty-work and window-close outcomes already in main. Active help-label/release and undefined child-language scope remain separate. Older component lifecycle proposals are superseded by current text/quick-reply-only implementation. No unresolved product-policy conflict.
- Existing canonical integration lock belongs to classroom-integration; this code merge uses feature mode and does not reconcile canonical documents. Source task records remain unchanged.
- Model selection is capability-gated; paired cloud changes remain separately pending, and this merge does not deploy them.
- Files: teacher routes/service/hooks/panels, shared model/timestamp contracts, chat layout/welcome, README and existing tests.
- Gate: Passed.
Plan
- Merge committed feature source into a candidate based on clean latest local main; resolve textual overlaps using both approved behaviors.
- Run typecheck, relevant tests then full unit suite, lint, production build and affected browser/Electron checks.
- Verify source ancestry and preservation of main-only changes, commit integration evidence, and fast-forward local main. Retain trial and foreign worktrees.
Approved Cleanup
- Resumed the same task solely for the user-approved worktree retirement. Ownership verified; reuse the completed planning context above. No product files or peer records changed. Cleanliness, committed Ready status, main ancestry and absence of dependent processes verified. The app has no attached artifact for this skill-managed checkout, so use the official task_context retire lifecycle from the primary checkout.