8.4 KiB
8.4 KiB
Task: Keep Agent sidebar collapsed until explicit expansion
Identity
- Task ID: 20261012-agent-sidebar-manual-67c1a8e4
- Mode: Feature
- Branch: codex/20261012-agent-sidebar-manual-67c1a8e4-agent-sidebar-manual
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20261012-agent-sidebar-manual-67c1a8e4
- Base commit:
a340c0fd94 - Owner: codex
- Status: Ready for Integration
Scope
- Remove the advanced-settings resource policy helper sentence. Keep the Agent sidebar collapsed on pointer/focus arrival; explicit toggle remains the only expansion action. Refresh the “我的智能体” and “渠道” SVG icons in the existing visual language, preserving labels and routes.
Intent And Constraints
- User confirmed the requested icons are the sidebar “我的智能体” and “渠道”, not the top return/collapse controls. Product-language communication; no temporary app update. Preserve return/collapse alignment, cards-first entry, model/resource choices and permission enforcement. Restrict changed hover policy to cloud_agents; Code and other modules keep existing peek. No real cloud saves/publish/model requests during checks; only isolated fixtures.
Project Context Loaded
Task context:
- Task ID: 20261012-agent-sidebar-manual-67c1a8e4; Feature; owner codex.
- Branch: codex/20261012-agent-sidebar-manual-67c1a8e4-agent-sidebar-manual.
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20261012-agent-sidebar-manual-67c1a8e4.
- Base:
a340c0fd94, completed conversation polish including cards-first navigation. - Bundled check/start/status passed and ownership/reservation exactly match. 37 peer records read-only: 36 concrete scopes, one old child-language record undefined. No blocking semantic conflict. Relevant overlaps: entry-nav same-row return/toggle and cards-first behavior, config-simplify model/resource controls and existing permission semantics, Code hover/resize behavior outside Agents.
Read:
- AGENTS.md; 05-agent-entry read-before-planning, memory-index and planning-gate; own task record.
- 00-brief positioning/success; 20-architecture community-collaboration; task-relevant current-state integrated snapshot, decision-index/system-overview and full personal-cloud-agents ADR.
- Task-relevant domain/evidence/reflection/commitments indexes; scopes/constraints/promotion candidates of every peer.
- Current MainLayout, Sidebar, TitleBar, ConfigurationFields and focused navigation/peek checks. Design skill search; adapt its friendly/icon consistency guidance to the existing cream/pastel/orange product language.
Relevant understanding:
- Project serves students/creators with creation and AI, excludes courses in the client. Main/WS/Yuxi own authorization, resources, accounting and run state; removing text does not change policy.
- Integrated snapshot predates current simplified Agents UI. Human-approved base is authoritative for this feature; no canonical docs are edited in Feature mode.
- Existing collapse preview listens across toggle, titlebar, focus and sidebar zones. Agents must have no transient preview, including a preview left over from another route. Explicit toggle and keyboard activation remain accessible.
- Navigation labels/routes, current-page indication, return control/native window safe spaces and non-Agent preview remain intact. Personal cloud resource selections/enforcement unchanged.
- Evidence commitments distinguish fixture/compiled source from real account, paid provider or installed app acceptance. User expressly forbids trial update; no live app operation is needed.
- Likely files: MainLayout hover policy, Sidebar scoped SVG presentation, ConfigurationFields one sentence, README and focused behavior checks.
- Unknowns resolved: user clarified both sidebar icon positions; no prescribed replacement artwork, use consistent existing SVG set. Old undefined peer has no concrete dependency.
Gate result:
- Passed.
Plan
- Scope sidebar-preview suppression to Agents and clear stale transient state across route changes; preserve explicit mouse/keyboard toggle and other modules.
- Delete only the resource helper sentence and refresh the two sidebar icons without changing navigation or policy.
- Verify hover/toggle/route transitions, resource UI and relevant Electron fixture, typecheck/lint/build; update task-scoped evidence and save changes. Do not update the temporary app.
Outcome
- Removed only the advanced-settings resource-policy helper sentence. Model requirements, resource selection and underlying access enforcement are unchanged.
- Agents, including channels and conversation/configuration routes, now disable transient sidebar preview. Hovering the toggle, titlebar or left edge and focusing the toggle keep a collapsed sidebar hidden. Clicking the toggle or activating it with the keyboard still changes the persisted collapsed preference.
- Entering/leaving the Agents module resets preview sources and cancels pending close timers. A preview from Code cannot appear in Agents or revive after returning; Code preview and the fixed expanded Canvas sidebar remain available.
- Replaced the two confirmed sidebar icons with a pale-purple conversation robot for “我的智能体” and a pale-blue connection-node icon for “渠道”. Labels, current-page indication and destinations are preserved. Retained the separate Bot icon used by the robot module.
- README and focused checks reflect the final behavior. No temporary application, runtime pointer, manifest, user profile or cloud data was updated.
Verification
typecheck: passed after preserving the robot module's shared Bot import. The initial check caught that missing import; it was corrected before the final build and UI check.- Scoped ESLint for MainLayout, Sidebar, ConfigurationFields, the sidebar-preview unit check and the Electron check: passed.
git diff --check: passed. build:vite: passed on the final source. Build log:/tmp/makelore-agent-sidebar-manual-build.log.cloud-agents-page.test.tsx: 31 checks passed. MainLayout sidebar-preview and module-gate checks: 18 passed. Covers both Agent routes, all four preview sources, explicit toggle, module transitions, pending timers, unchanged Code preview and Canvas expansion.- Production Electron isolated fixture (
tests/e2e/cloud-agents.spec.ts): 1 scenario passed. Actual shell checks confirm hovering the toggle/titlebar/left edge and focusing do not open the sidebar; Enter and click do. The removed helper is absent; existing create/configure/resource/save/start-chat checks still pass. - Visually reviewed
cloud-agent-sidebar-icons.pngandcloud-agent-advanced-model.pngfrom.tmp/agent-sidebar-manual-electron/cloud-agents-personal-clou-c4180--published-chat-in-Electron/. Both sidebar icons are visible with distinct pastel badges and unchanged readable labels. - Verification uses an isolated test profile and fixture-owned Host API responses. This is source/fixture evidence, not acceptance in the user's logged-in temporary app or a real cloud/model call. User expressly requested no temporary app update.
- Read-only peer review found no actionable issues: route boundary covers Agent subpages, sources/timers are cleared, explicit toggle remains available, other modules and shared robot icon are preserved.
- Bundled
check_doc_drift.py --task-id 20261012-agent-sidebar-manual-67c1a8e4: passed; changes remain inside Feature ownership boundaries.
Follow-ups
- Preserve this task branch/worktree for integration. Include its recorded base and preceding Agent page changes when integrating; do not replace another active checkout.
- Temporary app update remains deferred until the user requests it. No cloud service change is needed for this task.
Promotion Candidates
- Target: integrated current state and Agent navigation/UI guidance. Proposal: Agents alone use explicit sidebar expansion; other modules retain their existing preview behavior. Record the removed resource-policy helper as a presentation change, with policy enforcement unchanged. Evidence: user's explicit request, confirmed icon locations, 18 MainLayout checks and production Electron scenario. Future impact: subsequent shared-sidebar changes should preserve this per-module interaction. Semantic conflicts: older generic hover-preview descriptions need the Agents exception during serialized integration. Human confirmation: the behavior is already authorized by this conversation; canonical edits still require Integration mode.