Merge remote main preserving project chats and reply recovery
This commit is contained in:
@@ -10,7 +10,7 @@
|
||||
|
||||
## Decision
|
||||
|
||||
- 2026-09-28 用户要求移除老师对话栏的结构化组件并确认合并:不再渲染想法板、结构图、流程/条件图和逐项对照,以及邀请、焦点和操作按钮。新提问与引导求助不再携带 discussion-v1 或 discussion;普通正文、“帮我看看”与快捷追问保留。旧结构化数据与快照不删除,结果不确定的旧请求重试保持原 ID 和完整输入,避免重复调用。
|
||||
- 2026-09-28 用户要求移除老师对话栏的结构化组件并确认合并;远程回复清理和恢复工作一并集成。新咨询由 Main 统一声明 `{reply, quickReplies}`,正文和 0–3 条可选快捷回复按所选智能体云端配置生成,客户端只提供入口事实、上下文与输出格式。超额新卡片保留正文及原文诊断,不截断或展示;历史卡片数量不改写。旧组件状态和快照作为不透明档案保留,不恢复交互、主动导入或进入模型上下文,旧组件修改路由已移除。 结果不确定的旧请求保留请求 ID、问题、引用与来源,客户端重试移除退役组件字段,Main 按已有请求身份返回结果,避免重复执行。
|
||||
- 2026-09-28 用户确认像微信联系人一样持续聊天,随后明确纠正:不同项目必须有不同会话,并授权修复及合并。唯一可见聊天身份为账号+项目+稳定 config_id;同一项目不按名称、默认标记、Pi 会话或发布版本创建第二个可见聊天。项目隔离历史、草稿、已读和模型上下文;本次范围为本机持久化,不含跨设备同步。
|
||||
- 新项目创建内部默认编程 Agent 并保存 defaultAgentId,会话直接列在项目下。打开项目不自动创建空会话,首次发送或显式新建才创建;历史 Agent ID、配置和 Pi 会话绑定保留。
|
||||
- Yuxi 拥有老师提示词、模型和所选 Skills、知识库、MCP、子智能体。Works Square 运营菜单首先展示下发列表,添加时从 Yuxi 选择并发布当前配置,支持多位、默认选择与启停,不维护第二份提示词编辑器或试聊界面。
|
||||
@@ -18,19 +18,21 @@
|
||||
- Yuxi 原生 Request/Run、PostgreSQL checkpoint 和 Redis 事件拥有云执行。Main 冻结本次账号、项目、来源 Pi 已完成分支的公开消息及老师话题,通过三个只读工具提供目录、UTF-8 文件行段和会话原文。文件按读取时内容提供,会话按本轮快照读取,不上传完整工程、Pi 原始日志或思考。
|
||||
- 本地工具只交给老师主线程:云端持久中断完整批次,Main 主动回传配对结果,关联 Run 续接同一问题。用户于 2026-09-27 授权改造读取工具:声明 read_protocol=2 的客户端支持按层目录与连续原文分页,每问题最多 12 批、成功结果累计 64 KiB、单页 8 KiB,剩余不足 512 字节时收尾;旧客户端保持六批。最后结果消费后显式禁止继续选工具并要求基于已有证据回答。保留原付款人、版本、上下文和截止时间;读取限当前项目,允许 .makelore/project.json,排除其余内部记录与 Git 数据,不提供本地写入或命令。
|
||||
- Works Square 验证学生编程资格,使用专用短期老师凭据;聊天模型费用记入学生 ai_programming / coding_teacher 账本。老师资源仍归 Yuxi 创建者,个人 Agents 模块继续创建者付费,老师问题不占创建者个人智能体金额上限。
|
||||
- 云端保存执行线程、消息和收到的片段。Main 在 userData/agent-conversations/<account>/<agent>/projects/<projectId> 保存轻量聊天索引和独立轮文件;每页50轮,流事件只更新当前轮。Host API 统一使用 /api/coding/projects/:projectId/agent-conversations/:agentId,历史、发送、SSE、停止、讨论、保存和已读均绑定该项目。轮文件先于索引原子保存,恢复不重发模型。停用阻止后续调用,历史仍可查看;重启将未完成问题标为中断,下次提问先停止旧问题。
|
||||
- 每轮冻结项目、Pi 来源、发布版本及只读范围。同一项目相同来源/版本沿用内部 Yuxi 线程,来源或版本改变时开启内部执行段,只携带该项目有预算的公开近期交流;可见聊天保持连续。切换项目恢复另一个独立聊天,不能复用跨项目云端 checkpoint。历史消息按当前项目聊天内的 ID 读取,Pi 与项目配置仍归项目所有。
|
||||
- Code 咨询统一使用服务端下发智能体,不内置老师/朋友角色、本地教学人设或按名称分配的工具权限。名称、头像、简介、欢迎语和推荐问题来自发布定义。所有下发项共享上述只读工具边界,通用讨论组件协议不定义智能体人格。
|
||||
- 结构化讨论在聊天内按项目保存,历史轮保留原卡片快照。正文、历史和带回草稿仅接收云端主线程文本;子线程事件仍推进续传游标。带回回答只追加原项目/Pi 来源的草稿,不自动发送或改写当前其他来源。已下发智能体的旧 Renderer 定时跟进停止派发;新的 Main 主动观察由独立任务实施,本次未接入建议投递,后续必须并入同一聊天,不能恢复项目话题入口。
|
||||
- 云端保存执行线程、消息和收到的片段。Main 在 userData/agent-conversations/<account>/<agent>/projects/<projectId> 保存轻量聊天索引和独立轮文件;每页50轮,流事件只更新当前轮。Host API 统一使用 /api/coding/projects/:projectId/agent-conversations/:agentId,历史、发送、SSE、停止、保存和已读均绑定该项目。轮文件先于索引原子保存,恢复不重发模型。停用阻止后续调用,历史仍可查看;重启将未完成问题标为中断,下次提问先停止旧问题。
|
||||
- 每轮冻结项目、Pi 来源、发布版本及只读范围。同一项目相同来源/版本沿用内部 Yuxi 线程,来源或版本改变、或首轮从旧讨论协议升级到 reply-v1 时开启内部执行段,只携带该项目有预算的公开近期交流;可见聊天保持连续。切换项目恢复另一个独立聊天,不能复用跨项目云端 checkpoint。历史消息按当前项目聊天内的 ID 读取,Pi 与项目配置仍归项目所有。
|
||||
- Code 咨询统一使用服务端下发智能体,不内置老师/朋友角色、本地教学人设或按名称分配的工具权限。名称、头像、简介、欢迎语和推荐问题来自发布定义。所有下发项共享上述只读工具边界,回复格式协议不定义智能体人格。
|
||||
- 历史结构化讨论和快照保留在其原档案中,不参与新回复或项目聊天导入。正文、历史和带回草稿仅接收云端主线程文本;子线程事件仍推进续传游标。带回回答只追加原项目/Pi 来源的草稿,不自动发送或改写其他来源。已下发智能体的旧 Renderer 定时跟进停止派发;独立 Main 主动观察仍未合入,后续必须并入对应项目的同一聊天。
|
||||
- 所有下发智能体以头像和名称在顶栏并排展示,溢出横向滚动。点击恢复当前项目中的唯一聊天或空态、独立草稿和未读,不调用模型;移除新话题加号和话题下拉框。最近50轮先加载,历史分页与流事件按请求身份合并;切换项目或智能体保留各自窗口内阅读位置,已读位置由 Main 持久保存,迟到的读取和事件不得填入另一项目。
|
||||
- 2026-09-28 远程刷新与界面改动合并:顶栏手动刷新只读共享下发目录和配置,更新联系人资料,不重建聊天、不切换选中智能体、不清空历史或草稿;已接受问题保留原版本,下一轮由 Main 固定当前发布版本。停用后保留原聊天但禁止发送。发布介绍在顶栏悬停/聚焦显示,点击当前入口或 Escape 收起咨询栏,边缘调宽保留;不再显示重复面板标题栏或下发智能体新话题入口。追加问题使用三色卡片。
|
||||
- 未发送文字草稿按账号/项目/智能体保存;明确引用仍携带项目/Pi 来源,来源切换后须移除旧引用或恢复原上下文才能发送。旧全局草稿仅由其记录的项目接纳,优先于更早的项目话题草稿;原记录保留。旧全局聊天依据每轮 request.projectId 或 origin.projectId 分入对应项目,保留原请求身份、映射项目已读位置、复制该项目讨论,并开启新的云端执行段。导入可在中断后幂等续接,原始索引和轮文件不修改,无法证明项目的轮仅留在原档案中,不猜测归属。
|
||||
- 未发送文字草稿按账号/项目/智能体保存;明确引用仍携带项目/Pi 来源,来源切换后须移除旧引用或恢复原上下文才能发送。旧全局草稿仅由其记录的项目接纳,优先于更早的项目话题草稿;原记录保留。旧全局聊天依据每轮 request.projectId 或 origin.projectId 分入对应项目,保留原请求身份、映射项目已读位置,并开启新的云端执行段;原讨论状态仅留在原档案。导入可在中断后幂等续接,原始索引和轮文件不修改,无法证明项目的轮仅留在原档案中,不猜测归属。
|
||||
- 更早的话题仅在已登记项目、账号与 config_id 归属均明确时导入,以项目/话题/请求来源去重,重复正文不去重;失联目录稍后重试。无法证明身份的朋友/旧老师历史及旧草稿只读保留。现有云端 coding-teacher 名称不构成角色分类。独立主动观察后续也必须向相应项目的唯一智能体聊天投递建议。
|
||||
- 输入预算在编译时计入完整执行请求。本地旧模型路径按约 2 UTF-8 字节估算 1 Token,工具定义、调用和读取预留纳入同一计量;估算不替代模型上限或实际 usage。云端以完整 JSON 转义后的 query 字节数裁剪来源节选,原文仍可按 ID 读取。固定配置/当前讨论超限与用户问题/引用超限分别提示,不静默修改发布预算、问题、明确引用或话题版本。
|
||||
|
||||
- 咨询回答以 Markdown 渲染标题、列表、表格、代码、HTTP(S) 链接/图片和公式,代码与表格在栏内滚动;普通 JSON、Markdown 链接与代码中的字面转义保持原义。历史 discussion-v1 请求仍由顶层 reply/quickReplies/tool 或专用围栏识别,保留数据解析但不再显示组件。解析失败保留原讨论数据与可恢复正文,完整 unparsedResponse 单独持久保存并默认折叠,不再次注入后续会话上下文。
|
||||
- 咨询回答以 Markdown 渲染标题、列表、表格、代码、HTTP(S) 链接/图片和公式,长内容在栏内滚动;普通 JSON 和代码保持正文。兼容旧 `{intro, questions}` 和含 `tool` 的输出,只提取正文和快捷回复。完整正文可从保留原文中在本地恢复;无法确认完整时显示缺失提示,由用户明确点击重新回答,保持原问题、引用和项目/Pi 来源,保留现有草稿,采用当前发布版本。被动恢复不调用模型或改写已完成原始轮文件;不完整回答和未解析原文不进入后续模型上下文。 原文默认折叠、按字面展示。
|
||||
- 工具活动使用实际主线程事件及 Main 本地读取结果的名称/状态,按 run/call 关联与去重,单独折叠展示;参数、输出、错误原文与推理不进入活动 DTO 或回答。未观察到结果的调用明确显示结果缺失,不补写过期事件或旧话题。Yuxi chat_service 保证只有 AI 角色进入回答流,客户端不按内容外形猜测清洗。
|
||||
|
||||
- 输入为空时显示暖黄色“继续看看👀”,输入后隐藏;点击才发起求助。进入咨询立即收起静态欢迎语并按账号/项目记住,真实未读建议保持显式查看/收起边界。
|
||||
|
||||
## Evidence And Release Boundary
|
||||
|
||||
- 2026-09-28 组件移除源 317def79129503062d15076585881ceae753055c 无冲突快进合入本地 main。47 项相关单测、12 项浏览器布局、1 项 Electron 咨询场景及类型/lint/构建通过;产品与测试保持源字节,沿用其验证。没有服务端或历史数据迁移;未推送、打包或更新安装版。见[源任务](../30-worklog/tasks/20260928-remove-teacher-cards-ef1cf59c.md)和[集成记录](../30-worklog/tasks/20260928-merge-teacher-cards-a09c07f3.md)。
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
- 2026-09-26 已确认[老师 Agent 产品定位](../00-brief/project-positioning.md#老师-agent-的产品定位):某一领域杰出人物的能力转化而成的智能体,供平台学生使用;蒸馏属于实现方法,以真实案例验证领域能力;补充下方既有咨询技术决定。
|
||||
|
||||
- [下发智能体咨询与项目会话导航](ADR-2026-09-22-coding-teacher.md):2026-09-28 amended / implemented;按用户纠正,唯一持续聊天身份为账号+项目+下发智能体,不同项目隔离历史、草稿、已读与模型上下文,保留同项目无新话题入口的交互。Pi 来源/发布版本在每轮接受时冻结,同项目变化只轮转内部线程。旧全局聊天按每轮可证明的项目分入对应会话,保留原文件并开启新云端执行段;不明归属仅保留原档案。学生计费、统一只读工具和主线程正文保持;老师对话栏已移除结构化组件及新请求的组件格式要求,历史数据保留;主动观察建议接入由独立任务继续并绑定对应项目。
|
||||
- [下发智能体咨询与项目会话导航](ADR-2026-09-22-coding-teacher.md):2026-09-28 amended / implemented;按用户纠正,唯一持续聊天身份为账号+项目+下发智能体,不同项目隔离历史、草稿、已读与模型上下文,保留同项目无新话题入口的交互。Pi 来源/发布版本在每轮接受时冻结,同项目变化只轮转内部线程。旧全局聊天按每轮可证明的项目分入对应会话,保留原文件并开启新云端执行段;不明归属仅保留原档案。学生计费、统一只读工具和主线程正文保持;老师对话使用 reply-v1 正文与 0–3 条可选快捷回复,退役组件仅留原档案;本地恢复完整旧正文,无法完整恢复时显式重试且保留草稿;主动观察建议接入由独立任务继续并绑定对应项目。
|
||||
|
||||
## Active Decisions
|
||||
|
||||
|
||||
@@ -6,11 +6,11 @@
|
||||
|
||||
当前项目中顶栏选择下发智能体 → Main 通过 /api/coding/projects/:projectId/agent-conversations/:agentId 读取账号/项目/智能体唯一聊天与最近50轮,打开本身不调用模型 → 学生发送时幂等获取该项目聊天,冻结项目/Pi 来源/当前发布版本 → 获取WS专用凭据 → Yuxi原生Request/Run。同项目/Pi/版本沿用内部线程;同项目来源或版本改变时新建执行段并仅携带该项目有预算的公开交流,不创建第二个可见聊天。切换项目恢复独立聊天,不复用前一项目历史或云端checkpoint。名称、人设和资料来自发布定义。读取中断 → Main校验本轮绑定、取消与额度 → 列目录/读取文件/读取会话原文 → 主动回传配对结果 → 原问题关联Run续接。协议2为12批/64KiB累计成功结果/8KiB单页,旧协议六批;最后一批消费后要求最终回答。保留原问题时限与学生付款人;文件使用读取时内容,会话使用本轮快照。云端只保存消息和收到的片段,完整工程与Pi原始日志保留本机。
|
||||
|
||||
Renderer 新提问/引导求助省略组件格式与讨论上下文 → Main 既有普通回答路径;“帮我看看”仍使用问题建议协议。历史组件状态不再进入可见卡片或焦点控件;不确定的旧请求重试沿用原 ID 与完整输入。存储及旧请求协议不迁移。
|
||||
Renderer 自由输入/空输入框“继续看看👀” → Main 统一 reply-v1 → 完整正文及 0–3 条可选快捷回复。完整正文可从保留原文中在本地恢复;无法确认完整时显示缺失提示,由用户明确点击重新回答,保持原问题、引用和项目/Pi 来源,保留现有草稿,采用当前发布版本。被动恢复不调用模型或改写已完成原始轮文件;不完整回答和未解析原文不进入后续模型上下文。 不确定旧请求仍复用原身份与输入来源,移除退役组件字段;旧组件只留原档案,修改路由退役。
|
||||
|
||||
云端事件 → Main 先推进游标,再仅转发云端主线程文本 → Host SSE/本机历史 → 右侧面板。子智能体文本不混入正文或带回草稿;断线按游标与持久状态恢复。关闭面板不取消已接受问题,停止/退出请求取消原问题;重启后下次提问先停止旧问题。带回回答只追加草稿,不自动发送,旧本地老师话题保留原执行路径。见[老师决定](../10-decisions/ADR-2026-09-22-coding-teacher.md)。
|
||||
|
||||
编译完整请求 → 本地路径按近似Token预算、云端路径按实际JSON query字节预算裁剪来源节选 → 提交前按同一计量复核。问题、明确引用及固定讨论指令保持完整;真正的固定配置超限单独提示。明确引用绑定旧项目/Pi时须移除引用或恢复原来源。聊天轮文件原子写入后更新轻量索引;恢复与旧记录导入按原始身份去重,不重发模型。旧全局聊天依据每轮可证明的项目分入对应存储,映射已读、复制相应讨论并开启新云端执行段;原文件不修改,无项目归属的轮保留原档案。历史页和SSE按请求ID合并且排除跨项目迟到响应,已读归Main,文字草稿和阅读缓存按账号/项目/智能体保存。旧全局草稿只导入其记录的项目,保留原值。现代聊天停止旧定时跟进,独立主动观察后续接入相应项目的同一聊天。
|
||||
编译完整请求 → 本地路径按近似Token预算、云端路径按实际JSON query字节预算裁剪来源节选 → 提交前按同一计量复核。问题、明确引用及固定回复协议保持完整;真正的固定配置超限单独提示。明确引用绑定旧项目/Pi时须移除引用或恢复原来源。聊天轮文件原子写入后更新轻量索引;恢复与旧记录导入按原始身份去重,不重发模型。旧全局聊天依据每轮可证明的项目分入对应存储,映射已读并开启新云端执行段,旧讨论只留原档案;原文件不修改,无项目归属的轮保留原档案。历史页和SSE按请求ID合并且排除跨项目迟到响应,已读归Main,文字草稿和阅读缓存按账号/项目/智能体保存。旧全局草稿只导入其记录的项目,保留原值。现代聊天停止旧定时跟进,独立主动观察后续接入相应项目的同一聊天。
|
||||
|
||||
## Permanent wallet and recharge
|
||||
|
||||
|
||||
@@ -13,7 +13,7 @@ TeacherConversationStore 在 userData/agent-conversations/<account>/<agent>/proj
|
||||
|
||||
## Current Architecture
|
||||
|
||||
咨询正文由 TeacherReply 渲染 Markdown、GFM 与公式;TeacherDiscussionPanel、焦点与操作逻辑及专用样式已移除。新提问与引导求助省略 presentation/discussion,使用既有普通回答路径;“帮我看看”及快捷追问保留。Main 保留历史 discussion-v1 解析与存储,旧未确认请求仍以原身份和完整输入重试,Renderer 不再显示其组件。普通 JSON/代码仍是正文。失败原文默认折叠持久保存且不重新注入上下文。云端主线程与本地读取活动投影为独立的工具名称/状态,参数、结果和推理不进入回答。Yuxi 在消息投影处筛选 AI 角色;详见[咨询决定](../10-decisions/ADR-2026-09-22-coding-teacher.md)。
|
||||
咨询正文由 TeacherReply 渲染 Markdown、GFM 与公式。新咨询由 Main 统一声明 `{reply, quickReplies}`,正文和 0–3 条可选快捷回复按所选智能体云端配置生成,客户端只提供入口事实、上下文与输出格式。超额新卡片保留正文及原文诊断,不截断或展示;历史卡片数量不改写。旧组件状态和快照作为不透明档案保留,不恢复交互、主动导入或进入模型上下文,旧组件修改路由已移除。 完整正文可从保留原文中在本地恢复;无法确认完整时显示缺失提示,由用户明确点击重新回答,保持原问题、引用和项目/Pi 来源,保留现有草稿,采用当前发布版本。被动恢复不调用模型或改写已完成原始轮文件;不完整回答和未解析原文不进入后续模型上下文。 首次协议升级轮转内部云线程,保留项目可见聊天;工具活动继续独立展示名称/状态。详见[咨询决定](../10-decisions/ADR-2026-09-22-coding-teacher.md)。
|
||||
|
||||
知识文档上传、附件导入与替换后由客户端自动衔接既有解析索引接口,Main 保留处理 Task、可用性与替换关系。Renderer 每 5 秒串行刷新已加载页面,以服务端持久 Task 与实际分块显示阶段、失败原因及可用于回答的文档;请求未确认时保留同一操作意图,观察到新 Task 后才解除本地不确定状态。替换失败及清理重试保留旧可用内容,零分块不显示可用。见[知识处理交互规则](../10-decisions/ADR-2026-09-11-personal-cloud-agents.md#知识文档处理与可用状态)。
|
||||
|
||||
|
||||
@@ -4,6 +4,8 @@ This file is the integrated default-branch snapshot. Feature tasks record progre
|
||||
|
||||
## Integrated Through
|
||||
|
||||
- 2026-09-28:续接获授权的组件移除集成任务,合并远程 `b645cfa312ca23e9a44758211a43f4934a44a70f` 与本地 `d37bc13`。保留账号/项目/智能体独立聊天,接入 reply-v1、0–3 条新快捷回复、完整正文/历史恢复、显式重试、欢迎语消费及旧组件接口退役;项目边界适配到路由、存储与测试。补齐首次导入全局历史时的内存回复恢复,原始存档保留。472 项相关单测、28 项浏览器布局、6 项 Electron 场景、标准类型检查、变更文件 lint 和最终生产构建通过。旧组件仅留原档案,不进入新上下文;本条取代下方历史记录中组件协议与跨项目假设。三份未跟踪文档及六份远程来源记录原样保留,未推送、打包、部署或更新安装版;独立主动观察仍未合入。见[集成记录](tasks/20260928-merge-teacher-cards-a09c07f3.md#remote-main-merge-resume)。
|
||||
|
||||
- 2026-09-28:用户确认主目录交接后,将组件移除源 317def79129503062d15076585881ceae753055c 从 592920d 无冲突快进合入本地 main。老师对话栏移除想法板、结构图、流程图、对照及其专用交互,新问题不再请求组件输出;普通正文、快捷求助、历史数据及未确认旧请求的原身份恢复保留。产品/测试与源一致,沿用47项单测、12项布局、1项Electron以及类型/lint/构建验证。三份外来文档原样保留且未提交;未推送、打包或更新安装版。见[源记录](tasks/20260928-remove-teacher-cards-ef1cf59c.md)和[集成记录](tasks/20260928-merge-teacher-cards-a09c07f3.md)。本条取代下方历史记录中的可见讨论组件描述。
|
||||
|
||||
- 2026-09-28:按用户“不同项目应有不同会话”的明确纠正,无冲突合入源 `4b41c23a3a5e9da1a329b1b69930787a670163de`(基于 `a21a1f0`)。当前唯一聊天身份为账号+项目+下发智能体,历史、草稿、已读、SSE、接受锁和模型上下文按项目隔离;同项目保持持续聊天,无新话题入口。旧全局轮按已知项目归属导入,保留原文件与请求身份,使用新云端执行段;不明归属保留原档案。本文下方跨项目单聊天条目保留为历史,本条及修订咨询ADR为当前规则。产品/测试与已验证源一致,沿用382项相关测试、标准typecheck、scoped lint、Vite构建和3项Electron场景;扩展Main仍有66项既有诊断。三份外来文档未改动、未提交;未推送、打包、部署或调用收费模型。独立主动观察未合入,后续须适配项目聊天。见[修复源](tasks/20260928-agent-project-chat-6644c06d.md)与[本次集成](tasks/20260928-merge-agent-single-chat-9911c6df.md#project-isolation-correction-resume)。
|
||||
|
||||
@@ -0,0 +1,87 @@
|
||||
# Task: Diagnose truncated consultation reply and raw-content fallback
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20260928-agent-reply-truncation-c812b59f
|
||||
- Mode: Feature
|
||||
- Branch: codex/20260928-agent-reply-truncation-c812b59f-agent-reply-truncation
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20260928-agent-reply-truncation-c812b59f
|
||||
- Base commit: 4495345fb0a9ea1abef8e603629ce9b51d73eb05
|
||||
- Owner: codex
|
||||
- Status: Ready for Integration
|
||||
|
||||
## Scope
|
||||
|
||||
- Diagnose and repair the screenshot showing only a short prose fragment followed by a legacy parse-failure notice and raw structured output.
|
||||
- After diagnosis, user authorized the three repair paths: conservative full-prose recovery, independent auxiliary-field fallback plus explicit manual retry, and passive recovery of retained history.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- Initial investigation was read-only. The later implementation is explicitly authorized; keep local raw evidence and avoid automatic model replay, live app restart, cloud edits, or deployment. The earlier main merge/push request covered the completed Agent refresh feature.
|
||||
- Latest user constraint: no subagents. Remaining code review, changes and verification are performed by the primary agent; earlier partial subagent work was reviewed locally.
|
||||
- Ownership and planning gates passed in this task checkout. Reused unchanged canonical context from the prior turn; read all current peer task scopes. Current trial Main 9adab45 / Renderer cb48f60 belongs to the separate reply-cleanup task and is distinct from main 4495345. Inspected committed code only; peer working files remain untouched.
|
||||
|
||||
## Outcome
|
||||
|
||||
- The three approved repair paths are implemented and locally verified: conservative full-prose recovery, explicit incomplete-reply handling/manual retry, and passive retained-history recovery. The running client remains unchanged.
|
||||
- Implementation and final validation are recorded below; the following investigation notes preserve how the original diagnosis was established.
|
||||
|
||||
### Initial Diagnosis
|
||||
|
||||
- The screenshot notice maps to the legacy structured-response parse fallback. The UI retains unparsedResponse separately from the recovered prose, so content in the raw box was received even though normal presentation failed.
|
||||
- Independently reproduced an exact-shape failure: an unescaped ASCII quote after the opening prose causes JSON parsing to fail, while stringToken/recoverReply accepts only the prefix as a complete reply. The old parser returns the same short-prefix + screenshot notice combination. The newer shared/teacher-reply fields recovery in committed 9adab45 still accepts the same premature prefix.
|
||||
- This is a demonstrated mechanism, not a confirmed trace of the screenshot request. The exact question/response was not found in the known trial/installed-app project teacher histories. The screenshot shows only the tail of the raw output, so its precise triggering bytes and provider termination reason remain unknown.
|
||||
- Cloud structured replies use completed run.output; missing intermediate stream deltas do not explain a complete raw body being cut by this recovery path. Do not claim all provider truncation/format causes are excluded.
|
||||
|
||||
## Verification
|
||||
|
||||
- Final implementation checks: 329 unit checks, 17 headless UI cases, typecheck, scoped ESLint and production compilation passed. Native Electron case added and enumerated but not executed. The inherited dependency-document drift finding remains disclosed below.
|
||||
|
||||
### Initial Investigation Verification
|
||||
|
||||
- Read old shared/teacher-discussion.ts stringToken/recoverReply/parser fallback, UI diagnostics rendering, service/discussion persistence and cloud-runner final-output handling.
|
||||
- Independent agent performed an in-memory execution of both committed parsers with malformed quoted prose and reproduced the truncated prefix. No tests or product files added/modified.
|
||||
- Inspected only relevant local app runtime descriptors/project catalogs and teacher conversation records to seek the screenshot request; no matching request found. No credentials read or emitted.
|
||||
- Project-document structure, task ownership drift and whitespace checks passed.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- The requested repair is complete; integrate and update the running client as a separate next step. Provider byte-level correlation remains unavailable; retain the screenshot-level evidence boundary.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- See Repair Follow-ups And Promotion Candidates below. Initial diagnosis introduced no accepted behavior change; the later repair was approved by the user.
|
||||
|
||||
## Agent Log Screenshot Follow-up
|
||||
|
||||
- Same-task start/status matched; reused unchanged project context and reviewed the new welcome-diagnosis/latest cleanup peer scope. Read-only gate passed; no product or live state edits.
|
||||
- User supplied an Agent log screenshot containing the visible prefix `{"reply":"它早就不是"刚搭好架子"那种阶段了——` followed by a substantial prose answer and legacy structure payload. The earlier client screenshot shows exactly the prose prefix 它早就不是, the legacy fallback notice, and the later tool payload in the raw-content box.
|
||||
- Independent reviewer replayed the visible prefix in memory against the old discussion parser and committed 9adab45 reply parser. Both cut at precisely the same quote. Together the screenshots locate the observed short-body symptom to malformed-format handling/recovery, strongly contradicting a stream that delivered only the first few characters.
|
||||
- Distinguish upstream malformed structured output from downstream unsafe recovery: model-produced internal quotes need valid encoding, and the client must not accept an ambiguous prefix as complete prose. This is parsing before rendering, rather than visual clipping.
|
||||
- Evidence remains screenshot-level, not a request-correlated byte capture. A log renderer could alter escape display, so do not claim the full transport was byte-for-byte audited or all possible transport issues were excluded. No corrective code had been applied at this diagnostic stage; the approved implementation is recorded below.
|
||||
|
||||
## Approved Repair Implementation
|
||||
|
||||
- Same-task ownership and planning gates passed on resume; registry remains this task / feature / owned worktree and branch. Merged the committed current reply-only dependency `40c247a` through `dda2f0a` so the fix applies to the current consultation implementation. No peer working files or canonical documents were edited; protocol-boundary and welcome/child-language changes were not imported.
|
||||
- Prose extraction now requires a credible field boundary. Internal unescaped quotes and literal control characters are repaired only inside the prose field and only when the entire repaired envelope parses. Ambiguous boundaries, duplicate bodies and missing body endings fail visibly; missing content is never guessed. Ordinary Markdown, escaped code and Unicode remain intact.
|
||||
- Complete prose survives malformed or truncated auxiliary data. Replies without trustworthy complete prose get `replyIncomplete`; UI shows an explicit incomplete state and a manual retry, never the half-sentence as a finished answer. Raw diagnostics stay folded and inert, including when escaping was successfully repaired. Technical output instructions require proper JSON string escaping without changing the published persona.
|
||||
- Manual retry reuses original text, intent, references, source, topic and published version; an accepted completed turn gets a new request identity, uncertain resends reuse their identity. Click guarding prevents duplicate sends. Both current text/references and edits made while awaiting the send response survive. Project-only history does not substitute a different source or send the `project` sentinel as a conversation id. Disabled/legacy Agents and check-ins cannot be retried as ordinary questions.
|
||||
- Store reads repair eligible completed history from retained original content locally. Valid unrelated prose is not replaced by a different recovered answer. Failed/cancelled/interrupted/running replies are never promoted to success. The projection preserves raw data, opaque legacy fields, accounting, request status and topic metadata; no model call or repair-only disk write occurs. In mixed history, restart recovery is persisted before applying the display projection. Incomplete assistant content and suggestions are excluded from both compiled model context and read_conversation while the user's original question remains available.
|
||||
|
||||
## Implementation Verification
|
||||
|
||||
- Focused parser, history and Renderer unit suites: 153/153 passed.
|
||||
- Related service/cloud/model/read-tools/guidance/retired-route/activity suites: 176/176 passed (329 unit checks total).
|
||||
- Typecheck and scoped ESLint passed. Production Renderer/Main/Preload/worker compilation passed (`build:vite`); build artifacts remain ignored.
|
||||
- Headless Chrome layout/interaction suite: 17/17 passed, covering 319px and 508px widths, complete screenshot-shaped prose, incomplete manual retry, original input retention, no automatic send, draft retention and legacy-history behavior. Personally inspected narrow-panel recovered/incomplete screenshots. Initial browser run could not launch because the Playwright bundled binary was absent; reran successfully using the already-installed Chrome channel.
|
||||
- Added an Electron integration case for click-only retry and preservation of both main and consultation drafts. Native Electron case was not run because the existing fixture shows/focuses an app window; keep the user's no-focus workflow intact. Browser interaction and backend history tests passed independently; do not claim a native smoke or a real-provider end-to-end run.
|
||||
- Current live client was not replaced/restarted; code is ready for integration and a subsequent app update. Tests use deterministic local fixtures and do not consume paid model calls or modify real conversation history.
|
||||
|
||||
## Documentation Boundary Note
|
||||
|
||||
- Project-document structure check passed. The task-aware drift checker reports the already-committed cleanup task record as foreign relative to the original `4495345` base because this task merged the required reply-only dependency. That record is byte-identical to dependency `40c247a`; no owned-work edits touch it. Do not rewrite or delete the peer record, falsify the recorded base, or claim this inherited checker finding passed. All implementation-era document edits are limited to this task record and product README.
|
||||
|
||||
## Repair Follow-ups And Promotion Candidates
|
||||
|
||||
- Integrate the tested repair branch, then update the user's running client when requested. Exact historical screenshot request was not located locally; fixture tests reproduce the visible triggering bytes, not a provider trace.
|
||||
- Candidate for the canonical current-state/consultation architecture at integration: preserve trustworthy full prose independently of auxiliary data; flag ambiguous incomplete prose explicitly; user-triggered retries preserve original scope and draft; retained raw data permits local history repair without replay. Evidence: focused unit and headless UI checks above. Future impact: any new reply format/history migration must retain the same safety properties. No change to published persona, model billing boundary or retired component policy; no additional product decision required beyond the user's approved repair.
|
||||
@@ -0,0 +1,60 @@
|
||||
# Task: Merge current completed Makelore changes into main and push
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20260928-latest-main-merge-b6a42f90
|
||||
- Mode: Feature
|
||||
- Branch: codex/20260928-latest-main-merge-b6a42f90-latest-main-merge
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20260928-latest-main-merge-b6a42f90
|
||||
- Base commit: a21a1f077cc11976213290a6b843bb74be97ab44
|
||||
- Owner: codex
|
||||
- Status: Ready for Integration
|
||||
|
||||
## Scope
|
||||
|
||||
- Integrate current completed product work into origin/main, adapt overlaps, verify, fast-forward local main and push without force.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- User explicitly requested all latest project code merged and pushed. No subagents, paid model calls, app restart or cleanup. Preserve foreign working trees and original source records. Canonical memory reconciliation is not included; its integration lock is held by another task.
|
||||
|
||||
## Outcome
|
||||
|
||||
- Merged completed product sources with merge ancestry preserved: reply cleanup/recovery `d530abe` (including `40c247a`) via `d032425`; cloud-owned teaching policy and 0–3 new shortcuts `54a40d2` via `65a0c21`; welcome dismissal `c96bb45` via `44b16f8`. Base `a21a1f0` already contains continuous account/Agent conversations, manual refresh and hover UI.
|
||||
- Adapted recovery to per-turn continuous storage, including older pages and read-only history tools; uncertain legacy index excerpts cannot leak partial answers. Display repair leaves completed turn files unchanged, including when another turn needs restart recovery.
|
||||
- Incomplete replies retry only on deliberate click, retaining the original problem/references and both drafts. Continuous retries require the original project/source; each newly accepted turn still resolves the current published version. Legacy pinned-version behavior remains compatible.
|
||||
- Persisted rejection of excessive new shortcuts so a later history repair cannot restore them; historical cards remain preserved. Removed retired discussion rendering/state updates while retaining opaque source archives. Welcome dismissal follows current account-wide scope.
|
||||
- Refreshed README and combined unit/browser/native-E2E fixtures. Product merge `cafebca05710b7bf1a6fa62ec51be4992a73a18c` was fast-forwarded into local main and pushed normally; `git ls-remote origin refs/heads/main`, origin/main and local main matched with a clean checkout. No app restart, model call, dependency change or worktree cleanup.
|
||||
|
||||
## Verification
|
||||
|
||||
- Passed: 405 focused unit tests in 14 files, covering parser, history, service, continuous conversations, UI, cloud/model/read contracts, refresh, welcome and preview. Command: `corepack pnpm exec vitest run tests/unit/teacher-reply.test.ts tests/unit/teacher-reply-history.test.ts tests/unit/coding-teacher-ui.test.tsx tests/unit/teacher-conversation.test.ts tests/unit/teacher-conversation-panel.test.tsx tests/unit/coding-teacher.test.ts tests/unit/teacher-companion.test.tsx tests/unit/coding-teacher-cloud.test.ts tests/unit/coding-teacher-model.test.ts tests/unit/coding-teacher-read-tools.test.ts tests/unit/teacher-guidance.test.ts tests/unit/teacher-retired-discussion-route.test.ts tests/unit/teacher-cloud-activity.test.ts tests/unit/agent-browser-panel.test.tsx --maxWorkers=2`.
|
||||
- Passed: 28 headless browser cases via installed Chrome, including legacy/continuous quote recovery and retry at 319px/508px, draft retention, rich reply containment, archived component suppression and preview layout. Command: `MAKELORE_LAYOUT_BROWSER_CHANNEL=chrome corepack pnpm exec playwright test tests/e2e/teacher-reply-layout.spec.ts tests/e2e/teacher-preview-layout.spec.ts --max-failures=1`.
|
||||
- Passed: `corepack pnpm run typecheck`, scoped ESLint for changed implementation/tests, `corepack pnpm run build:vite`, and `git diff --check`. Native Electron E2E additions parse/list successfully but were not executed because the fixture opens a foreground app window; the current client was left running unchanged.
|
||||
- Passed: required project-document structure; every selected source is an ancestor of the merge candidate. Re-fetched remote main remains `a21a1f0`.
|
||||
- Drift checker reports the four committed source-task documents as foreign relative to the task's original base. These are imported by the explicitly requested source merges, not edited by this task. Byte comparison against `d530abe`, `54a40d2`, `40c247a` and `c96bb45` confirms all four unchanged; only this task's own record is authored here. No canonical document changes, altered baseline or ownership override used to suppress this inherited checker finding.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- Product publication complete; source and integration worktrees retained.
|
||||
- Full native Electron interaction execution and release packaging remain outside this merge validation; no claim of a rebuilt running client.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- A later canonical-memory integration can reconcile retired discussion UI descriptions with the current README and continuous-chat/reply-recovery contracts; this task does not hold that integration lock or edit those canonical sources.
|
||||
|
||||
## Project Context Loaded
|
||||
|
||||
- Task ID/mode/branch/worktree/base: verified against official start/status; feature `20260928-latest-main-merge-b6a42f90`, branch `codex/20260928-latest-main-merge-b6a42f90-latest-main-merge`, this absolute worktree, fetched base `a21a1f077cc11976213290a6b843bb74be97ab44`.
|
||||
- Managed app worktree creation was unavailable because the chat root is the repository parent; official skill start created and registered isolation from the explicit remote base.
|
||||
- Read: entry order, memory-index in 05-agent-entry, own record, positioning, latest current-state/teacher ADR/decision index, architecture, domain/success criteria, relevant evidence/reflection/commitment/stale indexes, and all registered peer Scope/Intent/Promotion sections.
|
||||
- Project goal: cloud-configured domain Agents support student projects; Main owns calls, source scope and persistence. Current remote main already implements account/Agent continuous chats, per-turn project/source/version, shared manual refresh and hover UI. No fixed local persona, deleted component UI or old topic controls should reappear.
|
||||
- Local current product sources: reply cleanup and truncation fix `d530abe` (includes `40c247a`); technical prompt boundary `54a40d2` supersedes older Alice audit `89c913b`; welcome-entry fix `c96bb45`. Other feature branches are ancestors of main, diagnostic-only, or superseded experiments. Old dirty teacher-components and trial launcher are known historical work and remain excluded/read-only; child-language task has only an unfinished task record and no product code.
|
||||
- Overlap: remote continuous-chat storage/send/history needs the same repair, retry and retired-component behavior as legacy topics. Resolve mechanically while preserving the accepted single-chat/per-turn rules. The old retry's pinned-topic assumption must not reverse the newer per-turn current-version contract.
|
||||
- Canonical docs contain historical component descriptions; README will describe the combined implementation. Existing canonical integration lock and source task records remain untouched. No new semantic decision needed; gate Passed.
|
||||
|
||||
## Plan
|
||||
|
||||
1. Merge the committed reply, prompt-boundary and welcome changes into fetched remote main; resolve overlapping code and adapt continuous-chat paths.
|
||||
2. Add focused regressions for the combined storage, context and UI paths; run relevant tests, typecheck, lint and build plus headless UI where available.
|
||||
3. Verify committed source coverage, record outcomes, fast-forward clean local main, push normally and compare remote identity. Keep all worktrees.
|
||||
@@ -0,0 +1,74 @@
|
||||
# Task: Merge teacher reply cleanup and approved UI changes into main
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20260928-merge-reply-cleanup-eb8d39b3
|
||||
- Mode: Feature
|
||||
- Branch: codex/20260928-merge-reply-cleanup-eb8d39b3-merge-reply-cleanup
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20260928-merge-reply-cleanup-eb8d39b3
|
||||
- Base commit: a21a1f077cc11976213290a6b843bb74be97ab44
|
||||
- Owner: codex
|
||||
- Status: Ready for Integration
|
||||
|
||||
## Scope
|
||||
|
||||
- Merge committed teacher/UI cleanup source 40c247a into latest origin/main and push normally; preserve existing continuous-chat and per-turn project/version behavior.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- User explicitly authorizes main integration and repository push; packaging belongs to their colleague. No packaging, native app restart, cloud publication, real model calls or focus changes. Preserve all foreign worktrees and source records.
|
||||
|
||||
## Outcome
|
||||
|
||||
- Source cleanup `40c247a` merged with the current account/Agent continuous-chat behavior in `581ebc8`, then incorporated complete remote main `077184a` before publication. Preserve its reply recovery, cloud-owned teaching policy, 0–3 new shortcuts, welcome dismissal, pagination and per-turn source/version behavior.
|
||||
- Additional merge safeguards: old component mutation route removed from the continuous API; no new per-project component state is created or imported; existing malformed legacy component archives are retained verbatim. Old component instructions cannot persist through a reused pre-upgrade cloud checkpoint: first reply-protocol turn rotates the internal thread and carries bounded public reply history, without changing the visible chat.
|
||||
- Unconfirmed legacy hint requests retain their old text, ID and original project/source. Migrated per-project drafts keep that original scope; cross-project or cross-source hint retry waits for the original scope instead of issuing another charge. Existing send-in-flight and incomplete-reply retry safeguards remain intact.
|
||||
- No package, app restart/update, cloud configuration publication, paid model call or desktop focus change. Source/live-trial and all foreign worktrees remain intact. Product merge `f6944c46ebdeb05a940043ba629aee6716b5e44a` was pushed normally from `077184a` to remote main; `git ls-remote` matched the merge HEAD. Primary checkout is owned by another task and was left untouched; packaging can fetch remote main.
|
||||
|
||||
## Verification
|
||||
|
||||
- Final `corepack pnpm run typecheck`, `corepack pnpm run lint:check` and `corepack pnpm run build:vite` passed. Lint has 8 existing unrelated warnings; build has existing chunk-size/dynamic-import warnings. No dependencies or build outputs committed.
|
||||
- Final backend focused validation: 7 suites / 261 tests passed; UI/companion/chat: 4 suites / 144 tests passed; continuous storage/retired routes: 2 suites / 17 tests passed. These runs overlap and are not an additive unique-test count.
|
||||
- Headless Chrome: all 28 teacher reply/preview layout cases verified. First run passed 27; one initial Vite scan observed an in-progress shared-type merge marker, then passed when rerun after resolution. Native Pi Electron E2E fixture parses and lists 19 tests; not launched because it opens a foreground app.
|
||||
- Full `corepack pnpm test`: 261 files / 2639 tests passed, 3 tests skipped; 3 failures in 2 unrelated Pi files. Independently reproduced exactly those same 3 failures on a disposable archive of original remote `077184a` (12 passed / 3 failed in the selected two files): two event-projector old error-message assertions and the managed-worker opener runtime-v6/v7 assertion. Baseline log: `/tmp/makelore-baseline-077184a-21n6od02/baseline-tests.log`. The script's separately gated pressure suite was then run manually and passed 1/1.
|
||||
- `git diff --check`, required project-document structure and semantic comparison against latest remote passed. Task drift checker reports 5 imported source-task documents as foreign relative to the original base; byte comparison against `077184a` confirms every imported document unchanged. Only this task's own record is authored here; no canonical writes, ownership override, baseline alteration or source-document edits were used to suppress the inherited diagnostic.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- Remote main publication complete at product merge `f6944c46ebdeb05a940043ba629aee6716b5e44a`. Packaging and installation belong to the user's colleague; this final record commit carries no product changes. Source/live-trial worktree retained.
|
||||
- The 3 pre-existing Pi test assertions were subsequently repaired at the user's request; see the follow-up below. Native Electron foreground interactions and signed package verification are not claimed.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- A later canonical-memory integration should reflect current text/quick-reply-only teacher behavior and first-upgrade cloud-thread rotation. Evidence is the merged implementation, focused regressions and baseline comparison; existing cloud-defined policy and continuous-chat decisions remain unchanged. This feature task does not own the canonical integration lock.
|
||||
|
||||
## Project Context Loaded
|
||||
|
||||
- Identity verified by official start/status: feature task `20260928-merge-reply-cleanup-eb8d39b3`, this managed worktree/branch, base `a21a1f077cc11976213290a6b843bb74be97ab44`. Source checkout is owned by the completed cleanup task and still hosts the temporary app, so it remains read-only.
|
||||
- Read entry/memory index, own record, project positioning, latest integrated state, decisions, architecture, success criteria and all registered peer scope/intent/promotion sections. Reuse previously loaded teacher domain/evidence/reflection/commitment context; changed continuous-chat rules checked against current main/source task records.
|
||||
- Goal: student-owned creation with cloud-defined teachers, Main-owned request/history/version boundaries, prose and quick replies only. Preserve main's unique account/Agent chat and per-turn project/source/version; remove retired component UI/protocol/state and retain approved empty-composer hint/retry/preview-header styling.
|
||||
- Other tasks: a broader latest-main integration is also registered planning; prepare this requested source in isolation, check remote again before push and never overwrite a concurrent remote advance. Prompt-boundary, truncation repair and welcome changes are separately owned and not added speculatively. Child-language task is unfinished. Canonical integration lock is held elsewhere; keep all canonical/source records read-only.
|
||||
- New integrated single-chat behavior is compatible with component cleanup; overlaps require combined code/tests rather than choosing an entire side. No new product decision needed. Gate Passed.
|
||||
|
||||
## Plan
|
||||
|
||||
1. Merge source 40c247a into fetched main in this isolated branch; preserve source history and resolve overlaps with the current continuous-chat contract.
|
||||
2. Verify backend/context/parser/history and UI/preview/refresh paths, typecheck, lint, production compile and headless layout; independently review the merge.
|
||||
3. Recheck origin/main, integrate any concurrent advance, push normally to main and verify remote ancestry/hash. Keep the live trial checkout; packaging and app updates are outside this request.
|
||||
|
||||
## Follow-up: Three Baseline Test Failures
|
||||
|
||||
- User asks what the reported 3 failures mean, whether they affect the product and requests their repair. Resume the same integration-validation task in its existing owned checkout at `405846c`; official start/status verify the same task ID/mode/branch/worktree. No subagents unless separately approved; this follow-up is performed independently.
|
||||
- Context gate passed: entry/memory/task/peer scopes rechecked; unchanged positioning and prior teacher context retained; read Pi ADR-006, Main architecture, provider/domain success criteria and evidence/reflection/commitment/stale indexes. Main owns credential isolation, public error classification and managed runtime resources. No change to the accepted Pi 0.84.2/runtime-v7 behavior or login recovery flow.
|
||||
- Peers still own application installation/testing and an unfinished child-language task; their files stay read-only. This work repairs the specifically reported test debt in two Pi test files and the matching release-proof filename metadata. No semantic conflict, new product direction, paid call, packaging or app restart is involved.
|
||||
- Evidence: commit `7951cca` deliberately changed the public Provider-auth message and expanded expired-session recognition; `26cbb29` deliberately advanced the managed extension from v6 to v7. Session-projector already expects the new public message. Runtime opener uses the real materialized extension path. The three failed assertions are stale; release proof also retains a stale v6 report label.
|
||||
- Plan: align exact public-message assertions without weakening status/error-code/redaction checks; use the canonical extension filename and verify the concrete extension argument points to a readable file; remove the stale release-proof label; run focused tests, typecheck/lint/build and then the full suite. Preserve histories and production behavior.
|
||||
|
||||
### Follow-up Outcome And Verification
|
||||
|
||||
- Repaired both exact Provider-auth message expectations to the accepted public wording; error code, terminal state, recoverability and secret-redaction checks remain intact.
|
||||
- Worker-opener regression now uses the authoritative versioned extension filename, verifies its exact `--extension` argument path and reads the generated module. The release-proof report uses that same filename instead of an obsolete v6 label. No authentication, runtime version, model behavior or billing change.
|
||||
- Focused event/session projector, managed opener and actual extension bundle: 4 files / 37 tests passed. Full `corepack pnpm test` now passes: 263 files / 2642 tests passed, 3 unchanged skipped tests, followed by the separately executed pressure stage 1 file / 1 test passed. No remaining failed tests.
|
||||
- `typecheck`, full `lint:check` (0 errors / 8 prior warnings), `build:vite`, `git diff --check` and required documentation structure passed. Task drift retains the same 5 unchanged imported source-document diagnostics from the previous integration; current follow-up modifies only this owned record plus the 3 listed test/metadata files relative to `405846c`.
|
||||
- Impact: stale expectations made the full validation command fail although the intended auth projection and v7 extension were operating correctly; stale release-proof metadata could mislabel an artifact report. Repair restores meaningful release validation without downgrading runtime behavior. Formal package verification remains the packaging owner's responsibility.
|
||||
- Continue the authorized repository handoff with a normal fast-forward push to main after commit; no app restart, package, cloud publication, real model request or subagent creation.
|
||||
@@ -12,7 +12,7 @@
|
||||
|
||||
## Scope
|
||||
|
||||
- Integrate verified MakeLore source 317def7 into local main and promote its approved component-free teacher conversation contract.
|
||||
- Integrate verified MakeLore source 317def7 into local main and promote its approved component-free teacher conversation contract. Authorized follow-up also reconciles remote main b645cfa with local project-scoped chats.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
@@ -44,3 +44,24 @@
|
||||
|
||||
- Accepted source candidates promoted under user removal and merge instructions. Source task records remain read-only; no unresolved product-direction choice.
|
||||
|
||||
|
||||
## Remote Main Merge Resume
|
||||
|
||||
- User explicitly authorized resuming this integration owner and completing the already-started merge of remote b645cfa312ca23e9a44758211a43f4934a44a70f into local d37bc13. Official check/start/status passed with the same task, integration lock, main worktree and recorded base. Adopted six incoming source records and preserved three existing untracked records unchanged.
|
||||
- Planning Gate Passed: refreshed entry, own/source records, positioning, integrated snapshot, teacher ADR/index, architecture/data-flow/domain and relevant evidence/reflection/commitments. Read 133 registered peer records; historical template scopes remain unknown without a concrete dependency. Independent observer and macOS diagnosis remain outside this merge.
|
||||
- Preserve the explicitly corrected account/project/agent chat identity, drafts, receipts and cloud-context isolation. Combine it with the remotely approved reply-only protocol, bounded new shortcuts, complete-text/history recovery, welcome dismissal and retired component routes. No new product direction, subagents, push, packaging or paid model calls.
|
||||
- Plan: reconcile conflicting implementations and fixtures; test project-specific histories and uncertain/incomplete reply retries together; run typecheck, relevant units, scoped lint, production build and focused UI/Electron coverage; promote accepted current behavior, pass documentation drift and commit the merge.
|
||||
|
||||
### Remote Merge Outcome And Verification
|
||||
|
||||
- Resolved all 11 conflicted files. Retained local account/project/agent identity, original-source checks, per-project storage/imports, drafts, read positions and SSE. Integrated the remote text/shortcut-only protocol, 0–3 new-card limit, reply repair/manual retry, inert legacy archives, first-upgrade cloud-thread rotation, empty-composer hint, welcome consumption, work-preview header cleanup and Pi runtime test alignment.
|
||||
- Adapted imported test fixtures to project-scoped routes and storage. Combined both sides' coverage rather than preserving obsolete cross-project assertions; removed the retired component-layout spec in favor of the richer reply-layout coverage. The route fixture now returns 404 for removed handlers instead of hanging.
|
||||
- A new combined upgrade regression reproduced a real issue: imported global turns already in the live cache bypassed completed-reply repair on their first page. Page projection now repairs copied results too, preserving the original archive and completed on-disk turn bytes. The focused regression failed before the fix and passed after it.
|
||||
- Verification: standard typecheck passed; 472 relevant unit tests across 19 files passed across the focused runs, with affected persistence/service/history tests rerun after the final fix (121/121). All 28 browser layout cases and six native Electron scenarios passed, including project history/draft switching and reload, manual refresh, incomplete-reply retry and format-error presentation. Changed-file ESLint passed, followed by lint for the final changed Main/test files; Renderer/Main/Preload/utility production build passed again after the fix.
|
||||
- Refetched origin before completion: MERGE_HEAD and origin/main still match b645cfa312ca23e9a44758211a43f4934a44a70f. Canonical teacher ADR/index, architecture/data-flow and business rules now describe the merged behavior and keep project isolation authoritative. Source task records remain unchanged; three original untracked task records remain uncommitted.
|
||||
- No remote push, installed-app update, package, deployment or real paid model request. Verification uses local deterministic fixtures, not live published-model quality. Existing build advisory warnings do not prevent compilation. Independent observer integration remains separate.
|
||||
- Task-aware documentation drift and whitespace checks passed; all conflict index entries are resolved. The durable merge records both source parents and the verified task outcome; final Git state and registry completion are checked after committing. Retained source worktree cleanup remains subject to the earlier pending decision; this primary worktree is unmanaged and is not a cleanup target.
|
||||
|
||||
### Remote Merge Promotion Candidates
|
||||
|
||||
- Accepted reply cleanup/protocol/recovery/welcome candidates are promoted to the teacher ADR, architecture, domain and current integrated snapshot. Their account-wide assumptions are reconciled with the explicitly corrected project-chat contract; no conflicting product decision remains. No source document was edited.
|
||||
|
||||
@@ -0,0 +1,62 @@
|
||||
# Task: Keep teacher runtime instructions scoped to entry facts and UI protocol
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20260928-teacher-protocol-boundary-f2c8a601
|
||||
- Mode: Feature
|
||||
- Branch: codex/20260928-teacher-protocol-boundary-f2c8a601-teacher-protocol-boundary
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20260928-teacher-protocol-boundary-f2c8a601
|
||||
- Base commit: 998796d77cba146ae2a007cbebfdaa1255a3413e
|
||||
- Owner: codex
|
||||
- Status: Ready for Integration
|
||||
|
||||
## Scope
|
||||
|
||||
- Continue the accepted teacher/client boundary on top of completed legacy-component cleanup commit `998796d77cba146ae2a007cbebfdaa1255a3413e`.
|
||||
- Keep entry markers factual and the reply protocol technical. Remove locally appended teaching strategy from active help, guided help, background checks, and reply-format instructions.
|
||||
- Enforce the current 0–3 shortcut capacity for newly generated answers while preserving archived replies and exact diagnostics.
|
||||
- Update focused tests and README; preserve card styling and existing interaction/scheduling machinery.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- User assigned main merge and push to another conversation. This task stays in its isolated feature branch and prepares a tested commit for integration.
|
||||
- Cloud configuration owns Alice's teaching purpose, focus, tone, length, and shortcut prefixes; the host owns invocation facts, available context/tools, and interface protocol.
|
||||
- Keep old component cleanup intact. Do not merge the older `89c913b` patch wholesale because it modifies a superseded protocol.
|
||||
- No cloud configuration publishing, live app restart, scheduler redesign, or teacher-to-operator consensus handoff in this task.
|
||||
- Gate passed before edits: task ownership/status verified; entry, task-relevant memory, and peer scopes reviewed. Relevant canonical documents are unchanged between the previously read baseline and `998796d`; shared memory remains read-only.
|
||||
|
||||
## Outcome
|
||||
|
||||
- Active-help and guided-help messages now identify the student's entry intent; background checks identify a program-triggered check without a fabricated student question. They no longer mandate a teaching strategy.
|
||||
- Reply instructions now declare only the two fields, Markdown body support, optional 0–3 nonempty shortcut strings, and delegation of content/style to published configuration.
|
||||
- Main rejects excess newly generated shortcuts without silently truncating or rewriting them: prose is retained, cards are withheld, and the exact raw answer and format diagnostic are saved. 0/1/3-card replies preserve prefixes and duplicates. The shared compatibility parser and historical store remain unchanged.
|
||||
- The UI now shows recorded reply-format errors beside the preserved answer; raw content stays collapsed and inert. Existing colors, layout, click handling and drafts are unchanged.
|
||||
- Regression coverage includes local/cloud service persistence, history read/list/save, all entry intents, current/legacy envelopes, and UI behavior. README reflects the responsibility boundary and current capacity.
|
||||
- No merge, push, running-app restart, cloud config change, or canonical memory edit performed.
|
||||
|
||||
## Verification
|
||||
|
||||
- Dependency installation: pinned pnpm 10.33.4, frozen lockfile, offline cache; no tracked dependency change.
|
||||
- Focused final suite: 269/269 passed across teacher-guidance, teacher-reply, teacher-reply-history, coding-teacher, coding-teacher-cloud, coding-teacher-model and coding-teacher-ui.
|
||||
- `corepack pnpm run typecheck`: passed.
|
||||
- ESLint for all changed TypeScript/TSX files, including the Electron E2E spec: passed.
|
||||
- `corepack pnpm run build:vite`: passed after the final UI change.
|
||||
- `git diff --check` and task-aware project-doc drift check: passed.
|
||||
- Independent read-only review found no remaining teaching-policy directives in the scoped runtime files and confirmed lossless historical handling.
|
||||
- Added a focused Electron E2E case for visible format errors, absent rejected shortcut buttons, collapsed exact raw text, and preserved drafts. Playwright test collection passed using an existing Electron distribution override; the native test was not executed to avoid launching another app window during concurrent work. Component/service assertions covering these behaviors passed.
|
||||
- Real published-model responses were not tested. Existing topics retain their pinned configuration versions; code tests do not establish that an updated cloud prompt is active.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- Integrate this commit after the legacy-component cleanup; merging/pushing belongs to the user's other conversation.
|
||||
- Validate actual Alice output with a new topic using the published cloud version. Local tests cannot prove model behavior or that existing pinned topics picked up a new prompt.
|
||||
- Three-operation-round checks and shared confirmed context remain separate work.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- Target: canonical teacher decision/current-state documents during integration.
|
||||
- Proposal: runtime help/check-in markers convey entry facts only; teaching strategy is entirely in the selected published agent configuration. Current newly generated replies accept 0–3 shortcuts; historical card counts remain lossless.
|
||||
- Evidence: context/reply code and focused tests in this task; user's accepted client/agent boundary in this conversation.
|
||||
- Future impact: future personas can use the same interface without inheriting Alice's teaching policy; prompt changes are evaluated against the actual published topic version.
|
||||
- Semantic conflicts: supersedes cleanup task's remaining locally mandated single discussion focus and unrestricted new-card count; retains historical compatibility and UI cleanup.
|
||||
- Human confirmation: not additionally required for these already accepted boundaries; no canonical edits in this feature task.
|
||||
@@ -0,0 +1,142 @@
|
||||
# Task: Retire teacher discussion components and preserve text replies and quick replies
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20260928-teacher-reply-cleanup-c8e4a219
|
||||
- Mode: Feature
|
||||
- Branch: codex/20260928-teacher-reply-cleanup-c8e4a219-teacher-reply-cleanup
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore-teacher-reply-cleanup
|
||||
- Base commit: ae0f72d8fa0089f87b41d272da220e1c1397aec8
|
||||
- Owner: codex
|
||||
- Status: Ready for Integration
|
||||
|
||||
## Scope
|
||||
|
||||
- Remove retired visual discussion components from UI, state, context, parser, service and routes; keep teacher prose, clickable quick replies and free input.
|
||||
- Preserve opaque historical data, agent/version selection, read tools, proactive check-ins, billing and operational Agent.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- User explicitly authorizes this product change, superseding old component-based teaching plans. Do not publish cloud configuration, restart applications or steal desktop focus.
|
||||
- Gates passed: read AGENTS, project entry/read-before-planning, memory and indexes, relevant positioning/teacher decision/domain/architecture/current-state/evidence/commitment/stale records, success criteria and peer task scopes. Managed feature worktree identity verified against registry.
|
||||
- Isolated from the live trial checkout. Frontend and reply protocol implementation delegated; backend/context/store and integration verification owned here.
|
||||
- Follow cloud agent configuration for persona, length, prefixes and style; keep only output format and single-angle guided-help requirements locally.
|
||||
- Plan: remove active component plumbing; retain passive legacy fields; add UI/parser/history/service/cloud regressions; run typecheck, targeted/full unit checks, build and guarded UI verification; document and commit.
|
||||
|
||||
## Outcome
|
||||
|
||||
- Removed all four interactive discussion views, their dedicated CSS, state/focus/conversion/lifecycle actions, client mutation API, Host API mutation routes and backend state machine. Pending drafts restore only current send fields while retaining request identity for safe retry.
|
||||
- Ordinary questions and guided-help/suggestions use one text + quickReplies envelope. The local runner and cloud final-output path preserve project reads while keeping tool preambles out of the answer. Check-ins keep their existing plain-text path and scheduling/dedup behavior.
|
||||
- Removed old component schemas/instructions, hard-coded suggestion counts/length/student-voice policy and check-in/guided-help brevity additions. “帮我看看” recommends one concrete starting point with replies around it. Published persona, skills, language, length, prefixes and style remain authoritative; no Alice-specific runtime content.
|
||||
- Legacy discussion/context/snapshot/error data stays opaque and unmodified on read/list/save/recovery. No component is restored or updated. The parser supports old intro/questions, reply envelopes with inert tool data and damaged historical envelopes; only prose and suggestions survive. Raw parse failures or received cancelled output remain inert diagnostics, excluded from context/read_conversation.
|
||||
- Kept teacher selection/version binding, readonly project/source tools, native/cloud billing and request identities, cancellation, source/account guards, active check-ins and operational Agent unchanged.
|
||||
- README now describes the supported product behavior. No cloud publication, real application restart, live trial update or desktop focus change. Work is retained on this isolated feature branch.
|
||||
|
||||
## Verification
|
||||
|
||||
- `corepack pnpm run typecheck`: passed after the combined changes.
|
||||
- `corepack pnpm run lint:check`: passed; scoped ESLint rerun after final parser/service changes passed.
|
||||
- Final duplicate-card regression: both ordinary and guided suggestion cards use request ID + index keys; two repeated-text click/draft cases fail before the fix and pass after it. UI suite 52/52 and scoped ESLint passed; typecheck/build rerun after this final code edit.
|
||||
- Targeted teacher backend/cloud/model/read-tools/UI/parser/history/route/guidance run: 9 files, 281 tests passed. Frontend agent also verified teacher companion and chat panel suites: 103 tests passed across its initial 3-file run.
|
||||
- `corepack pnpm test`: first stage ran 261 files, 259 passed; 2551 tests passed, 3 skipped, 3 failed. The 3 failures are pre-existing Pi event-projector message expectations (2) and managed-worker-opener runtime-v6 versus v7 expectation (1). Isolated `git archive HEAD` base snapshot ae0f72d reproduces the exact same failures (3 failed / 12 passed); these tests and production coding-runtime/contracts/reducer paths have no task diff. Evidence: /tmp/makelore-teacher-reply-full-tests.log and /tmp/makelore-teacher-reply-baseline-tests.log.
|
||||
- The test script’s pressure stage was skipped by its `&&` after baseline failures, so ran `coding-chat-pressure.test.tsx --maxWorkers=1` separately: 1 passed.
|
||||
- `corepack pnpm run build:vite`: passed for Renderer, Main, Preload and utility worker. Generated output stayed ignored in this isolated checkout.
|
||||
- Playwright teacher-reply-layout fixture: 12 headless Chrome checks passed at 319px/508px; rich Markdown/font checks rerun after shared dependency allow-list fix: 2 passed. No Electron/native app launch. Shared Electron first-chat spec updated to assert absence of retired send fields, but native suite deliberately not launched under the no-restart/no-focus constraint.
|
||||
- Independent review found and resolved ordinary JSON questions/tool examples being mistaken for protocol and an aborted runner resolving normally losing received diagnostic bytes. Regressions cover both.
|
||||
- Production search confirms old component words/schemas remain only as passive archive types, historical transport/fence recognition, and test data. No active lifecycle/prompt/action code remains. Model-bound history and read tools use only prose + quick replies; no legacy archived fields or raw failures enter the model.
|
||||
- `check_project_docs.py`, task-aware drift check and `git diff --check`: passed before handoff.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- Integration must preserve the independent manual agent-refresh work while dropping its obsolete component state assumptions; this branch intentionally does not import another task’s unmerged feature.
|
||||
- Track the three existing unrelated Pi test expectation failures separately. No production Pi changes are included here.
|
||||
- Cloud agent configuration and cloud-side stored conversation history were not inspected or published; verification establishes what this client now sends, not an audit of remote prompt contents. Existing pinned versions are intentionally preserved.
|
||||
- Task was not merged, pushed or deployed. No post-merge worktree cleanup applies.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- Targets: `30-worklog/current-state.md`, `10-decisions/ADR-2026-09-22-coding-teacher.md`, `20-architecture/data-flow.md`, `40-domain/business-rules.md`.
|
||||
- Proposal: current teacher UX is prose plus clickable quick replies/free input; retire prior ideas/structure/flow/comparison component plans and model schema/state instructions. Preserve opaque historical data and the teacher responsibility of organizing ideas, understanding relationships and carrying confirmed consensus; published configuration owns expression policy.
|
||||
- Evidence: explicit user direction in this task, deleted UI/API/state/schema paths, parser/history/model-payload regressions, headless interactive verification.
|
||||
- Impact/conflict: supersedes prior active component lifecycle and multiple-topic suggestion assumptions; no automatic migration or history deletion, no change to source/version/billing/operational Agent boundaries. Prior feature-task records remain historical evidence.
|
||||
- Human confirmation: already supplied by this task’s explicit product requirements; canonical promotion must still happen in a serialized integration task.
|
||||
|
||||
|
||||
## Authorized Background Restart Follow-up
|
||||
|
||||
- User explicitly requests restarting the application using the latest project state, superseding the earlier no-restart boundary. Keep no cloud publication and no desktop-focus takeover.
|
||||
- Context gate passed on the same task/worktree/branch. Reread own task, entry/memory, positioning, current-state, teacher ADR/architecture, evidence/reflection/commitment references and all peer task scopes. The accepted product simplification supersedes stale active-component documentation; no canonical edits here.
|
||||
- Current trial PID 27713 still uses the hover checkout’s Main but its Renderer was independently updated to committed manual-refresh source 4f6bda4. Preserve this existing trial feature by merging that commit into this task; resolve the one consultation-state conflict with shared catalog state and no retired focus state. Do not import the unrelated in-progress Alice policy branch or change main.
|
||||
- Plan: validate the combined teacher/refresh paths, build the combined source, create an ignored background-launch wrapper, gracefully stop only the exact temporary-app PID and relaunch the same bundle/profile/port; verify loaded build and startup without focus. Installed production application is outside scope.
|
||||
- Same user-data retains persisted project/history and consultation drafts. Unpackaged authentication and operation drafts are memory-owned; do not claim a restart guarantees persistence of data the product does not save.
|
||||
|
||||
|
||||
### Restart Outcome
|
||||
|
||||
- Merged committed manual-refresh source 4f6bda4 into this feature branch as 9adab45, retaining cleanup source 998796d. Independent review confirms catalog refresh/current topic version/drafts and reply-only UI all remain; the sole conflict was resolved without restoring retired focus state.
|
||||
- Combined validation passed: typecheck, 112 teacher UI/companion/chat tests, changed-file ESLint, Renderer/Main/Preload/utility build and whitespace checks. No new backend logic changed after the previously recorded full regression run.
|
||||
- Sent SIGTERM only to verified trial PID 27713; its normal app.quit cleanup completed and port 54599 was released. Relaunched the exact existing trial bundle with open -g -j and an ignored wrapper for this checkout. New PID 36109 serves 54599; OPTIONS /api/app/runtime-info returned 204.
|
||||
- Runtime source/build is 9adab45, Renderer index-Dn2S79es.js loaded from this checkout, document complete and React mounted. Startup guard blocked one show and retained a hidden, unfocused window until user activation. A 12-second NSWorkspace monitor recorded trialFocused=false and unchanged foreground PID 409. Installed production PID 23486 remains untouched.
|
||||
- Preserved the same trial user-data directory. Updated only local trial launch metadata after backing up prior descriptors. No cloud configuration publication, deliberate model request, history seeding or UI activation. This checkout must remain available while the trial uses its build.
|
||||
- Task-aware drift checker now flags the imported peer task record 20260928-agent-refresh-a6d109b3 relative to the original task base. It is a committed dependency imported by the authorized merge, verified byte-for-byte identical to 4f6bda4; no peer document was edited. Record this inherited-source diagnostic rather than claiming the checker passed after merge. Canonical project documents remain untouched.
|
||||
|
||||
|
||||
## Empty Composer Hint Follow-up
|
||||
|
||||
- User approved the first proposed interaction: show a lightweight “给我一点提示” action only when the consultation input is empty, hide it when typing and remove the fixed “我也说不清,你带我看看” link below replies. Update the existing trial without desktop focus changes.
|
||||
- Same-task ownership resumed and verified; rechecked task/entry and peer scopes. The protocol-boundary peer is complete but unmerged and not live in this trial; preserve its separate prompt-policy decisions for its designated integration task, do not change backend policy as part of this UI request. Existing manual refresh is already included.
|
||||
- Plan: modify only the composer entry and fixed follow-up link, preserve true generated cards/free input/retries, add focused UI and browser checks, build and update trial Renderer while retaining Main and persisted data where possible. No cloud publication or deliberate model test request.
|
||||
|
||||
### Hint Implementation And Verification
|
||||
|
||||
- Replaced the filled “帮我看看” pill with a transparent “给我一点提示” text action in the empty composer. Typing hides it; clearing or whitespace restores it. A fixed minimum action-row height and left flex slot retain the send button’s position. Removed only the client-added “我也说不清,你带我看看” footer; identical text genuinely returned by the Agent still renders and sends as an ordinary generated reply.
|
||||
- Preserved quick replies, free input, references/drafts, failure/cancel/interruption retries, and one-click request behavior. When an old unconfirmed suggestions payload still says “帮我看看”, retry now reuses the complete original payload and request ID; ordinary questions and already-confirmed requests cannot reuse it. Old guided-help intent remains readable for history compatibility; no backend/cloud policy changed.
|
||||
- Verification passed: 59 UI unit tests (including five legacy pending-payload cases), 14 headless Chrome layout tests at 319/508px, typecheck, full lint followed by final changed-file lint, and production Renderer/Main/Preload/utility compile. Legacy regressions failed before the compatibility fix and passed afterward. Updated shared Electron E2E assertions but did not launch a native test application. No real model request was made for verification.
|
||||
- Built with `corepack pnpm run build:vite --emptyOutDir false` so the live Renderer can keep loading its old hashed assets until the deliberate refresh. Saved previous index and bootstrap/launch descriptors locally outside Git; current Main is retained for the pending Renderer update.
|
||||
|
||||
### Hint Trial Refresh Outcome
|
||||
|
||||
- Implemented UI is committed as 73331e6; refreshed only the existing trial Renderer to `index-IW_wuxZ1.js`. Main PID 36109 and Host API 54599 remain running from the earlier 9adab45 launch. No native app restart, production application change, cloud publication, merge or push. Local launch metadata now records both running Main and Renderer versions, and the next-launch wrapper points to the current build.
|
||||
- Preserved state only in Main memory during refresh, with busy request/attachment/flight gates and temporary show/focus guards. Did not read or copy auth tokens or all localStorage. After refresh, the current authenticated account matched the pre-refresh account, and project/conversation/route, operation/provisional drafts, composer contents and persisted consultation drafts matched. Both visible composers were empty; no claim of a live nonempty draft scenario is needed beyond the automated regressions.
|
||||
- Verified actual DOM has the new transparent 13px hint, no old fixed footer element, mounted app and current script hash. Read-only composer screenshot inspected at the local trial `hint-preview.png`; it matches the intended light text interaction. 12-second foreground monitor recorded trialFocused=false with unchanged foreground PID 19791. Main focus calls were guarded and none occurred.
|
||||
- Temporary inspector and Main-memory backup removed after verification. Runtime metadata/verification/screenshots remain local and ignored/outside Git. The managed checkout must remain available while this temporary app uses its compiled files.
|
||||
- Project-doc structure and whitespace checks pass. Task-aware drift still reports only the unchanged imported manual-refresh task record from the authorized earlier merge; reconfirmed no difference against 4f6bda4. No canonical or peer task document was edited by this UI follow-up.
|
||||
|
||||
## Playful Retry Follow-up
|
||||
|
||||
- User requests the retry button label “继续看看👀” and a more playful appearance; continue the same temporary-app preview without taking desktop focus.
|
||||
- Project Context Loaded: same feature task/branch/worktree/base identity above, registry ownership resumed and verified. Reread entry, active task and all peer Scope/Intent/Promotion sections; reuse already-read unchanged positioning, integrated snapshot, teacher decisions, architecture/domain, evidence/reflection and commitment context. Makelore remains a single light creation workspace; scope is only the existing failed/cancelled/interrupted suggestion retry affordance. Separate protocol-policy work stays isolated; old component documents are historical and superseded by this task’s accepted removal. No new semantic conflict. Gate Passed.
|
||||
- Plan: change label and scoped button CSS to a warm rounded sticker with a small pressed shadow, retaining keyboard/disabled/reduced-motion support; update existing retry tests, inspect a headless screenshot, build and refresh only the trial Renderer with the existing state-preservation method. User-requested emoji overrides the design skill’s generic preference against emoji icons.
|
||||
|
||||
- Implemented exact label “继续看看👀” with a cream-yellow 44px minimum-height sticker button, asymmetrical rounded corners, warm outline and shallow bottom shadow. Hover warms the fill; press lowers the shadow. Disabled and keyboard focus behavior remain, and reduced-motion disables transform/transition. No request or retry behavior changed.
|
||||
- Passed: 59 existing UI tests updated for the new label, 15 headless layout checks including failed/cancelled retry at 319px with draft preservation, typecheck, full lint, production build and whitespace checks. Inspected the failed-state screenshot; the button fits the narrow panel without clipping. Tests use fixtures only.
|
||||
|
||||
- Trial updated from committed cb48f60 to Renderer `index-D5o0Sba7.js`; running Main PID 36109/54599 and its 9adab45 code remain. Initial snapshot correctly refused while a teacher request was running; waited for completion before the state-preserving Renderer refresh. Existing successful reply is retained, without fabricating a failed live request to demonstrate retry. The new retry CSS is loaded; actual failed/cancelled appearance was verified in the headless fixture.
|
||||
- Verified same login/account/project/conversation/route, operation drafts, composer values and all persisted consultation draft text/references/pending payloads. One persisted absent pending field normalizes to null on mount; semantic comparison confirms no draft content or request identity was lost. Runtime verification contains only boolean/style/build metadata, no draft bodies or credentials. Temporary Main-memory backup and inspector removed.
|
||||
- Foreground monitor: trialFocused=false, unchanged foreground PID 88503. No show/focus calls were needed. Local trial metadata and next-launch bootstrap updated; production app untouched. No cloud publication, deliberate model test request, main merge or push.
|
||||
- Documentation structure and whitespace checks pass; the task-aware drift diagnostic remains limited to the unchanged imported manual-refresh task record described above, reconfirmed identical to 4f6bda4.
|
||||
|
||||
## Visible Hint Clarification
|
||||
|
||||
- User could not see the prior rename. Read-only runtime inspection confirmed the new build was loaded but no failed/cancelled request was currently displayed; the visible empty-composer entry still said “给我一点提示”. Explained the distinction and user explicitly confirmed to rename/style the composer entry too.
|
||||
- Same task identity/ownership resumed and verified; reuse this follow-up's loaded project/peer context with no new conflict. User clarification supersedes the earlier preference for a transparent text hint. Plan: share the warm sticker styling between hint and retry, send the matching new label through the existing suggestions intent, preserve empty/type/clear behavior and legacy pending-payload reuse. Increase the reserved action-row height to 44px so the send control remains still. Update existing tests and preview with a background Renderer refresh. No backend or cloud-policy change.
|
||||
|
||||
- Implemented shared hint/retry sticker styling and exact “继续看看👀” composer label/payload. The hint still hides on nonempty input; reserved 44px action height keeps the send button fixed. Existing request identity reuse covers both former labels (“帮我看看” and “给我一点提示”), without changing saved history.
|
||||
- Verification passed: typecheck, full lint plus final test-file lint, production build, 59 UI tests and 15 headless browser checks. Existing tests distinguish the two same-label controls by composer/reply location. Screenshots at 319/508px show the visible empty-composer button and confirm no clipping or send-button movement. Shared native E2E assertions updated without launching a native test app.
|
||||
|
||||
- Refreshed existing trial Renderer from committed 784fa8c to `index-DLBsnWbW.js`. Main PID 36109 and profile retained. Final DOM confirms visible composer hint text “继续看看👀” with `rgb(255, 242, 201)` background; captured and inspected the actual empty-composer screenshot `visible-hint-preview.png` in the local trial root. Login/account/project/draft/input/route checks passed; no generated conversation content or requests were inserted for demonstration.
|
||||
- Window/panel/selection state changed during the live verification: the consultation panel was closed at snapshot and open at final capture, and the selection equality check was false. Preserved current interaction without a second forced selection restore; do not claim exact conversation/window state remained unchanged. The foreground monitor already observed the trial as its sole foreground application; refresh invoked no show/focus calls. Final capture was taken with the window unfocused.
|
||||
- Temporary backup memory and inspector removed; local launch/build metadata updated. No cloud publication, Main restart, main merge or push. Final documentation drift has only the previously recorded unchanged imported task document diagnostic.
|
||||
|
||||
## Embedded Work Preview Header Follow-up
|
||||
|
||||
- User requests removal of the pictured horizontal “作品预览” title/icon/close row. Continue the current temporary workspace preview without taking desktop focus.
|
||||
- Same feature ownership resumed and verified. Reused unchanged previously loaded project context; reread own task/entry and newly active welcome/truncation/role-review task records. Existing peer scopes remain unchanged; no work-preview overlap or unresolved product decision. Gate Passed. This scoped presentation change preserves the shared browser's lifecycle, navigation, recovery, native viewport and separate developer-browser UI.
|
||||
- Plan: hide the redundant header only in embedded work preview, retain an accessible aside name and the existing top-level operation/work tabs; keep address navigation and standalone browser close controls. Update existing unit/native E2E assertions, compile, and refresh only the temporary Renderer. Main/remote branches and installed production application remain unchanged.
|
||||
|
||||
- Implemented conditional removal of the entire embedded title row (globe icon, “作品预览”, close button); the work-preview aside remains accessibly named. Address/back/forward/reload controls and the native viewport remain, while the standalone developer-browser header and close action are unchanged.
|
||||
- Passed: 44 AgentBrowserPanel/CodingChatPanel unit tests, typecheck, full lint plus scoped test lint, full production compile and whitespace check. Updated shared Electron work-tab assertions without launching a native test instance.
|
||||
|
||||
- Code committed as 064096e and new build prepared. The safe refresh snapshot detected an operation run in progress and refused to reload. Applied a narrowly scoped live stylesheet to the existing Renderer instead: only the embedded preview's old first div/title row is hidden, including after it mounts again. Current work tab was closed, so no live header screenshot or mounted-viewport assertion is claimed. The new compiled component permanently omits the row when next loaded. No work-tab switch, browser startup, model request, page reload or application restart was performed.
|
||||
- Main PID 36109 and running Renderer 784fa8c remain; local descriptors explicitly distinguish the 064096e visual overlay/next build from the currently loaded script. Main focus/visibility stayed unchanged and no focus action was called. Temporary inspector closed; no draft, request, account, history or operation state was copied or reset. Installed production app and remote main remain unchanged.
|
||||
- Final documentation structure/whitespace checks pass; task-aware drift retains only the previously documented unchanged imported manual-refresh task record diagnostic.
|
||||
@@ -0,0 +1,50 @@
|
||||
# Task: Explain the first-click teacher welcome bubble
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20260928-teacher-welcome-diagnosis-4fb809c2
|
||||
- Mode: Feature
|
||||
- Branch: codex/20260928-teacher-welcome-diagnosis-4fb809c2-teacher-welcome-diagnosis
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20260928-teacher-welcome-diagnosis-4fb809c2
|
||||
- Base commit: 4495345fb0a9ea1abef8e603629ce9b51d73eb05
|
||||
- Owner: codex
|
||||
- Status: Ready for Integration
|
||||
|
||||
## Scope
|
||||
|
||||
- Diagnose and fix the first-click teacher welcome bubble at baseline 4495345. Entering consultation consumes the static welcome and preserves true unread proactive messages.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- User first asked why the screenshot bubble appears, then explicitly requested the proposed fix.
|
||||
- Concurrent and Planning Gates passed in this owned checkout; task identity, branch, absolute path and base verified on resume. Relevant project memory and peer scopes reviewed. Adjacent cleanup and truncation tasks remain isolated.
|
||||
- Preserve published greeting content inside the consultation panel, account/project scope, real unread check-ins, cloud configuration, model requests and conversation state.
|
||||
- No main merge, live trial restart, cloud publication or paid model request in this task.
|
||||
|
||||
## Outcome
|
||||
|
||||
- Cause: welcome_message displayed after config load until explicit dismissal; avatar entry only opened the panel, leaving the welcome bubble visible and changing its CTA to 看看智能体说的.
|
||||
- The hook now hides static welcome immediately when consultation is open, then records welcome-dismissed for the current account/project. This also handles entering before async config completes, closing before config completes, same-agent selection and reload.
|
||||
- The effect runs after scope initialization and changes only welcomeDismissed. Real invitations and seen receipts are untouched; a real check-in still requires explicit viewing/dismissal.
|
||||
- Updated current README and focused unit/Electron coverage. Independent review found no actionable issue.
|
||||
|
||||
## Verification
|
||||
|
||||
- New unit tests first reproduced three failures on the prior source; unread check-in preservation already passed.
|
||||
- corepack pnpm 10.33.4: teacher-companion.test.tsx, 33 passed.
|
||||
- pnpm run typecheck, scoped ESLint, pnpm run build:vite and git diff --check passed.
|
||||
- Electron welcome test passed: avatar entry, close/reopen, renderer reload, panel greeting retained, no model/topic POST.
|
||||
- Electron proactive test passed: entry/close does not consume unread message; explicit CTA consumes it, original focus/draft/layout/timer assertions retained. Initial modified test had an invalid remount-focus expectation when opening an already-open panel; restored its original close-then-CTA sequence and reran successfully. Final total: 2 relevant Electron scenarios passed.
|
||||
- Verification uses the existing mocked Host fixture with isolated test profiles; no real provider or trial application updated.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- Integrate this small source change with the current main/trial version through its owning integration task. Build outputs, test profiles and dependency symlink are not committed.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- Target: canonical classroom interaction/current-state docs during an integration task.
|
||||
- Proposal: entering consultation consumes and persists the static welcome per account/project; actual unread proactive messages remain until explicitly viewed/dismissed.
|
||||
- Evidence: explicit user request, hook change, 33 unit tests and two Electron scenarios.
|
||||
- Future impact: prevents redundant first-entry invitations without hiding real messages.
|
||||
- Semantic conflicts: supersedes the older welcome-until-manual-dismissal behavior only. No further human confirmation needed for this accepted behavior; canonical promotion remains integration-only.
|
||||
@@ -5,12 +5,16 @@
|
||||
- 每个新项目创建内部默认 Agent,普通界面无 Agent 创建步骤或分组列。defaultAgentId 选取已存默认、置顶或首个可用 Agent;历史 Agent 与会话绑定不重写,不重新启用停用/归档 Agent。
|
||||
- 项目直接显示会话并保留归档、改名、未读、运行状态;打开项目不创建空会话。首次发送或显式新建才创建。项目设置编辑默认配置,历史会话仍能定位原绑定配置。
|
||||
- 每个账号/项目/稳定下发智能体ID只有一个可见聊天,不同项目隔离历史、草稿、已读及模型上下文。每个问题使用接受时的当前发布版本,并冻结项目、Pi来源及公开消息;同项目相同作用域复用内部线程,来源或版本变化只开启内部执行段。切换项目恢复独立聊天,不复用其他项目checkpoint或历史。Main三个只读工具仍限本轮项目,允许 `.makelore/project.json`,无本机写入或命令;每次读取与续接检查绑定及取消状态。完整工程不全量上传。
|
||||
- 同requestId相同输入读取当前项目聊天的已有结果(包括更早历史页),不同输入冲突;同一账号/项目/智能体一次接受一轮人工问答,各项目接受锁独立。SSE、取消、保存、讨论和已读均绑定项目,其他项目不能取消本轮。重启将未完成问题标为中断,账号退出中止。带回回答核对原项目/Pi来源,只追加草稿且不自动发送;已归档来源必须先恢复。
|
||||
- 同requestId相同输入读取当前项目聊天的已有结果(包括更早历史页),不同输入冲突;同一账号/项目/智能体一次接受一轮人工问答,各项目接受锁独立。SSE、取消、保存和已读均绑定项目,其他项目不能取消本轮。重启将未完成问题标为中断,账号退出中止。带回回答核对原项目/Pi来源,只追加草稿且不自动发送;已归档来源必须先恢复。
|
||||
- 运营只管理下发、同步、默认与启停,无重复提示词编辑器或试聊。老师聊天模型由学生账号付费,个人 Agents 保持创建者付费。正文、历史及带回草稿只接收云端主线程文本;忽略子线程文本仍推进游标。
|
||||
- 客户端不内置老师/朋友角色:名称、头像、简介、欢迎语、推荐问题及人格由服务端发布定义决定,通用讨论协议不定义人格。任意名称的下发智能体都遵守同一只读工具边界;不再按角色限制项目读取。
|
||||
- 顶栏点击直接恢复当前项目的唯一聊天,没有新话题加号和话题下拉框。历史分页,已读由Main持久保存;草稿与阅读缓存按账号/项目/智能体隔离,引用仍绑定原项目/Pi,迟到响应不得进入另一项目。旧全局聊天依据每轮可证明的项目归属分入对应聊天,映射已读并开启新云端执行段;保留原文件与请求身份,不明归属仅留原档案。旧全局草稿只导入记录的项目,优先于更早话题草稿且保留原值。更早项目话题仍按当前账号、config_id与项目/话题/请求来源去重导入,不按名称猜归属。历史讨论状态仍按项目保存,但对话栏不再渲染讨论组件、邀请、焦点或操作按钮;新问题与引导求助不再请求组件输出,旧未确认请求重试保持原身份及完整输入。旧Renderer定时跟进不再向现代聊天派发;独立主动观察后续也须投递到对应项目的同一聊天。
|
||||
- 客户端不内置老师/朋友角色:名称、头像、简介、欢迎语、推荐问题及人格由服务端发布定义决定,回复格式协议不定义人格。任意名称的下发智能体都遵守同一只读工具边界;不再按角色限制项目读取。
|
||||
- 顶栏点击直接恢复当前项目的唯一聊天,没有新话题加号和话题下拉框。历史分页,已读由Main持久保存;草稿与阅读缓存按账号/项目/智能体隔离,引用仍绑定原项目/Pi,迟到响应不得进入另一项目。旧全局聊天依据每轮可证明的项目归属分入对应聊天,映射已读并开启新云端执行段;保留原文件与请求身份,不明归属仅留原档案。旧全局草稿只导入记录的项目,优先于更早话题草稿且保留原值。更早项目话题仍按当前账号、config_id与项目/话题/请求来源去重导入,不按名称猜归属。历史组件状态仅保留在原档案,既不渲染,也不主动导入或发送给模型。旧未确认请求重试保持原请求身份、问题、引用及来源,去除退役组件字段。旧Renderer定时跟进不再向现代聊天派发;独立主动观察后续也须投递到对应项目的同一聊天。
|
||||
- 输入预算区分近似模型 Token 与精确云端 JSON 字节,编译和提交使用同一完整请求计量。保留当前问题、明确引用和固定指令,按需缩减来源节选;固定配置/讨论超限不误报为用户短问题过长,不静默提升预算或迁移旧话题。
|
||||
|
||||
- 新咨询由 Main 统一声明 `{reply, quickReplies}`,正文和 0–3 条可选快捷回复按所选智能体云端配置生成,客户端只提供入口事实、上下文与输出格式。超额新卡片保留正文及原文诊断,不截断或展示;历史卡片数量不改写。旧组件状态和快照作为不透明档案保留,不恢复交互、主动导入或进入模型上下文,旧组件修改路由已移除。
|
||||
- 完整正文可从保留原文中在本地恢复;无法确认完整时显示缺失提示,由用户明确点击重新回答,保持原问题、引用和项目/Pi 来源,保留现有草稿,采用当前发布版本。被动恢复不调用模型或改写已完成原始轮文件;不完整回答和未解析原文不进入后续模型上下文。
|
||||
- 进入咨询消费静态欢迎语并按账号/项目保存,真实未读消息不随打开自动已读;空输入框的“继续看看👀”仅在点击时调用模型。
|
||||
|
||||
依据:[老师决定](../10-decisions/ADR-2026-09-22-coding-teacher.md)及 [ADR-008](../10-decisions/adr-008-interactive-ai-app-scaffold.md)。
|
||||
|
||||
## Permanent Token Points
|
||||
|
||||
Reference in New Issue
Block a user