Improve knowledge workspace and chat file import
This commit is contained in:
1 parent
23ddce11da
commit
c634425cc6
11 files changed
+1078
-118
No files matched your search
@@ -0,0 +1,74 @@
|
||||
# Task: Implement split knowledge workspace and multi-file chat import then update trial
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20261013-knowledge-workspace-5ac9e2d
|
||||
- Mode: Feature
|
||||
- Branch: codex/20261013-knowledge-workspace-5ac9e2d-knowledge-workspace
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20261013-knowledge-workspace-5ac9e2d
|
||||
- Base commit: 23ddce11da5c4c7aa31af81213a5aafd474cdad0
|
||||
- Owner: codex
|
||||
- Status: Ready for Integration
|
||||
|
||||
## Scope
|
||||
|
||||
- Implement the user-approved knowledge workspace: own-file management on the left, multi-select MakeLore/my knowledge on the right, and a clearer multi-file conversation attachment picker. Verify source changes only; the latest user correction explicitly postpones any trial update.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- Current user authorization covers implementation; the latest correction explicitly says not to update the temporary application after changes. Keep current Main/login/profile, prior accepted Agent/chat UI, resource ownership, operation recovery, saved/apply semantics, primary dirty teacher record and remote main. No desktop focus changes, no backend schema/protocol change or generated-file import. Do not prepare or activate a new trial payload, refresh/restart the application, or change its pointer. Existing Main/process/payloads must remain intact.
|
||||
|
||||
## Outcome
|
||||
|
||||
- Implemented stable left own-file management and right grouped multi-select knowledge panels. Small windows stack in the same order; existing draft/save/apply, ownership and selected-library semantics are preserved.
|
||||
- Replaced the two import dropdowns with a dialog: searchable dated chats with agent names, searchable file metadata, cross-chat selection, explicit target, per-file results and original-operation retry. Confirmed receipts are not replayed; actual ownership loss preserves pending intent while hiding the portal.
|
||||
- Added read-only catalog refresh and explicit two-step local retry abandonment, retaining server files; in-flight requests cannot be abandoned. Unsupported legacy formats and oversized attachments cannot be selected.
|
||||
- README reflects current branch behavior. Product source, tests and task record are isolated on this managed feature branch. No Main/shared/backend/API contract changes.
|
||||
- The latest user correction overrides the initial trial-update request: no temporary application refresh, restart, new deployment payload or pointer change was performed. Retain this checkout for later review/integration/update instructions.
|
||||
|
||||
## Verification
|
||||
|
||||
- Pinned corepack pnpm 10.33.4; focused existing knowledge/catalog/configuration tests: 52/52 passed. New import and adapted status tests: 27/27 passed. No real cloud mutation, native picker or model request was performed.
|
||||
- Final Renderer typecheck, scoped ESLint, production build:vite and git diff --check passed. Required project docs and own-task drift checks passed.
|
||||
- Final headless UI fixture: 9/9 passed in 26.6s with exit 0 using the repository-pinned Playwright 1.59 Chromium 1217 Headless Shell; no system browser channel. Covered multi-select/save/reopen, shared read-only access, own uploads, cross-chat selection, original-ID failure retry, reachable footer and explicit abandonment without deletion/replay at 1440px and 375px. The static Vite fixture, HTTP server, temporary directory, esbuild service and test browser all shut down normally; no owned test processes or temporary fixture directories remain. System Chrome had previously passed all assertions but hung on Browser.close because its stdout/stderr pipes stayed open after exit; the pinned test browser completed the same suite normally.
|
||||
- Inspected generated 1440px and 375px screenshots. Desktop dialog width and layered panels, small-window stacking, scrollable content and reachable footer verified. Preview evidence is under /Users/chillishark/Makelore 麦洛/.codex-evidence/knowledge-workspace-20261013-5ac9e2d.
|
||||
- Independent read-only review passed for pending intent, authorized in-flight completion, stale scope isolation, confirmed import receipts and two-step local abandonment.
|
||||
- Final read-only runtime baseline checks passed: PID 7459, Main/Renderer bytes, resources, dependencies, bootstrap, rollback copies, source trees and current renderer be53e44dcf444c9b62c3107b04f079e8ffeac450 are unchanged; runtime pointer SHA256 stays 0a01f8af424b0547c00219564d3f0bb56d0f31eaee40453c52c46ab1601bbacf. Primary stays 10da39341ead9e3db17ea4395d66181f6fe4433d; teacher record SHA256 remains 734f4de9ee0c6308b10ffa614c7678a2814f81d3b1e6d46135f495dbadeac9d3. Remote main advanced externally to bf39f4071fa957704521542e1909d53b0452c5a2: the prior full release verifier now rejects its old remote-equality condition after all runtime checks pass. No remote or primary code was changed by this task; later integration must reconcile the new remote head.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- The user explicitly deferred temporary application update. Await a later instruction before integration/deployment; retain the feature checkout and preview evidence.
|
||||
- Test fixtures establish UI behavior; this task does not include a live cloud import/indexing smoke test.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- None recorded.
|
||||
|
||||
## Project Context Loaded
|
||||
|
||||
Task context:
|
||||
- Identity above matches successful bundled start, feature ownership and task reservation.
|
||||
- 26 other owners: peer Scope/Intent/Promotion records reread read-only. Teacher consensus occupies primary main; preserve it. Older child-language task has undefined scope but no dependency here. No concrete semantic conflict; current human instruction authorizes this personal knowledge interaction change.
|
||||
|
||||
Read:
|
||||
- AGENTS.md, new own record, read-before-planning/planning-gate and same-base context retained from the immediately preceding knowledge import review.
|
||||
- Unchanged positioning, integrated state, decisions, personal cloud Agents ADR, system/module/data flow, domain/success criteria, evidence/reflection/commitment context, README and review findings at 23ddce11. Canonical memory remains read-only.
|
||||
- Design skill and design-system/React guidance; use existing Makelore cream/blue/lavender and typography rather than generic search palette recommendations.
|
||||
- Latest runtime durable verifier and pointer: Main7459/Host62864, committed renderer be53e44, full prior rollback/snapshot preserved.
|
||||
|
||||
Relevant understanding:
|
||||
- Goal: own documents can be indexed and explicitly selected alongside readable shared knowledge for personal Agents.
|
||||
- Scope: left upload/manage, right grouped multi-select, source/file/target-aware picker, batch independent file operation IDs and error recovery.
|
||||
- Decisions: selected knowledge alters draft only until explicit save/apply; upload/import stores documents immediately and actual indexing/chunks determine readiness; no payer-derived access.
|
||||
- Modules: CloudKnowledgeSelector, CloudKnowledge, CloudKnowledgeDocuments/new import component, scoped Agent CSS and focused unit/headless UI tests. Main services/DTO remain unchanged.
|
||||
- Unknowns: current runtime pointer/hash/process will be checked unchanged at completion; no real cloud write/model smoke is required for this UI update. Backend generated delivery import remains outside this task.
|
||||
|
||||
Gate result:
|
||||
- Passed before implementation plan.
|
||||
|
||||
## Plan
|
||||
|
||||
1. Split knowledge into stable left upload/manage and right selection panels; keep loading/permission/pending safeguards and responsive stack.
|
||||
2. Replace chat import dropdowns with searchable chat/file picker, supported-document selection, independent per-file results and same-operation retry.
|
||||
3. Run focused behavior tests, Renderer type checks, scoped lint, production build and headless size/interaction verification.
|
||||
4. Commit documented result locally; verify current runtime pointer/files/process unchanged. Trial update is deferred pending a later user instruction.
|
||||
Reference in new issue
Block a user