fix: improve Coding sidebar text and remove gallery footer
This commit is contained in:
1 parent
c812eb4c07
commit
b5f31c1259
8 files changed
+72
-40
No files matched your search
@@ -12,18 +12,18 @@
|
||||
|
||||
## Scope
|
||||
|
||||
- Read-only comparison of Coding sidebar text with Agents and Canvas, then propose a clearer text hierarchy. Implementation requires the user's later approval.
|
||||
- Implement the approved Coding sidebar text hierarchy and remove only its bottom Works Square button. Preserve Canvas/Agents navigation and the separate Code welcome gallery entry.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- User explicitly asks for a proposal first and forbids beginning product changes before approval. Preserve desktop focus, running trial, inputs, projects and conversations. No product edits, runtime update, model calls, merge/push or cleanup.
|
||||
- User explicitly approved the preceding proposal and additionally requested deletion of the Coding sidebar's bottom Works Square button. This supersedes the earlier source-edit hold and the former footer-placement direction only. Preserve desktop focus, running trial, inputs, projects/conversations, background tasks and other modules; no model calls, cloud writes, merge/push or cleanup.
|
||||
|
||||
## Outcome
|
||||
|
||||
- All three modules share the same bundled Inter/Source Han sans font stack. Agents main navigation and Canvas project entries use14px/600 dark text for normal clickable items; selected/hover states are differentiated primarily by background.
|
||||
- Coding project/create/gallery entries already use14px/600 dark navy. Its conversation titles and new-conversation action are12px/400 auxiliary blue-gray#64758a, with icons#7891af. The group header uses the same auxiliary gray. These styles explain the screenshot's weaker conversation-list hierarchy; no font replacement is needed.
|
||||
- Proposed Coding-only scope: conversation titles and new-conversation action14px/500/#26384d; group heading and collapse action#506176 while remaining a secondary hierarchy; conversation icons one shade darker. Retain existing14px/600 project entries, pale-blue surface, icon tiles, selected/hover backgrounds, layout and interactions. Scope any adjustment to Coding rather than changing global/shared Canvas tokens.
|
||||
- No product code or running application was changed. Proposal is complete; implementation remains awaiting human approval.
|
||||
- The initial proposal changed no product/application state. User subsequently approved implementation; the completed source-only result is recorded below. Running application remains unchanged.
|
||||
|
||||
## Verification
|
||||
|
||||
@@ -33,7 +33,7 @@
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- On approval, resume the same task and recheck the newest actual source/peer sidebar changes before applying the bounded Coding-only adjustment. Verify normal/selected/hover/disabled typography and layout in headless browser checks, then perform only separately authorized trial delivery.
|
||||
- Source is ready for a requested trial update/integration. Before delivery, recheck the actual runtime/source and peer changes, preserve all intervening features and guard account/input/running work/focus. No live delivery, merge/push or worktree cleanup was performed in this implementation turn.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
@@ -46,3 +46,17 @@
|
||||
- Official registry had78 owners including this task. Independent coordination review read77 peer records/231Scope, Intent and Promotion sections. All readable; Code-model-onboarding01e8cbed and old child-language6bf94d12 retain unknown placeholder scopes without a concrete dependency. No semantic blocker affects this read-only proposal.
|
||||
- Adjacent Code gallery/footer tasks retain palette/layout; wide Code redesigne4132a1e was explicitly withdrawn and is not reused. Canvas's later a72d49e6 task changes its surface to pale yellow, superseding the older lavender state; no Canvas background proposal is made here. Source comparison uses the declared actual trial436f7ba snapshot and adopts no peer uncommitted product.
|
||||
- Likely approved-edit paths would be CodingProjectConversations.tsx and Coding-scoped selectors in classroom-workspace.css. No shared global color/font change or backend/API alteration is justified. Planning Gate: Passed.
|
||||
|
||||
## Approved Implementation Resume
|
||||
|
||||
- Official check/start/status resumed the exact same feature ownership, branch/worktree/base; registry now planning. Current trial source remains436f7ba, identical to the proposal baseline; all product files are clean. Prior project/design/context is reused. The78-owner registry is unchanged;77 peer scope sets were reviewed in the preceding turn, and the relevant sidebar/gallery/Canvas scopes were reread on resume. No semantic conflict: this explicit user instruction supersedes prior Code footer retention. Canvas's separate footer stays.
|
||||
- Planning Gate: Passed. Plan: isolate Code-only normal/selected/hover/disabled text rules; remove the Code footer via the shared Sidebar module condition; update existing navigation/layout regression assertions and README; run focused tests/typecheck/scoped lint/production build and headless geometry checks. Commit the bounded source and record actual verification. A live delivery, if undertaken as part of this temporary-app workflow, must bind the then-current actual source and preserve account/input/running work/focus without an unsafe refresh.
|
||||
|
||||
## Completed Approved Source Changes
|
||||
|
||||
- CodingProjectConversations uses14px/500 for new-conversation and normal conversation titles. Code-scoped classroom CSS promotes actions/normal titles to#26384d, group headings and conversation icons to#506176. Existing selected text#304f75, background/border treatments, project14px/600, font stack, action handlers and conversation identity remain. Disabled new-conversation action keeps reduced opacity and no enabled hover background.
|
||||
- Shared Sidebar renders the bottom community footer for Canvas only. Code chat/settings/plugin workbars no longer contain that bottom Works Square button; the separate Code welcome entry and legacy nonworkspace upper entry remain. A Code-only account-footer padding/border rule preserves the former adjacent-footer reset after removal, without changing Canvas/Agents styling or shifting the account button.
|
||||
- Updated README and existing navigation/first-chat E2E assertions for removed footer, preserved welcome link and approved typography. Focused Sidebar regressions cover Code footer absence/account presence, Canvas footer retention and the legacy upper entry. Independent source review found no runtime defect or cross-module style leakage; a remaining README footer statement was corrected before completion.
|
||||
-23/23 related tests across Sidebar project actions, Image Workspace Sidebar and Main-layout peek passed; the peer's5Sidebar tests are included in23, not extra distinct coverage. Typecheck, changed TS/TSX/spec ESLint, diff and production Vite/Main/Preload/utility build passed. CSS is outside ESLint's configured matching files; browser checks provide its verification. The intermediate log redirection failed because the ignored stage directory was not yet present; directory creation and the final build completed successfully.
|
||||
- Headless QA passed viewport640/1366 × sidebar256/320, with six Code normal/selected/hover/disabled states and Canvas/Agents baseline comparisons (12 module layout combinations, each with baseline/current evidence). Real CodingProjectConversations, AccountMenuTrigger and CommunityLink React SSR use synthetic stores; Sidebar project/Agents markup reproduces real classes/data attributes. Source CSS/bundled fonts are used; no actual app/user data/network access. Long titles truncate correctly; no overflow. Code account button geometry is exactly unchanged, Canvas/Agents computed styles and geometry match436f7ba baseline. Source CSS SHA2561580c7062a3434c1805787efa3270dbb82d9be1546cfd8518abe8a9bae878ddd. Root viewed code-1366-256.png; peer reviewed compact Code and Canvas/Agents PNGs. Evidence: /Users/chillishark/Makelore 麦洛/.trial-runtime/coding-sidebar-text-20261014-9fe4278d/qa/geometry.json.
|
||||
- Native visible Electron E2E was not launched to preserve desktop focus; updated specs remain future full-native coverage, while the focused units/headless geometry verify this bounded UI change. Runtime Main/Renderer, login, real projects/conversations/inputs and services were not touched. Implementation source is complete; no temporary-app update, main merge/push or cleanup is claimed.
|
||||
Reference in new issue
Block a user