fix: close and recreate macOS windows safely

electron/main/ipc/conversation-link-context-menu.ts

@@ -7,6 +7,7 @@ import {
   shell,
   type MenuItemConstructorOptions,
 } from 'electron';
+import { resolveMainWindow, type MainWindowProvider } from '../window-provider';
 
 const MAX_LINK_LENGTH = 4_096;
 const LOCAL_WEB_FILE_PATTERN = /\.(?:html?|xhtml)$/i;
@@ -117,7 +118,7 @@ export function createConversationLinkMenuTemplate(
   throw new Error('Unsupported link context menu request');
 }
 
-export function registerConversationLinkContextMenuHandler(mainWindow: BrowserWindow): void {
+export function registerConversationLinkContextMenuHandler(mainWindow: MainWindowProvider): void {
   ipcMain.handle('shell:showLinkContextMenu', (event, request: ConversationLinkContextMenuRequest) => {
     const template = createConversationLinkMenuTemplate(request, {
       platform: process.platform,
@@ -128,7 +129,7 @@ export function registerConversationLinkContextMenuHandler(mainWindow: BrowserWi
       writeText: (value) => clipboard.writeText(value),
     });
     const menu = Menu.buildFromTemplate(template);
-    const ownerWindow = BrowserWindow.fromWebContents(event.sender) ?? mainWindow;
-    menu.popup({ window: ownerWindow });
+    const ownerWindow = BrowserWindow.fromWebContents(event.sender) ?? resolveMainWindow(mainWindow);
+    menu.popup(ownerWindow ? { window: ownerWindow } : {});
   });
 }

electron/main/ipc/transcript-export.ts

@@ -1,5 +1,6 @@
 import { writeFile } from 'node:fs/promises';
-import { dialog, ipcMain, type BrowserWindow } from 'electron';
+import { BrowserWindow, dialog, ipcMain } from 'electron';
+import { resolveMainWindow, type MainWindowProvider } from '../window-provider';
 
 interface TranscriptSaveRequest {
   defaultPath?: unknown;
@@ -15,8 +16,8 @@ function safeDefaultPath(value: unknown): string {
   return fileName.toLowerCase().endsWith('.md') ? fileName : `${fileName}.md`;
 }
 
-export function registerTranscriptExportHandler(mainWindow: BrowserWindow): void {
-  ipcMain.handle('transcript:save', async (_event, request: TranscriptSaveRequest) => {
+export function registerTranscriptExportHandler(mainWindow: MainWindowProvider): void {
+  ipcMain.handle('transcript:save', async (event, request: TranscriptSaveRequest) => {
     if (typeof request?.markdown !== 'string') {
       throw new Error('Invalid transcript markdown');
     }
@@ -26,10 +27,15 @@ export function registerTranscriptExportHandler(mainWindow: BrowserWindow): void
 
     let selected: Electron.SaveDialogReturnValue;
     try {
-      selected = await dialog.showSaveDialog(mainWindow, {
+      const owner = (event?.sender && BrowserWindow.fromWebContents(event.sender))
+        || resolveMainWindow(mainWindow);
+      const options: Electron.SaveDialogOptions = {
         defaultPath: safeDefaultPath(request.defaultPath),
         filters: [{ name: 'Markdown', extensions: ['md'] }],
-      });
+      };
+      selected = owner
+        ? await dialog.showSaveDialog(owner, options)
+        : await dialog.showSaveDialog(options);
     } catch {
       throw new Error('Failed to save transcript');
     }