wangxuming/makelore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Record temporary app toolbar update verification

Browse Source
This commit is contained in:
鲨鱼辣椒
2026-09-30 12:36:20 +08:00
parent d787267055
commit 9f575e2c2f
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
.project-docs/30-worklog/tasks/20260930-preview-toolbar-tabs-56e98b2d.md
View File

@@ -16,11 +16,12 @@
## Intent And Constraints
- Keep the current navigation, browser/view lifecycle, URL editing, empty-work behavior, native viewport bounds, teacher clearance and student drafts. Show the toolbar only in the Work tab; retain standalone developer-browser layout. Use existing visual styles, fitting one row when space permits and wrapping cleanly on narrow panes. No live-app update, main merge or push is requested in this turn.
- Keep the current navigation, browser/view lifecycle, URL editing, empty-work behavior, native viewport bounds, teacher clearance and student drafts. Show the toolbar only in the Work tab; retain standalone developer-browser layout. Use existing visual styles, fitting one row when space permits and wrapping cleanly on narrow panes. The follow-up explicitly requests updating the temporary app; no main merge or push is requested.
## Outcome
- Embedded work previews render their existing navigation form through a portal into a stable slot beside the two workspace tabs. The form remains outside the tablist, retains existing handlers and address focus protection, and disappears when the Work tab is hidden. The old internal toolbar row is removed only when the external slot is available; standalone/fallback browsers remain unchanged. Responsive layout keeps all controls usable and wraps the address toolbar only when the pane is too narrow. README documents the new position.
- Updated the running temporary app on explicit follow-up authorization. Its latest composite renderer now includes this toolbar patch, with prior reference isolation and presentation changes preserved. No main-branch merge or remote push was performed.
## Verification
@@ -52,3 +53,11 @@
1. Add an optional embedded-toolbar target and a sibling slot on the tabs row; keep the existing form/navigation handlers and standalone fallback.
2. Scope styles to the workspace row, keep tab/button semantics separate, and prevent overflow in narrow panes.
3. Verify navigation/disabled states/tab lifecycle, real layout/native viewport behavior, relevant regressions, typecheck/lint/build; record and commit the isolated result.
## Temporary App Update
- User explicitly requested updating the temporary app after product commit `d787267`. Resumed this same task through official start/status; feature ownership, branch and base match. Previously loaded canonical context remains unchanged. Re-read own record, entry, memory index, positioning and relevant integrated/architecture context. Peer review found no semantic conflict: the new teacher-reference merge only updates main; the new Alice investigation targets the installed app. The merge peer was cleaned during review, making the initial owner snapshot stale, without a dependency on this renderer update. Gate: Passed.
- Actual temporary app is PID 32583 with its own `makelore-trial-tdq_nuah/user-data`. Its latest renderer is the composite `teacher-reference-70b4a183/source`, with served entry `index-mR-oHKNI.js`. Preserve its reference isolation, sidebar, height and prior presentation changes. The three product-file patch from `d787267` applies cleanly to that source. Stage/build a separate copy, compare manifests and served entry before publication, append assets and atomically replace only the renderer entry, then refresh and verify state. Keep Main, preload, user data, native window overlays and the installed app intact.
- Completed staging at `/var/folders/mx/ltbgwsks5_n8zllj69p_wbcw0000gn/T/makelore-trial-tdq_nuah/preview-toolbar-tabs-56e98b2d/source`. Verified only the three requested product files differ from the previous composite source. Composite typecheck, production build and all 16 existing browser-panel unit tests passed.
- Published renderer asset `index-nb2_203t.js` and route stylesheet `index-BC3KHUz-.css`; retained old assets and saved previous entry/manifests for rollback. Main PID stayed 32583. Restored the original Work tab after refresh. Live DOM measurements and captured toolbar image confirm a single complete address toolbar to the right of the tabs, vertically centered, outside the tablist, without overflow; native preview starts below the row.
- Route, selected conversation, inputs, operation/teacher drafts, teacher panel/turns, preview URL, sidebar state, window bounds and fullscreen were preserved. All 14 previously rendered operation messages remain unchanged and in order; hydration additionally loaded 8 earlier messages. No request was active and no message was sent. Released the temporary runtime lease (0 remain), restored background throttling and closed the debugging listener. Main/preload, window overlays and the installed app were not replaced. Evidence: `build-source.json`, `verification.json`, `cleanup.json`, logs and `live-toolbar.png` under the staging directory above. Both trial launch manifests point to the new renderer source and record `d787267` as an added overlay.