fix: close PI-090 review findings
This commit is contained in:
@@ -91,6 +91,17 @@
|
||||
exposed; project/user auto-discovery remains disabled.
|
||||
- Extended the real Pi and staged production-closure smoke to require all
|
||||
parent product tools while retaining the exact read-only child tool set.
|
||||
- Closed the planner's first review findings: dirty baselines now use one Git
|
||||
status plus lightweight file metadata instead of per-file Git diffs before
|
||||
prompt acceptance; a missing Git executable degrades to no-Git tracking;
|
||||
write/edit hooks from parent and coding child use a dedicated internal
|
||||
`changes.touched` ACK bridge; full diff/preview data stays Main-only; and
|
||||
untracked reads plus previews are both limited to 8 KiB while size/mtime
|
||||
detect equal-length changes beyond that window.
|
||||
- The packaged smoke now has two halves: a staged production-closure Pi
|
||||
process check and a controlled Electron-Node authenticated bridge check that
|
||||
actually executes browser status/screenshot attachment and game asset
|
||||
browse/review, rather than checking registrations only.
|
||||
- No Renderer or `/api/coding` route was added; PI-105/PI-130 remain the owners
|
||||
of Host API and UI consumption. `README.md` therefore still describes the
|
||||
unchanged current product cutover state and did not require an update here.
|
||||
@@ -101,17 +112,24 @@
|
||||
- `corepack pnpm run lint:check`: passed with the same six repository warnings
|
||||
and no errors (`ExecutionGraphCard.tsx`, `Home/index.tsx`, and
|
||||
`Makelore/index.tsx`; none are in this task's changed scope).
|
||||
- Focused PI-090/Pi projection/bridge/game suite: 10 files, 61 tests passed
|
||||
before the final boundary additions; subsequent focused runs covered 27 and
|
||||
9 tests respectively and passed.
|
||||
- `corepack pnpm test`: 203 files passed; 2224 tests passed, 2 skipped.
|
||||
- Final focused PI-090/Pi projection/bridge/game/resource suite: 12 files,
|
||||
71 tests passed. The planner's five minimal failure shapes are also covered
|
||||
by the 4-file 19-test tracker/bridge/runtime subset.
|
||||
- Final serial full suite
|
||||
(`corepack pnpm vitest run --maxWorkers=1 --no-file-parallelism`): 203 files,
|
||||
2226 tests passed, 2 skipped. Two preceding parallel full-suite runs each
|
||||
hit the repository's known Windows temporary-file `rename EPERM` in the
|
||||
unchanged Conversation store atomic write; the same file passed 1/1 in
|
||||
isolation before the serial full suite passed.
|
||||
- `corepack pnpm run build:vite`: passed for Renderer, Electron Main, Preload,
|
||||
and release utility outputs; existing chunk-size/dynamic-import warnings
|
||||
remain non-blocking.
|
||||
- `corepack pnpm run test:electron:windows`: 1 file, 3 tests passed.
|
||||
- `corepack pnpm run test:pi-subagent:packaged`: 1 file, 4 tests passed,
|
||||
including staged parent product-tool registration and the unchanged staged
|
||||
read-only child boundary.
|
||||
- `corepack pnpm run test:electron:windows`: 2 files, 6 tests passed,
|
||||
including authenticated product-tool execution under Electron Node.
|
||||
- `corepack pnpm run test:pi-subagent:packaged`: staged runtime 4/4 plus
|
||||
controlled Electron product-tool bridge 3/3 passed. It verifies browser
|
||||
status/screenshot attachment persistence, game browse/review execution,
|
||||
parent tool registration and the unchanged staged read-only child boundary.
|
||||
- Real external Provider turns remain **Explicitly Waived / Accepted Risk**;
|
||||
`realTurnVerified=false`. macOS x64/arm64 validation remains deferred to the
|
||||
mandatory PI-150 gate. Neither item is recorded as passed.
|
||||
|
||||
Reference in New Issue
Block a user