wangxuming/makelore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: float teacher introductions above a centered welcome

Browse Source
This commit is contained in:
鲨鱼辣椒
2026-09-29 16:29:19 +08:00
parent 521e1ee167
commit 5de8ea823d
6 changed files with 53 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
.project-docs/30-worklog/tasks/20260929-community-welcome-c724e5a1.md
View File

@@ -23,7 +23,7 @@
- Warm welcome heading, existing composer and a compact inspiration invitation share the empty-chat layout. Both the invitation and persistent sidebar button open only https://square.nianxx.cn/#explore in the system browser on explicit click.
- No public project feed, preview cards, community store or iframe remains in this feature. Existing unrelated Main routes are unchanged. The composer remains mounted across the first send; teacher introductions keep their prior three-successful-operation-round behavior and receive responsive clearance.
- Preserved the concurrent live help-label overlay (task 20260929-teacher-help-label-83a2f67c): the two buttons and suggestions text remain 帮我整体看🧠. Ported only its three source edits and synchronized existing expectations; peer checkout untouched.
- Temporary Renderer now loads this checkout's index-DI57yRAM.js. Existing Main PID 62668 remains running; formal installation, cloud configuration, user history and remote branches unchanged. Kept this worktree for the live trial.
- Temporary Renderer now loads this checkout's index-CwqpErpO.js. Existing Main PID 62668 remains running; formal installation, cloud configuration, user history and remote branches unchanged. Kept this worktree for the live trial.
## Verification
@@ -77,3 +77,13 @@ All three steps completed. Earlier public-feed investigation was feasibility wor
- Completed: invitation sits directly above the same mounted composer with a 12px gap. Both stay at the bottom and share the center of the space between the project sidebar and the teacher panel. The teacher panel retains its existing 340px width. Closing the panel or collapsing the sidebar recomputes the center; compact layouts scroll the heading without moving the input offscreen.
- Verification: typecheck, 77 focused unit tests, all 8 headless layout/interaction tests, lint:check (0 errors, 8 existing warnings), scoped ESLint, build:vite, native E2E --list (20 cases), documentation ownership and diff checks passed. Added desktop geometry assertions for both sidebar widths and dismissal, plus short-window input visibility. Inspected fixture and actual trial screenshots.
- Live trial: index-DI57yRAM.js, invitation-to-input gap 12px, teacher width 340px, center error 0px, input bottom gap 16px, two teacher greetings, no alert/cards/iframe. Auth identity, route and all 13 saved drafts preserved. Background refresh did not activate the app; focus monitor recorded only Chrome. The user later focused the app and conversation hydration recovered normally. Main PID 62668 remains unchanged. Evidence: trial composer-between-panels-20260929/.
## Follow-up: Floating Teachers And Centered Welcome
- Same task resumed through the ownership gate on branch/worktree above at 521e1ee; base and ownership remain unchanged. Existing Project Context Loaded still applies. Rechecked peer scopes: the help-label and formal-release work remain separate; preserve the integrated label and use only this trial checkout. No semantic conflict. Planning Gate: Passed.
- Latest user asks to restore teachers as an overlay, keep the invitation/input bottom grouping, and center the illustrated welcome. Remove teacher horizontal clearance, center the welcome vertically in the remaining area above the footer, and keep compact-screen scroll clearance. Preserve the existing teacher width, introduction lifecycle, input instance and data.
- Plan: update layout and README, verify centering and unchanged footer bounds when teachers open/close, test narrow/short windows, then refresh the trial in the background.
- Completed: teacher introductions remain fixed-width overlays at the upper right, with no reserved horizontal rail. The welcome is centered horizontally in the whole content page and vertically in the available area above the bottom invitation/composer. Invitation and input sizing and spacing remain unchanged. Desktop teacher dismissal no longer shifts either element; compact content can scroll below the overlay.
- Validation: typecheck, 77 focused unit tests, 8 headless layout/interaction cases, lint:check (0 errors, 8 existing warnings), scoped E2E ESLint, build:vite, native E2E --list (20 cases), ownership and diff checks passed. Screenshots reviewed with both teachers floating; tests assert horizontal/vertical centering, stable bounds on dismissal, collapsed sidebar alignment, bottom input and preserved drafts. Native headed tests were not run to avoid focus changes.
- Trial updated to index-CwqpErpO.js in the background. Actual live horizontal and vertical center errors are 0px, invitation gap 12px and input bottom gap 16px. No alerts/cards/iframe; auth identity, route and all 13 saved drafts unchanged. Existing teacher dismissal state was preserved. Background native capture was unavailable (UnknownVizError), so visual review used the headless layout screenshots; live DOM geometry was independently verified. Evidence: trial floating-teachers-centered-welcome-20260929/. Keep this checkout for the live trial; no merge or push.