docs(marketplace): record r6 remediation integration

This commit is contained in:
brother7 committed 2026-08-30 09:22:19 +08:00
1 parent c56ddb9d3b
commit 474c6f7688
2 files changed
+16 -131

No files matched your search

@@ -218,6 +218,13 @@
released active-worker record is removable on the next explicit cleanup, while released active-worker record is removable on the next explicit cleanup, while
background cleanup still refuses to guess a missing current selection. R5 Spec and background cleanup still refuses to guess a missing current selection. R5 Spec and
Standards reported the same three findings and no independent additional issue. Standards reported the same three findings and no independent additional issue.
- MLM-06 R6 remediation completes explicit uninstall automatically when the last
protecting worker exits, while another account snapshot continues to block deletion
and an explicit reinstall cancels the pending cleanup. Same-Release Stable/Beta
selection now persists the requested channel without a redownload or worker hot swap.
My Plugins presents system-included Data Service as supplied with MakeLore and exposes
no package download/update/delete action, while retaining project enablement and Agent
assignment. R6 Spec and Standards deduplicated to these three roots and no fourth.
## Verification ## Verification
@@ -339,10 +346,18 @@
by Windows user-directory/task-registry permissions; the identical authorized runs by Windows user-directory/task-registry permissions; the identical authorized runs
passed. No trust key, package layout, packaged resource, or artifact verifier changed, passed. No trust key, package layout, packaged resource, or artifact verifier changed,
so artifact packaging was not repeated before the fresh fixed-range review. so artifact packaging was not repeated before the fresh fixed-range review.
- MLM-06 R6 source verification passed the three owned red/green suites with 51 tests,
ten adjacent Package Store/Main/Pi/Renderer files with 116 tests, full Vitest 208 files
/ 1,812 tests with two staged-runtime skips, and the pressure case 1/1. Typecheck and
scoped ESLint passed; full lint had zero errors and the unchanged five Home/Makelore
warnings. Vite built Renderer, Main, Preload, and utility worker. Diff, project-docs,
documentation-drift, task-context completion, sole-parent, and clean-worktree gates
passed. No trust key, package layout, packaged resource, or artifact verifier changed,
so artifact packaging was not repeated before the fresh fixed-range review.
## Follow-ups ## Follow-ups
- Run fresh fixed-range MLM-06 R6 Standards and Spec reviews from the post-R5 - Run fresh fixed-range MLM-06 R7 Standards and Spec reviews from the post-R6
coordinator documentation checkpoint. Use one remediation owner only if a coordinator documentation checkpoint. Use one remediation owner only if a
supported Release A finding remains. supported Release A finding remains.
- Keep XMA-01, production activation, deployment, publication, push/PR, and every - Keep XMA-01, production activation, deployment, publication, push/PR, and every
@@ -1,130 +0,0 @@
# Task: Marketplace MLM-06 R6 fixed-range remediation
## Identity
- Task ID: 20260830-marketplace-mlm06-r6-remediation-3c8e7a52
- Mode: Feature
- Branch: codex/20260830-marketplace-mlm06-r6-remediation-3c8e7a52-marketplace-mlm06-r6-remediation
- Worktree: D:\Datas\OthersProjects\makelore-plugin-marketplace-mlm06-r6-remediation-3c8e7a52
- Base commit: 8925f37b16de7fcbb43d6b8e6b76a9eb72b4a764
- Owner: marketplace-client-coordinator-r6-remediator
- Status: Ready for Integration
## Scope
- Remediate the three deduplicated R6 client review findings from exact clean
coordinator frontier `8925f37b16de7fcbb43d6b8e6b76a9eb72b4a764`.
- Own only Package Store channel/deferred-cleanup behavior, the Main-to-Pi active
Release disposal seam, the My Plugins system-included projection, focused tests,
and this task record.
## Intent And Constraints
- Preserve immutable Release bytes and frozen active workers while making explicit
uninstall complete automatically after the last protecting worker exits; any local
account snapshot reference must continue to block deletion.
- Persist the explicitly requested Stable/Beta channel when both channels resolve to
the same immutable Release, without another download or hot-swapping a worker.
- Present `system_included` as supplied with MakeLore and suppress device package
actions, while preserving project enablement and Agent assignment actions.
- Test first. Keep one source commit and one writer. Do not touch Server, user root
worktrees, Release B/Provider/hosted runtime/billing, production trust, XMA-01,
deployment, publication, push, or PR state.
## Project Context Loaded
Task context:
- Task ID: `20260830-marketplace-mlm06-r6-remediation-3c8e7a52`
- Mode: Feature
- Branch: `codex/20260830-marketplace-mlm06-r6-remediation-3c8e7a52-marketplace-mlm06-r6-remediation`
- Worktree: `D:\Datas\OthersProjects\makelore-plugin-marketplace-mlm06-r6-remediation-3c8e7a52`
- Base commit: `8925f37b16de7fcbb43d6b8e6b76a9eb72b4a764`
- Other active local tasks: the clean client coordinator and read-only R6 Standards/
Spec reviewers are the only relevant same-topic owners; historical owners are
completed/ready-for-integration.
- Overlap or semantic-conflict assessment: review overlap is intentional and read-only;
both axes independently report the same three roots. No concurrent product writer or
contradictory decision exists.
Read:
- `AGENTS.md`; `implement-spec`, `maintain-project-docs`, and `code-review` skills.
- Project entry/planning memory, positioning, current state, decisions, architecture,
domain/evidence/reflection/commitment/stale indexes, coordinator record, R6 review records.
- Canonical Marketplace implementation spec, ticket graph MLM-02/MLM-06, and accepted
design Package Store/channel/system-included sections.
Relevant understanding:
- Project goal: Release A has one safe Package Store/effective projection chain while
acquisition, installation, enablement, assignment, runtime, and billing remain separate.
- Current integrated focus: post-R5 client branch is clean; Server R7 is frozen/pass.
- Active task scope: three surgical client corrections only.
- Active constraints: active worker and account references are authorities; Beta is
explicit; bundled Data Service never enters Library/admission/download.
- Decisions affecting this task: Package Store cleanup only removes unreferenced Releases;
current workers never hot-swap; stable/Beta remain distinct user intent.
- Evidence/commitments: existing R5 full unit/typecheck/lint/build evidence is the baseline;
official production public key and XMA-01 remain holds.
- Files likely involved: `electron/coding-plugins/package-store.ts`,
`electron/api/coding-composition.ts`, `electron/coding-runtime/pi/runtime.ts`,
`src/pages/MyPlugins/index.tsx`, and their focused tests.
- Unknowns/stale docs/conflicts: shared canonical memory predates Marketplace but the exact
coordinator/spec/review records are authoritative; no semantic conflict remains.
Gate result:
- Passed.
## Plan
1. Add red Package Store/lifecycle tests for deferred explicit cleanup and same-Release
channel switching, plus a red My Plugins system-included projection test.
2. Implement the smallest Package Store, awaited worker-disposal, and Renderer changes.
3. Run focused/adjacent tests, typecheck, lint, Vite build, then one full unit run and
pressure case; update documentation gates and create one source commit.
## Outcome
- Explicit device-package removal now records a bounded pending cleanup only when an
active worker protects the Release. The final worker disposal is awaited through the
Main-to-Pi lifecycle and retries the explicit cleanup; another local account snapshot
still protects the immutable package, and an explicit reinstall cancels the pending
removal intent.
- Stable/Beta selection now persists the explicitly requested channel even when resolve
returns `keep` or reuses the same cached immutable Release. It does not redownload or
hot-swap a running worker.
- My Plugins treats `system_included` Data Service as supplied with MakeLore: it exposes
neither download/update/device-delete nor package-failure copy, while retaining the
separate project-enable and Agent-assignment navigation.
- No Server, Release B, provider/hosted/billing, production trust, XMA-01, deployment,
publication, push, or PR state was changed.
## Verification
- TDD red/green boundaries:
- active-worker explicit uninstall initially retained the index after release; green
after deferred cleanup and awaited worker disposal;
- Stable-to-Beta same-Release `keep` and cached reuse initially returned/persisted
Stable; green with one download and requested-channel persistence;
- system-included Data Service initially rendered "尚未下载到设备" and a download
action; green with supplied-with-MakeLore projection and no device action.
- Added protections: another account snapshot still blocks deferred deletion; an
explicit reinstall cancels it; Pi worker stop does not settle before async release
cleanup finishes.
- Focused owned tests: 3 files, 51 passed.
- Adjacent Package Store/Main/Pi/Renderer regression: 10 files, 116 passed.
- Full unit suite: 208 files, 1812 passed, 2 skipped; pressure suite: 1 file, 1 passed.
- `pnpm run typecheck`: passed.
- Scoped ESLint: passed. Full `pnpm run lint:check`: 0 errors and the unchanged 5
out-of-scope warnings in Home/Makelore.
- `pnpm run build:vite`: passed for Renderer, Main, Preload, and utility bundles; only
existing dynamic-import/chunk-size warnings were reported.
- `git diff --check`: passed.
## Follow-ups
- Integrate the sole source commit into the clean client coordinator, then run fresh
fixed-range Standards and Spec reviews before opening XMA-01.
- Official Ed25519 production public key remains an external production-activation hold.
## Promotion Candidates
- None recorded.