fix(coding): remediate data service review findings

This commit is contained in:
brother7 committed 2026-08-27 00:52:07 +08:00
1 parent 239e20d2cf
commit 38843e091f
15 files changed
+449 -194

No files matched your search

@@ -237,6 +237,7 @@ describe.each(ASSETS)('generated Data Service SDK (%s)', (assetName) => {
describe('bundled Data Service Skill packaging', () => {
it('ships both canonical assets and an ordered workflow with explicit completion criteria', async () => {
const skill = await readFile(path.resolve('resources/coding-skills/data-service/SKILL.md'), 'utf8');
const readme = await readFile(path.resolve('README.md'), 'utf8');
const tsAsset = await readFile(path.join(ASSET_ROOT, 'makelore-data.ts'), 'utf8');
const jsAsset = await readFile(path.join(ASSET_ROOT, 'makelore-data.js'), 'utf8');
@@ -254,9 +255,14 @@ describe('bundled Data Service Skill packaging', () => {
expect(skill.indexOf('read-back')).toBeLessThan(skill.indexOf('report'));
expect(skill).toContain('src/lib/makelore-data.js');
expect(skill).toContain('makelore-data.js');
expect(skill).toContain('injectProjectData: true');
expect(skill).not.toContain('inject_project_data');
expect(skill).toContain('逐字复制');
expect(skill).toContain('no-op');
expect(skill).toContain('冲突');
expect(readme).toContain('data-service');
expect(readme).toContain('显式请求');
expect(readme).toContain('预览');
const packaged = await listProductCodingSkills(path.resolve('resources/coding-skills'));
const dataService = packaged.find(({ id }) => id === 'data-service');
expect(dataService).toMatchObject({ id: 'data-service', name: 'data-service' });