feat: include approved Code sidebar actions in combined trial source
This commit is contained in:
1 parent
16b10c44f1
commit
18e4be66da
12 files changed
+596
-61
No files matched your search
@@ -0,0 +1,57 @@
|
||||
# Task: Enable requested Code sidebar changes in current temporary app
|
||||
|
||||
## Identity
|
||||
|
||||
- Task ID: 20261013-trial-sidebar-update-8e37a2c1
|
||||
- Mode: Feature
|
||||
- Branch: codex/20261013-trial-sidebar-update-8e37a2c1-trial-sidebar-update
|
||||
- Worktree: /Users/chillishark/Makelore 麦洛/.codex-worktrees/makelore/20261013-trial-sidebar-update-8e37a2c1
|
||||
- Base commit: 16b10c44f1b846f33dbf28c0050f15a68fdae53b
|
||||
- Owner: codex
|
||||
- Status: In Progress
|
||||
|
||||
## Scope
|
||||
|
||||
- Enable the requested Coding前端-页面修改2 thread's latest Code sidebar correction in the current temporary app alongside the delivered TOOL/SKILL and left-card knowledge upload correction. Preserve earlier address-bar/refresh-icon/Work-tab introduction layout changes already included in the baseline.
|
||||
|
||||
## Intent And Constraints
|
||||
|
||||
- User explicitly requested updating the current temporary app with this thread's work. Apply only committed Renderer/UI/test/README changes from 20e2e5996079fea29296c604f96acc268f8c65ce; do not merge or push main, clean worktrees, deploy cloud patches, restart Main, save/apply live Agent configuration, mutate user conversations, record audio or call models. Preserve current login, saved configuration, draft/input and ongoing work; refresh only after actual native saved/idle evidence.
|
||||
|
||||
## Project Context Loaded
|
||||
|
||||
- Task ID/mode/branch/worktree/base: Identity above exactly matches official check/start/status. New managed feature worktree from the previous task's docs-only delivery commit16b10c4, with effective Renderer ad223603 and actual Main020b366/PID12660/Host58003.
|
||||
- Other active local tasks: all50 exact peer owner/task-record paths were read only by delegated audit. Source sidebar task ready; recent Agent selectors, knowledge layout, channel, composer and consolidation tasks are compatible. An old child-language placeholder has unknown scope but no concrete dependency here. No peer or canonical edits.
|
||||
- Read: AGENTS, entry/read-before-planning, memory-index, own record, positioning, historical integrated current-state, decision-index, relevant system-overview, community-collaboration, project conversations/archive domain rules, success criteria, evidence/reflection/commitment indexes and source sidebar record. Read requested thread's latest14 turns, distinguishing source user directions from screenshots and old deployment instructions.
|
||||
- Project goal/current focus: creative Electron client with project-scoped Code state and Main-owned auth/runtime/API. Shared integrated docs are historical; current runtime pointer plus immutable snapshot identify the actual temporary baseline.
|
||||
- Scope/constraints/decisions: sidebar hierarchy is already user-approved; archive remains recoverable and task/conversation identity stays Main-owned. TOOL/SKILL and left upload remain as just explicitly corrected. No API/schema, provider, runtime, account or cloud deployment change is needed.
|
||||
- Evidence/reflection/commitments: source79 units and two focused Electron scenarios passed; historical broad navigation/titlebar assertions failed before this source and are not a delivery proof. Feature-mode docs are task-scoped; source records remain read only. Real provider/cloud deployment acceptance remains separate.
|
||||
- Likely files: Sidebar.tsx, MainLayout.tsx, sidebar-peek.ts, CodingProjectConversations.tsx, classroom-workspace.css plus exact source README/test hunks. All five source product files in20e2e59^ are byte-identical to this task base, so the source patch needs no product conflict resolution. d12d214 Work-tab intro fix and d787267 address-bar fix are already ancestors.
|
||||
- Unknowns/conflicts: broad historical test failures retained as limits; none blocks the targeted change. Planning Gate: Passed before implementation.
|
||||
|
||||
## Plan
|
||||
|
||||
1. Apply the exact source feature hunks excluding its peer task record; verify no Main/shared/resources/package/lock/build-config delta and preserve current corrections.
|
||||
2. Run focused source unit/UI scenarios, current Agent regression assertions, typecheck, lint and default full build; review resulting immutable source.
|
||||
3. Prepare a file-only Renderer overlay over identical current Main bytes. Check live native UI saved/idle state, activate files, refresh through CUA, verify Code sidebar and retained Agent controls; finalize runtime metadata only after actual observation.
|
||||
|
||||
## Outcome
|
||||
|
||||
- Applied exact source20e2e59 product/README/test hunks, excluding its peer task record. New conversation is labeled and left aligned; project-card overflow owns archived/recent lists and project settings, while per-conversation rename/recoverable archive/restore and task state remain unchanged. Open project menus retain sidebar preview through the independent menu peek source.
|
||||
- Independent combined-tree review passed: five changed product files exactly match source; all three TOOL/SKILL/knowledge product files stay identical toad223603; Main/shared/resources/package/lock/build config delta versus actual Main020b366 is empty. Prior Work-tab welcome hiding, address bar placement and icon refresh remain included.
|
||||
- Default compiled build is ready; immutable snapshot and saved/idle native refresh/verification remain to deliver before runtime metadata finalization.
|
||||
|
||||
## Verification
|
||||
|
||||
- Typecheck, changed-file ESLint, default full build:vite with NIANCODE_RENDERER_ONLY unset, git diff --check and task-aware document drift passed.
|
||||
- 136 unit cases passed (source79 plus existing Agent configuration/knowledge57); ten test files. The two focused isolated Electron scenarios both passed (3.4s and3.9s, total8.3s): conversation rename/archive/restore without selecting/stopping target; project-targeting, peek-menu behavior, keyboard access and 128/171/256px left alignment/full label/no overflow.
|
||||
- Logs: /tmp/makelore-sidebar8e37-{type,lint,unit,build,electron}.log; Electron screenshots/artifacts: /tmp/makelore-sidebar8e37-electron. Tests use isolated temporary state and synthetic host, not real user projects/model/cloud mutations.
|
||||
- Source's broader historical titlebar/equal-height assertions are unrelated existing mismatches and were not rerun or counted as passed. No full-suite or real-provider claim.
|
||||
|
||||
## Follow-ups
|
||||
|
||||
- None recorded.
|
||||
|
||||
## Promotion Candidates
|
||||
|
||||
- None recorded.
|
||||
Reference in new issue
Block a user