From 13efe84d424746948055fc03693db5e25f12a1b7 Mon Sep 17 00:00:00 2001 From: brother7 <7brother7@gmail.com> Date: Mon, 24 Aug 2026 13:48:46 +0800 Subject: [PATCH] fix: accept pnpm release verifier arguments --- .../30-worklog/tasks/20260824-pi-release-proof-3e725ac7.md | 5 +++++ scripts/verify-pi-product-artifact.mjs | 1 + tests/unit/pi-product-artifact.test.ts | 2 ++ 3 files changed, 8 insertions(+) diff --git a/.project-docs/30-worklog/tasks/20260824-pi-release-proof-3e725ac7.md b/.project-docs/30-worklog/tasks/20260824-pi-release-proof-3e725ac7.md index 10f480f..a59346c 100644 --- a/.project-docs/30-worklog/tasks/20260824-pi-release-proof-3e725ac7.md +++ b/.project-docs/30-worklog/tasks/20260824-pi-release-proof-3e725ac7.md @@ -96,6 +96,11 @@ Windows Playwright worker exit with code `3221226505`; both isolated paths passed and the final uninterrupted full run passed. - Final-product artifact verification is pending. +- First Windows packaging on candidate `8820e82` passed, and the existing + Windows artifact verifier passed. The first invocation of the new Pi verifier + exposed that pnpm `10.33.4` forwards the conventional `--` separator to the + script; the parser is being corrected and the artifact will be rebuilt from + the corrected commit before evidence is accepted. ## Follow-ups diff --git a/scripts/verify-pi-product-artifact.mjs b/scripts/verify-pi-product-artifact.mjs index 487925a..00faf6b 100644 --- a/scripts/verify-pi-product-artifact.mjs +++ b/scripts/verify-pi-product-artifact.mjs @@ -26,6 +26,7 @@ export function parsePiArtifactVerifierArgs(argv, projectRoot = process.cwd()) { index += 1; return value; }; + if (argument === '--') continue; if (argument === '--app-exe') options.executable = resolve(next()); else if (argument === '--report') options.reportPath = resolve(next()); else if (argument === '--samples') options.samples = Number.parseInt(next(), 10); diff --git a/tests/unit/pi-product-artifact.test.ts b/tests/unit/pi-product-artifact.test.ts index 781871f..5e6897d 100644 --- a/tests/unit/pi-product-artifact.test.ts +++ b/tests/unit/pi-product-artifact.test.ts @@ -92,6 +92,8 @@ describe('final Pi product artifact verification', () => { '--timeout-ms', '12000', '--report', 'release/evidence/pi.json', ], 'D:\\repo')).toMatchObject({ samples: 5, timeoutMs: 12_000 }); + expect(parsePiArtifactVerifierArgs(['--', '--samples', '3'], 'D:\\repo')) + .toMatchObject({ samples: 3 }); expect(() => parsePiArtifactVerifierArgs(['--samples', '0'], 'D:\\repo')) .toThrow('--samples must be a positive integer'); expect(() => parsePiArtifactVerifierArgs(['--unknown'], 'D:\\repo'))