fix: simplify account password flow

control-plane/src/auth.ts

@@ -20,7 +20,6 @@ export interface AuthUser {
   organizationId: string;
   username: string;
   role: AuthRole;
-  mustChangePassword: boolean;
 }
 
 export interface PublicAccount {
@@ -28,7 +27,6 @@ export interface PublicAccount {
   username: string;
   role: AuthRole;
   is_active: boolean;
-  must_change_password: boolean;
   authorized_business_route_ids: BusinessRouteId[];
   business_authorization_revision: number;
   last_login_at: string | null;
@@ -74,8 +72,8 @@ function validateUsername(value: string): string {
 
 function validatePassword(value: string): string {
   const password = String(value || '');
-  if (password.length < 12 || password.length > 512) {
-    throw new AuthError('password_invalid', '密码必须为 12—512 个字符。', 400);
+  if (!password) {
+    throw new AuthError('password_invalid', '密码不能为空。', 400);
   }
   return password;
 }
@@ -111,8 +109,7 @@ function mapUser(row: Record<string, unknown>): AuthUser {
     id: String(row.id),
     organizationId: String(row.organization_id),
     username: String(row.username),
-    role: normalizeRole(row.role),
-    mustChangePassword: row.must_change_password === true || String(row.must_change_password) === 'true'
+    role: normalizeRole(row.role)
   };
 }
 
@@ -126,7 +123,6 @@ function mapAccount(row: Record<string, unknown>): PublicAccount {
     username: String(row.username),
     role,
     is_active: row.is_active === true || String(row.is_active) === 'true',
-    must_change_password: row.must_change_password === true || String(row.must_change_password) === 'true',
     authorized_business_route_ids: role === 'admin' ? [...ALL_BUSINESS_ROUTE_IDS] : storedRouteIds,
     business_authorization_revision: Math.max(0, Number(row.business_authorization_revision || 0)),
     last_login_at: isoOrNull(row.last_login_at),
@@ -141,7 +137,7 @@ async function loadPublicAccount(
   userId: string
 ): Promise<PublicAccount | null> {
   const result = await client.query(
-    `SELECT u.id, u.username, u.role, u.is_active, u.must_change_password,
+    `SELECT u.id, u.username, u.role, u.is_active,
             u.business_authorization_revision,
             u.last_login_at, u.created_at, u.updated_at,
             COALESCE(ARRAY(
@@ -217,13 +213,13 @@ export class AuthService {
                must_change_password = false, password_changed_at = now(),
                failed_login_count = 0, locked_until = NULL, updated_at = now()
            WHERE id = $2
-           RETURNING id, organization_id, username, role, must_change_password`,
+           RETURNING id, organization_id, username, role`,
           [passwordHash, existing.rows[0].id]
         )
         : await client.query(
-          `INSERT INTO users (organization_id, username, password_hash, role, must_change_password)
-           VALUES ($1, $2, $3, 'admin', false)
-           RETURNING id, organization_id, username, role, must_change_password`,
+          `INSERT INTO users (organization_id, username, password_hash, role)
+           VALUES ($1, $2, $3, 'admin')
+           RETURNING id, organization_id, username, role`,
           [organization.id, normalized, passwordHash]
         );
       const user = mapUser(result.rows[0]);
@@ -242,7 +238,7 @@ export class AuthService {
     const pool = getPool(this.config);
     const lookup = await pool.query(
       `SELECT id, organization_id, username, password_hash, role, is_active,
-              must_change_password, failed_login_count, locked_until
+              failed_login_count, locked_until
        FROM users
        WHERE organization_id = (SELECT id FROM organizations WHERE slug = $1)
          AND username = $2`,
@@ -334,7 +330,7 @@ export class AuthService {
   async listAccounts(actor: AuthUser): Promise<PublicAccount[]> {
     this.requireAdmin(actor);
     const result = await getPool(this.config).query(
-      `SELECT u.id, u.username, u.role, u.is_active, u.must_change_password,
+      `SELECT u.id, u.username, u.role, u.is_active,
               u.business_authorization_revision,
               u.last_login_at, u.created_at, u.updated_at,
               COALESCE(ARRAY(
@@ -357,7 +353,6 @@ export class AuthService {
       username: string;
       password: string;
       role: AuthRole;
-      mustChangePassword?: boolean;
       businessRouteIds?: readonly string[];
     },
     requestId: string
@@ -366,7 +361,6 @@ export class AuthService {
     const username = validateUsername(input.username);
     const passwordHash = await argon2.hash(validatePassword(input.password), { type: argon2.argon2id });
     const role = normalizeRole(input.role);
-    const mustChangePassword = input.mustChangePassword !== false;
     const businessRouteIds = role === 'admin' ? [] : normalizeBusinessRouteIds(input.businessRouteIds);
     return withTransaction(this.config, async (client) => {
       await client.query(
@@ -380,10 +374,10 @@ export class AuthService {
       if (existing.rowCount) throw new AuthError('account_exists', '该账号已存在。', 409);
       const created = await client.query(
         `INSERT INTO users
-          (organization_id, username, password_hash, role, must_change_password, password_changed_at)
-         VALUES ($1, $2, $3, $4, $5, now())
+          (organization_id, username, password_hash, role, password_changed_at)
+         VALUES ($1, $2, $3, $4, now())
          RETURNING id`,
-        [actor.organizationId, username, passwordHash, role, mustChangePassword]
+        [actor.organizationId, username, passwordHash, role]
       );
       const accountId = String(created.rows[0].id);
       if (businessRouteIds.length) {
@@ -399,7 +393,6 @@ export class AuthService {
       if (!account) throw new AuthError('account_not_found', '账号创建后未能读取。', 500);
       await this.accountAudit(client, actor, 'account.created', account.id, requestId, {
         role,
-        must_change_password: mustChangePassword,
         authorized_business_route_ids: account.authorized_business_route_ids
       });
       return account;
@@ -418,7 +411,7 @@ export class AuthService {
     }
     return withTransaction(this.config, async (client) => {
       const target = await client.query(
-        `SELECT id, username, role, is_active, must_change_password,
+        `SELECT id, username, role, is_active,
                 last_login_at, created_at, updated_at
            FROM users
           WHERE organization_id = $1 AND id = $2
@@ -549,7 +542,6 @@ export class AuthService {
     actor: AuthUser,
     targetUserId: string,
     password: string,
-    mustChangePassword: boolean,
     requestId: string
   ): Promise<void> {
     this.requireAdmin(actor);
@@ -562,18 +554,17 @@ export class AuthService {
       if (!target.rowCount) throw new AuthError('account_not_found', '账号不存在。', 404);
       await client.query(
         `UPDATE users
-            SET password_hash = $1, must_change_password = $2,
+            SET password_hash = $1, must_change_password = false,
                 password_changed_at = now(), failed_login_count = 0,
                 locked_until = NULL, updated_at = now()
-          WHERE id = $3`,
-        [passwordHash, mustChangePassword, targetUserId]
+          WHERE id = $2`,
+        [passwordHash, targetUserId]
       );
       const revoked = await client.query(
         'UPDATE sessions SET revoked_at = now() WHERE user_id = $1 AND revoked_at IS NULL',
         [targetUserId]
       );
       await this.accountAudit(client, actor, 'account.password_reset', targetUserId, requestId, {
-        must_change_password: mustChangePassword,
         sessions_revoked: revoked.rowCount || 0
       });
     });
@@ -657,8 +648,7 @@ export class AuthService {
   async getActiveSession(token: string | undefined): Promise<ActiveSession | null> {
     if (!token) return null;
     const result = await getPool(this.config).query(
-      `SELECT s.id AS session_id, s.csrf_token_hash, u.id, u.organization_id, u.username, u.role,
-              u.must_change_password
+      `SELECT s.id AS session_id, s.csrf_token_hash, u.id, u.organization_id, u.username, u.role
        FROM sessions s
        JOIN users u ON u.id = s.user_id
        WHERE s.token_hash = $1
@@ -681,8 +671,7 @@ export class AuthService {
         id: row.id,
         organization_id: row.organization_id,
         username: row.username,
-        role: row.role,
-        must_change_password: row.must_change_password
+        role: row.role
       })
     };
   }