fix: explain missing rooms within ARR processing scope
This commit is contained in:
1 parent
d1363be5b7
commit
36235e7d8d
4 files changed
+18
-2
No files matched your search
@@ -147,3 +147,11 @@ Read: memory-index, project-positioning, current-state latest September sections
|
||||
- Independent original-file inspection: `/Users/chillishark/Downloads/res_detail_10.7.XML` hash remainsbf1d1905e068f7c496a3caf63e3682d2aeee2b62c30ce6c87e14e2411a9d6d84.10/7 has13 CKOT rows, all with room and6 whitelisted.10/8 has27 rows with short-status codesGC14,TA11,CD1,CA1; only theCA-coded row lacks room, and its rateSRB is outside the whitelist. Do not assertCA/CD code meanings without evidence: the file provides no status legend or independent cancellation marker. This example nevertheless establishes why a missing-room record may not trigger the business validator: it is outside the rate scope. The7 related XML filenames were listed; other files were not parsed or used to infer cancellation behavior.
|
||||
- Corrected prior user-facing framing: maintaining the original rules does not require a new decision about excluding cancelled reservations. Saying that a cancellation inclusion decision was required before applying existing rules was misleading. A status exclusion or blank-room exception would be a new rule, and neither is introduced. The remaining saved10/7 record300007418 is whitelisted with missing room, which explains the current review under unchanged rules; its separate source/report-population question remains deferred by the user. Existing source may include cancelled rows with valid room, or exclude them by rate, so earlier successful XML processing is compatible with no status filtering.
|
||||
- Outcome/follow-up: explain original rate/field/dedup order directly and keep the remaining item classified as required room missing, not a newly invented cancellation error. No business code, live service, original XML, review decisions or source scope changed. Promote this clarification to canonical source/product documentation only at integration; no remote push or real daily/monthly is claimed.
|
||||
|
||||
## Same-task Follow-up: Explicit In-scope Missing-room Explanation
|
||||
|
||||
- User continues after the clarification above. Concurrent gate resumed the same task20261008-production-review-9e7b/feature/codex/owned worktree with no peers; existing project context and constraints remain loaded. Planning gate Passed: limit changes to source-review explanation, retain original rate/required-room/dedup/pricing/status behavior and immutable real data. Plan: add a specific in-scope missing-room explanation after failure/conflict/format priorities, verify it and independent date interaction locally, record remaining source limitation.
|
||||
- Outcome: the existing missing-room reasons for `DISP_ROOM_NO` now display that the rate is within the current processing scope but the source did not supply a room. Chinese/English/Thai copy is supplied. Confirmed decisions, failed reads, conflicting sources and invalid values retain precedence; this does not add a cancellation filter or bypass required-room validation. Backend, original XML and the business processor are unchanged.
|
||||
- Independent saved-evidence recheck: confirmation300007418/internal5131529 has no roomId in first/final search, detail roomStay/currentRoomInfo or arrival-day rate segments. Room calendar returned HTTP200 with empty roomCalendar and no associated room/history. `PM` is a room type, not a usable room number. Both search/detail show Cancelled and rateGL2200KR in the original whitelist. Existing capture cannot legitimately supply a room; cancellation is not asserted as the cause of missing data. No new Oracle call occurred.
|
||||
- Verification:46 JavaScript tests passed, including failure/conflict precedence for room issues, pending dates/drafts, explicit finalization and uncertain request recovery; node syntax and Git whitespace checks passed. CUA refreshed the live page and verified the new explanation for300007418,0/1 confirmed and disabled report generation. Selecting10/6 enabled download without submitting; returning to10/7 restored the same item. No new task or actual download was started. Authenticated local read confirms revision1/pending1/job=null; original source SHA remains805799ba2f3edd7f1cf18c14e5304908061d6194a241c5fc255192728b7f388a. Static assets were served immediately; no service restart was needed.
|
||||
- Private screenshot: `/Users/chillishark/Library/Application Support/ARR2.0/production-validation-20261007/room-missing-in-scope-20261008.png`. Result tab retained as deliverable. No real source/manual decision was changed and no real daily/monthly generated. Follow-up remains a verified room value or a separately requested business-rule/source-scope decision; do not invent a room, silently drop a candidate or call the report complete. Promote the more precise explanation to canonical product documentation at integration if useful.
|
||||
Reference in new issue
Block a user