Exclude cancelled reservations before ARR field review

This commit is contained in:
Wyndham ARR committed 2026-10-08 20:19:27 +08:00
1 parent 36235e7d8d
commit 0c057a8e75
39 files changed
+1546 -56

No files matched your search

@@ -0,0 +1,9 @@
# Check report eligibility before requesting missing values
The repeated room-completion explanation was technically accurate about the old status-blind validator but led to the wrong product action: an unassigned Cancelled booking was treated as though staff must supply a room. Field requirements only apply after the record belongs in the report. A missing mandatory schema value does not by itself justify asking staff to fabricate or locate a value that may legitimately never exist.
Inspect source status and report membership before opening field completion. If the old code has no relevant eligibility rule, distinguish the existing validator from the missing business decision. Explain the full population impact and obtain the business requirement; never drop just the row that fails validation. Here the user explicitly chose to exclude all cancelled bookings, affecting two rate candidates (six raw records), so both assigned and unassigned cancellations now follow the same audited decision before field checks and deduplication.
Keep original evidence and source order, record exclusion separately from rate filtering, version the processing rules, and upgrade pending immutable identities explicitly. A safe code fix is not a final report: the real10/7 run subsequently reached legitimate two-key price review, requiring actual prices before Finance/monthly acceptance.
Promotion candidate: add eligibility-before-completion as a project debugging/review principle at integration; no new blanket permission or approval workflow is proposed.